<div dir="ltr">Hello,<div><br></div><div>Basically, that code is responsible for finding and removing aliases. The old code (that I replaced) is this [1]. As far as I understand (now), aliases should only be removed from the `FROM` clause and wherever they are found in other clauses.</div><div><br></div><div>I had a fix prepared, but exams and homework came and I did not get to work on it anymore. My last exam is on 16. If no other fix is proposed by then, I will push mine.</div><div><br></div><div>[1] <a href="https://github.com/phpmyadmin/phpmyadmin/blob/RELEASE_4_4_15/tbl_export.php#L39">https://github.com/phpmyadmin/phpmyadmin/blob/RELEASE_4_4_15/tbl_export.php#L39</a><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Dec 13, 2015 at 8:41 PM, Raghu Ram <span dir="ltr"><<a href="mailto:raghuram.vadapalli@research.iiit.ac.in" target="_blank">raghuram.vadapalli@research.iiit.ac.in</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I think that part of code need not be removed. An empty array is passed for replaces where actually an array of tokens is expected (I am talking about call to replaceTokens function on <a href="https://github.com/phpmyadmin/phpmyadmin/blob/master/tbl_export.php#L109" target="_blank">https://github.com/phpmyadmin/phpmyadmin/blob/master/tbl_export.php#L109</a>). That is the reason aliases are not replaced.<div><div class="h5"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Dec 13, 2015 at 11:37 PM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Dan,<br>
<br>
in tbl_export.php you wrote some logic (lines 116 to 172) that deals<br>
with aliases. Could you give a use case where this logic is important? I<br>
am asking because of<br>
<br>
<a href="https://github.com/phpmyadmin/phpmyadmin/issues/11679" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/phpmyadmin/issues/11679</a><br>
and<br>
<a href="https://github.com/phpmyadmin/phpmyadmin/pull/11738" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/phpmyadmin/pull/11738</a><br>
<span><font color="#888888"><br>
--<br>
Marc Delisle | phpMyAdmin<br>
<br>
_______________________________________________<br>
Developers mailing list<br>
<a href="mailto:Developers@phpmyadmin.net" target="_blank">Developers@phpmyadmin.net</a><br>
<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/mailman/listinfo/developers</a><br>
</font></span></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
Developers mailing list<br>
<a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a><br>
<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/mailman/listinfo/developers</a><br>
<br></blockquote></div><br></div>