<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Feb 18, 2016 at 6:54 PM, Michal Čihař <span dir="ltr"><<a href="mailto:michal@cihar.com" target="_blank">michal@cihar.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi<br>
<br>
Dne 15.2.2016 v 08:44 Michal Čihař napsal(a):<br>
<span class="">> Thinking more about this, using composer is probably best approach here.<br>
> It's too late for including this change in 4.6.0, but we can target on<br>
> 4.7.0:<br>
><br>
> <a href="https://github.com/phpmyadmin/phpmyadmin/issues/11962" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/phpmyadmin/issues/11962</a><br>
<br>
</span>And pull request is here:<br>
<br>
<a href="https://github.com/phpmyadmin/phpmyadmin/pull/11976" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/phpmyadmin/pull/11976</a><br>
<br>
Comments welcome :-).<br>
<div class=""><div class="h5"><br>
--<br>
        Michal Čihař | <a href="http://cihar.com" rel="noreferrer" target="_blank">http://cihar.com</a> | <a href="http://blog.cihar.com" rel="noreferrer" target="_blank">http://blog.cihar.com</a><br>
<br>
</div></div><br>_______________________________________________<br>
Developers mailing list<br>
<a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a><br>
<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/mailman/listinfo/developers</a><br>
<br></blockquote></div><br></div><div class="gmail_extra">Hello Michael,</div><div class="gmail_extra"><br></div><div class="gmail_extra">The pull request seems fine, but I did not have really much time to check it properly (I'm out of town and had little time to properly check it out). However, I have one question: the old class autoloader that was used to include the sql-parser required php-gettext before registering [1] the autoloader because of issue #11677 [2]. Is there any mechanism to include php-gettext first so this problem does not show up again?</div><div class="gmail_extra"><br></div><div class="gmail_extra">I hope I will have more free time to properly review and test it.</div><div class="gmail_extra"><br></div><div class="gmail_extra">[1] <a href="https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/sql-parser/autoload.php#L70">https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/sql-parser/autoload.php#L70</a></div><div class="gmail_extra">[2] <a href="https://github.com/phpmyadmin/phpmyadmin/issues/11677">https://github.com/phpmyadmin/phpmyadmin/issues/11677</a></div><div class="gmail_extra"><br></div><div class="gmail_extra">Best regards,</div><div class="gmail_extra">Dan Ungureanu</div></div>