<div dir="ltr">I have just proposed some basic idea on how I will I work on it. Here is the link to my GSOC Proposal <a href="https://docs.google.com/document/d/104yLW991tFJ0mOZNRMm-nx-nxnlI8oWmHWV-_tXFz5U/edit#">https://docs.google.com/document/d/104yLW991tFJ0mOZNRMm-nx-nxnlI8oWmHWV-_tXFz5U/edit#</a> Can you please review and check if everything is going fine.<div><br></div><div>Thanks,</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr">Manish Bisht</div><div dir="ltr">Email : <a href="mailto:hi@manishbisht.me" target="_blank">hi@manishbisht.me</a></div><div dir="ltr"><span style="font-size:12.8px">Website</span><span style="font-size:12.8px"> : </span><a href="https://manishbisht.me/" style="font-size:12.8px" target="_blank">https://manishbisht.me</a></div><div><br></div></div></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Wed, Mar 29, 2017 at 8:33 PM, Isaac Bennetch <span dir="ltr"><<a href="mailto:bennetch@gmail.com" target="_blank">bennetch@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 3/29/17 10:26 AM, Manish Bisht wrote:<br>
> Hi,<br>
><br>
> The last discussion I can see on making phpyadmin responsive was<br>
> this <a href="https://github.com/phpmyadmin/phpmyadmin/wiki/2014-02_Meeting#Mobile_version:_follow-up" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/<wbr>phpmyadmin/wiki/2014-02_<wbr>Meeting#Mobile_version:_<wbr>follow-up</a><br>
> <<a href="https://github.com/phpmyadmin/phpmyadmin/wiki/2014-02_Meeting#Mobile_version:_follow-up" rel="noreferrer" target="_blank">https://github.com/<wbr>phpmyadmin/phpmyadmin/wiki/<wbr>2014-02_Meeting#Mobile_<wbr>version:_follow-up</a>> So<br>
> I just wanted to know that is this issue is in priority ?<br>
<br>
</span>I think the problem is that we can't disrupt large amounts of the core<br>
phpMyAdmin code for a massive rewrite, and no developer wishes to take<br>
responsibility to work on this. It will probably make a good GSoC<br>
project, because a student will have time to work on it through the<br>
summer and, even if parts remain unfinished, the project won't stall and<br>
languish with lack of developer time. I hope that makes sense. I'm not<br>
sure how it will fit with GSoC due to the timeline; part of me sees ways<br>
we can improve this with minimal effort and disruption to the code and<br>
the other part of me thinks it's going to be too big for GSoC and too<br>
disruptive to implement.<br>
<br>
Honestly, out of all the tasks on the entire ideas list, this is the one<br>
I'm least certain about. A good proposal for this particular project<br>
would probably show how the student has anticipated working on this in<br>
stages and has an honest and reasonable assessment of the time required.<br>
<br>
As far as whether I, personally, think it's a good direction for the<br>
project to go; I'm about 60% for including it and 40% don't see the<br>
point (figuring that most serious development can't yet occur on a<br>
tablet of phone, but realizing the value of being responsive to the<br>
handful of user requests we've had for this functionality).<br>
<br>
> Thanks,<br>
><br>
><br>
> Manish Bisht<br>
<span class="">> Email : <a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a> <mailto:<a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a>><br>
> Website : <a href="https://manishbisht.me" rel="noreferrer" target="_blank">https://manishbisht.me</a> <<a href="https://manishbisht.me/" rel="noreferrer" target="_blank">https://manishbisht.me/</a>><br>
><br>
><br>
</span><span class="">> On Wed, Mar 22, 2017 at 11:37 PM, Manish Bisht<br>
</span><span class="">> <<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.com</a> <mailto:<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.<wbr>com</a>>> wrote:<br>
><br>
> Hi,<br>
><br>
> I have submitted the draft of my GSoC Proposal. Can someone from the<br>
> organisation review it.<br>
><br>
> Thanks,<br>
><br>
><br>
> Manish Bisht<br>
</span><span class="">> Email : <a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a> <mailto:<a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a>><br>
> Website : <a href="https://manishbisht.me" rel="noreferrer" target="_blank">https://manishbisht.me</a> <<a href="https://manishbisht.me/" rel="noreferrer" target="_blank">https://manishbisht.me/</a>><br>
><br>
><br>
</span><span class="">> On Wed, Mar 1, 2017 at 4:38 PM, Manish Bisht<br>
</span><span class="">> <<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.com</a> <mailto:<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.<wbr>com</a>>> wrote:<br>
><br>
> Yes, I will do my detailed discussion there.<br>
><br>
> I've already commented on this in the issue tracker:<br>
> Not sure how to best approach this, but we should avoid the<br>
> double<br>
> encoding problem. On the other side the charset selector for<br>
> import has<br>
> to stay for SQL files which do not do SET NAMES and for<br>
> other formats<br>
> like CSV. Maybe disable our charset conversion once we spot<br>
> SET NAMES<br>
> in the SQL?<br>
> If you want to followup, please do that in the issue<br>
> tracker, so that<br>
> whole discussion stays in one place.<br>
><br>
><br>
> Manish Bisht<br>
</span><span class="">> Email : <a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a> <mailto:<a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a>><br>
> Website : <a href="https://manishbisht.me" rel="noreferrer" target="_blank">https://manishbisht.me</a> <<a href="https://manishbisht.me/" rel="noreferrer" target="_blank">https://manishbisht.me/</a>><br>
><br>
><br>
</span><span class="">> On Wed, Mar 1, 2017 at 4:35 PM, Manish Bisht<br>
</span>> <<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.com</a> <mailto:<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.<wbr>com</a>>><br>
<div><div class="h5">> wrote:<br>
><br>
> Any update on my implementation of this ?<br>
><br>
> 1. Improve responsive/mobile interface<br>
> Is there any designed proposed for mobile till now ? The<br>
> last discussion i can see on this was<br>
> this <a href="https://github.com/phpmyadmin/phpmyadmin/wiki/2014-02_Meeting#Mobile_version:_follow-up" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/<wbr>phpmyadmin/wiki/2014-02_<wbr>Meeting#Mobile_version:_<wbr>follow-up</a><br>
> <<a href="https://github.com/phpmyadmin/phpmyadmin/wiki/2014-02_Meeting#Mobile_version:_follow-up" rel="noreferrer" target="_blank">https://github.com/<wbr>phpmyadmin/phpmyadmin/wiki/<wbr>2014-02_Meeting#Mobile_<wbr>version:_follow-up</a>> Also<br>
> it was mentioned that this feature in right now not in<br>
> priority.<br>
> My plan to implement this is to make the interface the<br>
> mobile first.<br>
> a) The left side bar with id pma_navigation can be put<br>
> as the menu/hamburger icon for smaller screens<br>
> b) The div with id serverinfo will still remain at the top.<br>
> c) The div with id topmenucontainer will be implemented<br>
> as the horizontal scrolling like this (Open this link<br>
> in <a href="https://getmdl.io/components/index.html" rel="noreferrer" target="_blank">https://getmdl.io/components/<wbr>index.html</a><br>
> <<a href="https://getmdl.io/components/index.html" rel="noreferrer" target="_blank">https://getmdl.io/components/<wbr>index.html</a>> on mobile you<br>
> will see the horizontal scrolling at the top for about,<br>
> getting started etc.)<br>
> d) The div with id maincontainer will now have the main<br>
> content. Home page boxes (General settings, Database<br>
> server etc) can be shown in the vertical order. Right<br>
> now it works but there is still some spacing issues.<br>
> Tables can be shown with some min-width because it will<br>
> not fit on smaller screen sizes when the number of<br>
> columns in the table are more or they contains large<br>
> strings like tokens, md5 strings etc.<br>
> For status tab one more horizontal slider will be<br>
> required and then the tables one after another in<br>
> vertical position.<br>
> e) The div with id pma_console will remain same. when it<br>
> is opened on smaller devices it will open on the full<br>
> screen instead of half as in larger screens.<br>
><br>
><br>
> Manish Bisht<br>
</div></div><span class="">> Email : <a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a> <mailto:<a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a>><br>
> Website : <a href="https://manishbisht.me" rel="noreferrer" target="_blank">https://manishbisht.me</a> <<a href="https://manishbisht.me/" rel="noreferrer" target="_blank">https://manishbisht.me/</a>><br>
><br>
><br>
</span><span class="">> On Wed, Mar 1, 2017 at 2:44 PM, shishir bondre<br>
</span>> <<a href="mailto:bondreshishir@gmail.com">bondreshishir@gmail.com</a> <mailto:<a href="mailto:bondreshishir@gmail.com">bondreshishir@gmail.<wbr>com</a>>><br>
> wrote:<br>
><br>
> What will be necessary features required for the *Theme<br>
> Generator* and Expectations so that i can propose a good<br>
<span class="">> proposal and focus on these features and generate a good<br>
> idea<br>
><br>
> On Wed, Mar 1, 2017 at 2:10 PM, Michal Čihař<br>
</span><div><div class="h5">> <<a href="mailto:michal@cihar.com">michal@cihar.com</a> <mailto:<a href="mailto:michal@cihar.com">michal@cihar.com</a>>> wrote:<br>
><br>
> Hi<br>
><br>
> Manish Bisht píše v St 01. 03. 2017 v 13:30 +0530:<br>
> > 2. Disable charset conversion when importing with SET NAMES<br>
> > The list comment on this link <a href="https://github.com/phpmyadmin/phpmyadmi" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/<wbr>phpmyadmi</a><br>
> <<a href="https://github.com/phpmyadmin/phpmyadmi" rel="noreferrer" target="_blank">https://github.com/<wbr>phpmyadmin/phpmyadmi</a>><br>
> > n/issues/9419 gives the start to solve this issue.<br>
> ><br>
> > > Indeed the charset handling seems to be broken on the import:<br>
> > > the iso-8859-1 file imports fine if I choose utf-8 and keep SET<br>
> > > NAMES latin1<br>
> > > the iso-8859-1 file imports fine if I choose iso-8859-1 and remove<br>
> > > SET NAMES latin1<br>
> > > the iso-8859-1 file imports corrupted if I choose iso-8859-1 and<br>
> > > keep SET NAMES latin1<br>
> > ><br>
> ><br>
> > Any suggestions will be helpful to implement it in more better way.<br>
><br>
> I've already commented on this in the issue tracker:<br>
><br>
> Not sure how to best approach this, but we should<br>
> avoid the double<br>
> encoding problem. On the other side the charset<br>
> selector for import has<br>
> to stay for SQL files which do not do SET NAMES and<br>
> for other formats<br>
> like CSV. Maybe disable our charset conversion once<br>
> we spot SET NAMES<br>
> in the SQL?<br>
><br>
> If you want to followup, please do that in the issue<br>
> tracker, so that<br>
> whole discussion stays in one place.<br>
><br>
> --<br>
> Michal Čihař | <a href="https://cihar.com/" rel="noreferrer" target="_blank">https://cihar.com/</a> |<br>
> <a href="https://weblate.org/" rel="noreferrer" target="_blank">https://weblate.org/</a><br>
><br>
> ______________________________<wbr>_________________<br>
> Developers mailing list<br>
> <a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a><br>
</div></div>> <mailto:<a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.<wbr>net</a>><br>
> <a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/<wbr>mailman/listinfo/developers</a><br>
<span class="">> <<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/<wbr>mailman/listinfo/developers</a>><br>
><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> Developers mailing list<br>
</span>> <a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a> <mailto:<a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.<wbr>net</a>><br>
> <a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/<wbr>mailman/listinfo/developers</a><br>
<div class="HOEnZb"><div class="h5">> <<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/<wbr>mailman/listinfo/developers</a>><br>
><br>
><br>
><br>
><br>
><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> Developers mailing list<br>
> <a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a><br>
> <a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/<wbr>mailman/listinfo/developers</a><br>
><br>
<br>
______________________________<wbr>_________________<br>
Developers mailing list<br>
<a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a><br>
<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/<wbr>mailman/listinfo/developers</a><br>
</div></div></blockquote></div><br></div>