<div dir="ltr">Hi,<div><br></div><div>I am having some issues in making <span style="font-size:12.8px"> "Indexes" area responsive. I think its due to the css used f</span>or `fieldset` tag. I am working on it and will update as soon as it will be done.</div><div><br></div><div>I can add <span style="font-size:12.8px">scrolling to menu bar. But as the height of the scrollbar is more only the half area will be shown to user. Attached the screenshot displaying it. Also the scrollbar is only shown when the user is scrolling same as in tables. Let me know if it works.</span></div><div><span style="font-size:12.8px"><br></span></div><div>Thanks,</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr">Manish Bisht</div><div dir="ltr">Email : <a href="mailto:hi@manishbisht.me" target="_blank">hi@manishbisht.me</a></div><div dir="ltr"><span style="font-size:12.8px">Website</span><span style="font-size:12.8px"> : </span><a href="https://manishbisht.me/" style="font-size:12.8px" target="_blank">https://manishbisht.me</a></div><div><br></div></div></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Fri, Jun 16, 2017 at 8:10 PM, Isaac Bennetch <span dir="ltr"><<a href="mailto:bennetch@gmail.com" target="_blank">bennetch@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Manish,<br>
<span class=""><br>
On Thu, Jun 15, 2017 at 11:46 AM, Manish Bisht<br>
<<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.com</a>> wrote:<br>
> Hi,<br>
><br>
> I have now made the table structure page responsive.<br>
><br>
> Branch: <a href="https://github.com/manishbisht/phpmyadmin/tree/responsive-design" rel="noreferrer" target="_blank">https://github.com/<wbr>manishbisht/phpmyadmin/tree/<wbr>responsive-design</a><br>
> Commit:<br>
> <a href="https://github.com/manishbisht/phpmyadmin/commit/3e1d1bf3dbe739607a8de34995d2d356894b2622" rel="noreferrer" target="_blank">https://github.com/<wbr>manishbisht/phpmyadmin/commit/<wbr>3e1d1bf3dbe739607a8de34995d2d3<wbr>56894b2622</a><br>
><br>
> Please have a look at it. I will be looking forward for your suggestions.<br>
<br>
</span>I'm quite happy with how this is developing.<br>
<br>
I like how the table structure page has the scrolling for the columns<br>
"detached" from the rest of the page, so I can scroll to the right and<br>
see, for instance, the Actions area without the Information pane being<br>
affected. It would be helpful if the "Indexes" area acted the same.<br>
<br>
The databases and user accounts pages both work really well, too<br>
(everything is coming together nicely, but those two in particular<br>
seem to work especially well).<br>
<br>
One thing I'm realizing, even with the improvements you've made to the<br>
menu bar at the top of the page, my instinctive reaction is to want to<br>
grab is and scroll it (like I scroll down a page), rather than<br>
pressing the button to have it scroll. I hope that makes sense. I<br>
wonder if such a thing is easily possible and what you and some others<br>
think about this. When I first saw it, the buttons that are there made<br>
sense, but as I started using it and as more pages have been<br>
converted, it seems more natural to want to scroll it rather than<br>
having the buttons. Just my two cents.<br>
<br>
Nice work so far, thanks for the update.<br>
Isaac<br>
<div><div class="h5"><br>
<br>
> Manish Bisht<br>
> Email : <a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a><br>
> Website : <a href="https://manishbisht.me" rel="noreferrer" target="_blank">https://manishbisht.me</a><br>
><br>
><br>
> On Thu, Jun 15, 2017 at 8:43 AM, Manish Bisht <<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.com</a>><br>
> wrote:<br>
>><br>
>> I have checked the master branch of phpmyadmin and found that the error is<br>
>> coming from the main branch. Check this Issue:<br>
>> <a href="https://github.com/phpmyadmin/phpmyadmin/issues/13384" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/<wbr>phpmyadmin/issues/13384</a><br>
>><br>
>> Manish Bisht<br>
>> Email : <a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a><br>
>> Website : <a href="https://manishbisht.me" rel="noreferrer" target="_blank">https://manishbisht.me</a><br>
>><br>
>><br>
>> On Thu, Jun 15, 2017 at 8:19 AM, Manish Bisht <<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.com</a>><br>
>> wrote:<br>
>>><br>
>>> This condition `$GLOBALS['server'] != $GLOBALS['cfg']['<wbr>ServerDefault']`<br>
>>> is returning false.<br>
>>><br>
>>> In my case both the values are 1. What is the difference between both<br>
>>> variables ?<br>
>>><br>
>>> Manish Bisht<br>
>>> Email : <a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a><br>
>>> Website : <a href="https://manishbisht.me" rel="noreferrer" target="_blank">https://manishbisht.me</a><br>
>>><br>
>>><br>
>>> On Wed, Jun 14, 2017 at 11:48 PM, Manish Bisht<br>
>>> <<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.com</a>> wrote:<br>
>>>><br>
>>>> Seems like the following condition is broken.<br>
>>>><br>
>>>> if (isset($GLOBALS['server'])<br>
>>>>     && $GLOBALS['server'] != $GLOBALS['cfg']['<wbr>ServerDefault']<br>
>>>>     && ! isset($params['server'])<br>
>>>>     && ! defined('PMA_SETUP')<br>
>>>> ) {<br>
>>>>     $params['server'] = $GLOBALS['server'];<br>
>>>> }<br>
>>>><br>
>>>><br>
>>>><br>
>>>> Manish Bisht<br>
>>>> Email : <a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a><br>
>>>> Website : <a href="https://manishbisht.me" rel="noreferrer" target="_blank">https://manishbisht.me</a><br>
>>>><br>
>>>><br>
>>>> On Wed, Jun 14, 2017 at 11:35 PM, Manish Bisht<br>
>>>> <<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.com</a>> wrote:<br>
>>>>><br>
>>>>> After applying the commit the database selection from the database<br>
>>>>> seems to be broken. While playing with code got to know that the<br>
>>>>> `$GLOBALS['url_query']` seems to be broken. What is the use of this variable<br>
>>>>> so that I can find the mistake made ?<br>
>>>>><br>
>>>>> Thanks,<br>
>>>>><br>
>>>>><br>
>>>>> Manish Bisht<br>
>>>>> Email : <a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a><br>
>>>>> Website : <a href="https://manishbisht.me" rel="noreferrer" target="_blank">https://manishbisht.me</a><br>
>>>>><br>
>>>>><br>
>>>>> On Tue, Jun 13, 2017 at 10:10 PM, Manish Bisht<br>
>>>>> <<a href="mailto:manish.bisht490@gmail.com">manish.bisht490@gmail.com</a>> wrote:<br>
>>>>>><br>
>>>>>> Hi,<br>
>>>>>><br>
>>>>>> I am working on making phpmyadmin responsive. I have added the<br>
>>>>>> vertical scrolling on the tables on the databases, structure and browse<br>
>>>>>> pages<br>
>>>>>><br>
>>>>>> Branch:<br>
>>>>>> <a href="https://github.com/manishbisht/phpmyadmin/tree/responsive-design" rel="noreferrer" target="_blank">https://github.com/<wbr>manishbisht/phpmyadmin/tree/<wbr>responsive-design</a><br>
>>>>>> Commit:<br>
>>>>>> <a href="https://github.com/manishbisht/phpmyadmin/commit/25fc52aea655989bd68a16643387b45c15a44be4" rel="noreferrer" target="_blank">https://github.com/<wbr>manishbisht/phpmyadmin/commit/<wbr>25fc52aea655989bd68a16643387b4<wbr>5c15a44be4</a><br>
>>>>>><br>
>>>>>> Please have a look at it. I will be looking forward for your<br>
>>>>>> suggestions.<br>
>>>>>><br>
>>>>>> Thanks,<br>
>>>>>><br>
>>>>>> Manish Bisht<br>
>>>>>> Email : <a href="mailto:hi@manishbisht.me">hi@manishbisht.me</a><br>
>>>>>> Website : <a href="https://manishbisht.me" rel="noreferrer" target="_blank">https://manishbisht.me</a><br>
>>>>>><br>
>>>>><br>
>>>><br>
>>><br>
>><br>
><br>
><br>
</div></div>> ______________________________<wbr>_________________<br>
> Developers mailing list<br>
> <a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a><br>
> <a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/<wbr>mailman/listinfo/developers</a><br>
><br>
<br>
______________________________<wbr>_________________<br>
Developers mailing list<br>
<a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a><br>
<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/<wbr>mailman/listinfo/developers</a><br>
</blockquote></div><br></div>