<div dir="ltr"><span style="font-size:12.8px">regenerate sprites means new icons ?</span><br></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr">Manish Bisht</div><div dir="ltr">Email : <a href="mailto:hi@manishbisht.me" target="_blank">hi@manishbisht.me</a></div><div dir="ltr"><span style="font-size:12.8px">Website</span><span style="font-size:12.8px"> : </span><a href="https://manishbisht.me/" style="font-size:12.8px" target="_blank">https://manishbisht.me</a></div><div><br></div></div></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Thu, Jun 29, 2017 at 6:39 PM, Michal Čihař <span dir="ltr"><<a href="mailto:michal@cihar.com" target="_blank">michal@cihar.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello<br>
<br>
Manish Bisht píše v Čt 29. 06. 2017 v 14:12 +0530:<br>
<span class="">> I have almost made phpmyadmin responsive. Now only the designer tab<br>
> is remaining. Have a look into this branch for review: <a href="https://github" rel="noreferrer" target="_blank">https://github</a><br>
> .com/manishbisht/phpmyadmin/<wbr>blob/responsive-design/<br>
><br>
> I am looking forward for your suggestions and feedback<br>
<br>
</span>Unfortunately I didn't yet get to deeper testing, but a little bit of<br>
feedback on the code:<br>
<br>
- avoid including commented out debug statements (//console.log(wmax);)<br>
- you'we commented out most of  PMA_tbl_structure_menu_<wbr>resizer_callback<br>
and it now doesn't return value as it used to<br>
- you probably want to regenerate sprites to include left and right<br>
icons<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
        Michal Čihař | <a href="https://cihar.com/" rel="noreferrer" target="_blank">https://cihar.com/</a> | <a href="https://weblate.org/" rel="noreferrer" target="_blank">https://weblate.org/</a><br>
</font></span><br>______________________________<wbr>_________________<br>
Developers mailing list<br>
<a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a><br>
<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/<wbr>mailman/listinfo/developers</a><br>
<br></blockquote></div><br></div>