<div dir="ltr"><img width="0" height="0" class="mailtrack-img" alt="" style="display:flex" src="https://mailtrack.io/trace/mail/496064e8745f5b81e8b16e7413a38ff0965c9d15.png?u=1589778"><div></div>Thanks Mauricio for creating the new branch.<div><br></div><div>Regards,</div><div>Piyush<br><br><div class="mt-signature">
        <table border="0" cellpadding="8" cellspacing="0" style="user-select: none;">
            <tbody><tr>
                <td>
                    <a href="https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality6&" class="" style="text-decoration:none">
                        <img src="https://s3.amazonaws.com/mailtrack-signature/sender_notified.gif" alt="Mailtrack" class="" width="32" height="32">
                    </a>
                </td>
                <td>
                    <span style="color:#777">Sender notified by</span> <br>
                    <a href="https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality6&" class="mt-install" style="color:#4374f7">Mailtrack</a>
                    <span style="color:transparent;font-size:0">11/07/18, 22:38:47</span>
                </td>
                <td>
                    
                </td>
            </tr>
        </tbody></table>
    </div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 11 July 2018 at 10:07, Maurício Meneghini Fauth <span dir="ltr"><<a href="mailto:mauriciofauth@gmail.com" target="_blank">mauriciofauth@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi.<div><br></div><div>I think that's a good idea. This will greatly facilitate the review of pull requests and the development of the GSoC project.<br></div><div><br></div><div>I created a new branch called gsoc-js-refactoring [1] and changed the base branch of the first PR to that branch [2].<br></div><div><br></div><div>[1] <a href="https://github.com/phpmyadmin/phpmyadmin/tree/gsoc-js-refactoring" target="_blank">https://github.com/<wbr>phpmyadmin/phpmyadmin/tree/<wbr>gsoc-js-refactoring</a></div><div>[2] <a href="https://github.com/phpmyadmin/phpmyadmin/pull/14464" target="_blank">https://github.com/<wbr>phpmyadmin/phpmyadmin/pull/<wbr>14464</a></div><div><br></div><div>Regards,</div><div>Maurício</div></div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 6, 2018 at 11:01 AM Piyush Vijay <<a href="mailto:piyushvijay.1997@gmail.com" target="_blank">piyushvijay.1997@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><img width="0" height="0" class="m_3318659297496664969m_-7510587812299578347mailtrack-img" alt="" style="display:flex" src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7"><div></div><div></div><div></div><div></div>Hi,<div><br></div><div>Me and Devan were discussing about the current pr 'gsoc' which I have made for the modular javascript code but the pr has lots of unused files which I have created for making sure that existing code is not breaking and contains lot of commented out code.<br><br>So we have decided to create a new branch in main repo of phpMyAdmin and multiple pr's from gsoc branch with small changes which can be reviewed and then merged into the newly created branch and we'll then keep merging this new branch into master after review and testing.</div><div><br></div><div>So I am closing this gsoc pr and will make multiple small pr's from this branch by cherry-picking the commits.<br><br>Any suggestions regarding this would be welcome.</div><div><br></div><div>Regards</div><div>Piyush Vijay</div></div>
</blockquote></div>
</div></div></blockquote></div><br></div>