[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 6dcc3e: Simplify code

[Michal Čihař]

  Branch: refs/heads/master
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: 6dcc3ef6d9fe0d4a6d0661b135ad0d066274650f
      https://github.com/phpmyadmin/phpmyadmin/commit/6dcc3ef6d9fe0d4a6d0661b135ad0d066274650f
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/DisplayResults.class.php

  Log Message:
  -----------
  Simplify code


  Commit: 5106a1bf43557f165062465f546372c083ff290a
      https://github.com/phpmyadmin/phpmyadmin/commit/5106a1bf43557f165062465f546372c083ff290a
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/PDF.class.php

  Log Message:
  -----------
  Pass parameters to parent class


  Commit: 7197609d8d739b0192f6ba55b6355526dda3d62c
      https://github.com/phpmyadmin/phpmyadmin/commit/7197609d8d739b0192f6ba55b6355526dda3d62c
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/PDF.class.php

  Log Message:
  -----------
  Add missing parameter to TCPDF constructor


  Commit: ef3849a439051fd25a94fc08f7f34db9ad47a0df
      https://github.com/phpmyadmin/phpmyadmin/commit/ef3849a439051fd25a94fc08f7f34db9ad47a0df
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/Table.class.php

  Log Message:
  -----------
  This variable never exists here


  Commit: e98f98f6992948b34fcbe8532d2c9a194dbf96b4
      https://github.com/phpmyadmin/phpmyadmin/commit/e98f98f6992948b34fcbe8532d2c9a194dbf96b4
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/Table.class.php

  Log Message:
  -----------
  Fix method call (can not pass params by name)


  Commit: d64ddaad06213626c69216fdefc098148dcab647
      https://github.com/phpmyadmin/phpmyadmin/commit/d64ddaad06213626c69216fdefc098148dcab647
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/Tracker.class.php

  Log Message:
  -----------
  This variable never exists here


  Commit: 6765e87ba59e9cbd052264e899144bcca611d54c
      https://github.com/phpmyadmin/phpmyadmin/commit/6765e87ba59e9cbd052264e899144bcca611d54c
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/create_addfield.lib.php

  Log Message:
  -----------
  Pass forgotten parameter


  Commit: 7e9e568d4d38e06c874225aed4aee46230ddb1ba
      https://github.com/phpmyadmin/phpmyadmin/commit/7e9e568d4d38e06c874225aed4aee46230ddb1ba
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/operations.lib.php

  Log Message:
  -----------
  These need to be global to make this actually work


  Commit: 7fced0d26c134456da35cd58845e4f9ecdefd8ac
      https://github.com/phpmyadmin/phpmyadmin/commit/7fced0d26c134456da35cd58845e4f9ecdefd8ac
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/plugins/auth/AuthenticationSignon.class.php

  Log Message:
  -----------
  Correctly pass usernam in signon auth


  Commit: af2882bd9df84e625943406a94c33dd4a4f79583
      https://github.com/phpmyadmin/phpmyadmin/commit/af2882bd9df84e625943406a94c33dd4a4f79583
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/plugins/export/ExportCsv.class.php

  Log Message:
  -----------
  Drop unused private attributes


  Commit: dc809d6a8d43a17b8655b4114087d53c5dfbd690
      https://github.com/phpmyadmin/phpmyadmin/commit/dc809d6a8d43a17b8655b4114087d53c5dfbd690
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/plugins/import/ImportCsv.class.php
    M libraries/plugins/import/ImportOds.class.php
    M libraries/plugins/import/ImportSql.class.php
    M libraries/plugins/import/README

  Log Message:
  -----------
  Properly use global offset variable


  Commit: e51f32d00103d2bd45fbc7e33ea8434cb7372bb9
      https://github.com/phpmyadmin/phpmyadmin/commit/e51f32d00103d2bd45fbc7e33ea8434cb7372bb9
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/plugins/import/ImportLdi.class.php
    M libraries/plugins/import/ImportOds.class.php
    M libraries/plugins/import/ImportShp.class.php

  Log Message:
  -----------
  Properly set global message


  Commit: 1eda228056cc911fce7aedb77c3c3bb46ae81493
      https://github.com/phpmyadmin/phpmyadmin/commit/1eda228056cc911fce7aedb77c3c3bb46ae81493
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/sqlvalidator.class.php

  Log Message:
  -----------
  Correctly remember URL


  Commit: c0ce163e0585f3fb37c120f5dce21d7b10c383bc
      https://github.com/phpmyadmin/phpmyadmin/commit/c0ce163e0585f3fb37c120f5dce21d7b10c383bc
  Author: Michal Čihař <mcihar at suse.cz>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M libraries/DBQbe.class.php
    M libraries/DisplayResults.class.php
    M libraries/Menu.class.php
    M libraries/TableSearch.class.php
    M libraries/Tracker.class.php
    M libraries/plugin_interface.lib.php
    M libraries/plugins/auth/AuthenticationCookie.class.php
    M libraries/plugins/auth/AuthenticationSignon.class.php
    M libraries/plugins/export/ExportJson.class.php
    M libraries/plugins/import/ImportOds.class.php
    M libraries/plugins/import/ImportXml.class.php
    M libraries/pmd_common.php
    M libraries/replication_gui.lib.php
    M libraries/server_databases.lib.php
    M libraries/sql.lib.php
    M libraries/sqlparser.lib.php
    M libraries/structure.lib.php
    M libraries/sysinfo.lib.php

  Log Message:
  -----------
  Drop some unused local variables

Found by PMD on our CI server


Compare: https://github.com/phpmyadmin/phpmyadmin/compare/185f8188a757...c0ce163e0585