[Phpmyadmin-git] [phpmyadmin/phpmyadmin] a78a75: Make database extension code object oriented

Madhura Jayaratne madhura.cj at gmail.com
Sun May 26 18:24:46 CEST 2013


  Branch: refs/heads/OOP_DBI
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: a78a75754a93961beb9166f2b258f222c36b9a44
      https://github.com/phpmyadmin/phpmyadmin/commit/a78a75754a93961beb9166f2b258f222c36b9a44
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-24 (Fri, 24 May 2013)

  Changed paths:
    M libraries/Error.class.php
    M libraries/database_interface.lib.php
    A libraries/dbi/DBIDrizzle.class.php
    A libraries/dbi/DBIDummy.class.php
    A libraries/dbi/DBIExtension.int.php
    A libraries/dbi/DBIMysql.class.php
    A libraries/dbi/DBIMysqli.class.php
    R libraries/dbi/drizzle.dbi.lib.php
    R libraries/dbi/dummy.lib.php
    R libraries/dbi/mysql.dbi.lib.php
    R libraries/dbi/mysqli.dbi.lib.php
    M test/libraries/database_interface_test.php

  Log Message:
  -----------
  Make database extension code object oriented


  Commit: cf1869905e55314199a47332fa71bcf193350158
      https://github.com/phpmyadmin/phpmyadmin/commit/cf1869905e55314199a47332fa71bcf193350158
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-24 (Fri, 24 May 2013)

  Changed paths:
    M test/classes/navigation/PMA_Node_test.php

  Log Message:
  -----------
  As DBI_Extensions are not classes we can mock them for tests.


  Commit: 650a8cdda3fb03d18e069083ba420894a925ea6c
      https://github.com/phpmyadmin/phpmyadmin/commit/650a8cdda3fb03d18e069083ba420894a925ea6c
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-24 (Fri, 24 May 2013)

  Changed paths:
    M db_create.php
    M db_datadict.php
    M db_operations.php
    M db_printview.php
    M db_tracking.php
    M export.php
    M import.php
    M index.php
    M libraries/Advisor.class.php
    M libraries/DBQbe.class.php
    A libraries/DatabaseInterface.class.php
    M libraries/DbSearch.class.php
    M libraries/DisplayResults.class.php
    M libraries/Index.class.php
    M libraries/List.class.php
    M libraries/List_Database.class.php
    M libraries/Menu.class.php
    M libraries/Partition.class.php
    M libraries/RecentTable.class.php
    M libraries/ServerStatusData.class.php
    M libraries/StorageEngine.class.php
    M libraries/Table.class.php
    M libraries/TableSearch.class.php
    M libraries/Tracker.class.php
    M libraries/Types.class.php
    M libraries/Util.class.php
    M libraries/bookmark.lib.php
    M libraries/build_html_for_db.lib.php
    M libraries/check_user_privileges.lib.php
    M libraries/common.inc.php
    M libraries/core.lib.php
    R libraries/database_interface.lib.php
    M libraries/db_common.inc.php
    M libraries/db_info.inc.php
    M libraries/db_table_exists.lib.php
    M libraries/dbi/DBIDrizzle.class.php
    M libraries/dbi/DBIMysql.class.php
    M libraries/dbi/DBIMysqli.class.php
    M libraries/engines/innodb.lib.php
    M libraries/import.lib.php
    M libraries/insert_edit.lib.php
    M libraries/mult_submits.inc.php
    M libraries/mysql_charsets.lib.php
    M libraries/navigation/NavigationTree.class.php
    M libraries/navigation/Nodes/Node.class.php
    M libraries/navigation/Nodes/Node_Column.class.php
    M libraries/navigation/Nodes/Node_Database.class.php
    M libraries/navigation/Nodes/Node_Event.class.php
    M libraries/navigation/Nodes/Node_Function.class.php
    M libraries/navigation/Nodes/Node_Procedure.class.php
    M libraries/navigation/Nodes/Node_Table.class.php
    M libraries/operations.lib.php
    M libraries/plugins/auth/AuthenticationConfig.class.php
    M libraries/plugins/auth/AuthenticationCookie.class.php
    M libraries/plugins/auth/AuthenticationHttp.class.php
    M libraries/plugins/auth/AuthenticationSignon.class.php
    M libraries/plugins/export/ExportCodegen.class.php
    M libraries/plugins/export/ExportCsv.class.php
    M libraries/plugins/export/ExportHtmlword.class.php
    M libraries/plugins/export/ExportJson.class.php
    M libraries/plugins/export/ExportLatex.class.php
    M libraries/plugins/export/ExportMediawiki.class.php
    M libraries/plugins/export/ExportOds.class.php
    M libraries/plugins/export/ExportOdt.class.php
    M libraries/plugins/export/ExportPhparray.class.php
    M libraries/plugins/export/ExportSql.class.php
    M libraries/plugins/export/ExportTexytext.class.php
    M libraries/plugins/export/ExportXml.class.php
    M libraries/plugins/export/ExportYaml.class.php
    M libraries/plugins/export/PMA_ExportPdf.class.php
    M libraries/plugins/import/ImportCsv.class.php
    M libraries/plugins/import/ImportLdi.class.php
    M libraries/plugins/import/ImportMediawiki.class.php
    M libraries/plugins/import/ImportShp.class.php
    M libraries/plugins/import/ImportSql.class.php
    M libraries/pmd_common.php
    M libraries/relation.lib.php
    M libraries/replication.inc.php
    M libraries/replication_gui.lib.php
    M libraries/rte/rte_events.lib.php
    M libraries/rte/rte_export.lib.php
    M libraries/rte/rte_footer.lib.php
    M libraries/rte/rte_main.inc.php
    M libraries/rte/rte_routines.lib.php
    M libraries/rte/rte_triggers.lib.php
    M libraries/schema/Dia_Relation_Schema.class.php
    M libraries/schema/Eps_Relation_Schema.class.php
    M libraries/schema/Export_Relation_Schema.class.php
    M libraries/schema/Pdf_Relation_Schema.class.php
    M libraries/schema/Svg_Relation_Schema.class.php
    M libraries/schema/User_Schema.class.php
    M libraries/schema/Visio_Relation_Schema.class.php
    M libraries/server_common.inc.php
    M libraries/server_privileges.lib.php
    M libraries/sql.lib.php
    M libraries/sql_query_form.lib.php
    M libraries/structure.lib.php
    M libraries/tbl_columns_definition_form.inc.php
    M libraries/tbl_common.inc.php
    M libraries/tbl_info.inc.php
    M libraries/tbl_views.lib.php
    M libraries/transformations.lib.php
    M libraries/user_preferences.lib.php
    M pmd_pdf.php
    M pmd_relation_new.php
    M pmd_relation_upd.php
    M querywindow.php
    M server_binlog.php
    M server_databases.php
    M server_privileges.php
    M server_replication.php
    M server_status.php
    M server_variables.php
    M sql.php
    M tbl_addfield.php
    M tbl_change.php
    M tbl_create.php
    M tbl_indexes.php
    M tbl_move_copy.php
    M tbl_operations.php
    M tbl_printview.php
    M tbl_relation.php
    M tbl_replace.php
    M tbl_structure.php
    M tbl_tracking.php
    M test/classes/PMA_DBQbe_test.php
    M test/classes/PMA_DbSearch_test.php
    M test/classes/PMA_Header_test.php
    M test/classes/PMA_Menu_test.php
    M test/classes/PMA_StorageEngine_test.php
    M test/classes/PMA_Table_test.php
    M test/classes/PMA_Types_Drizzle_test.php
    M test/classes/navigation/PMA_Node_test.php
    M test/engines/PMA_StorageEngine_bdb_test.php
    M test/engines/PMA_StorageEngine_binlog_test.php
    M test/engines/PMA_StorageEngine_innodb_test.php
    M test/engines/PMA_StorageEngine_memory_test.php
    M test/engines/PMA_StorageEngine_mrg_myisam_test.php
    M test/engines/PMA_StorageEngine_myisam_test.php
    M test/engines/PMA_StorageEngine_ndbcluster_test.php
    M test/engines/PMA_StorageEngine_pbxt_test.php
    M test/libraries/PMA_bookmark_test.php
    M test/libraries/PMA_build_html_for_db_test.php
    M test/libraries/PMA_operations_test.php
    M test/libraries/PMA_transformation_test.php
    M test/libraries/core/PMA_getTableCount_test_dis.php
    M test/libraries/database_interface_test.php
    M test/libraries/rte/PMA_RTN_getEditorForm_test.php
    M test/libraries/rte/PMA_RTN_getExecuteForm_test.php
    M test/libraries/rte/PMA_TRI_getEditorForm_test.php
    M test/libraries/rte/PMA_TRI_getQueryFromRequest_test.php
    M transformation_wrapper.php
    M user_password.php
    M view_create.php

  Log Message:
  -----------
  Convert database interface to a class


  Commit: 098048627d8a0824570c05c31baa37ea2a91f282
      https://github.com/phpmyadmin/phpmyadmin/commit/098048627d8a0824570c05c31baa37ea2a91f282
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-24 (Fri, 24 May 2013)

  Changed paths:
    M test/classes/navigation/PMA_Node_test.php

  Log Message:
  -----------
  Fix tests by using mock objects of DatabaseInterface


  Commit: ce85ebd9503cea999de5544fb391aa76e42c83c7
      https://github.com/phpmyadmin/phpmyadmin/commit/ce85ebd9503cea999de5544fb391aa76e42c83c7
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-24 (Fri, 24 May 2013)

  Changed paths:
    M ChangeLog
    M js/functions.js
    M js/server_status_monitor.js
    M js/sql.js
    M libraries/Advisor.class.php
    M libraries/Types.class.php
    M libraries/config/FormDisplay.class.php
    M libraries/config/FormDisplay.tpl.php
    M libraries/sql.lib.php
    M libraries/sqlparser.data.php
    M po/af.po
    M po/ar.po
    M po/az.po
    M po/be.po
    M po/be at latin.po
    M po/bg.po
    M po/bn.po
    M po/br.po
    M po/bs.po
    M po/ca.po
    M po/ckb.po
    M po/cs.po
    M po/cy.po
    M po/da.po
    M po/de.po
    M po/el.po
    M po/en_GB.po
    M po/es.po
    M po/et.po
    M po/eu.po
    M po/fa.po
    M po/fi.po
    M po/fr.po
    M po/gl.po
    M po/he.po
    M po/hi.po
    M po/hr.po
    M po/hu.po
    M po/hy.po
    M po/ia.po
    M po/id.po
    M po/it.po
    M po/ja.po
    M po/ka.po
    M po/kk.po
    M po/ko.po
    M po/lt.po
    M po/lv.po
    M po/mk.po
    M po/ml.po
    M po/mn.po
    M po/ms.po
    M po/nb.po
    M po/nl.po
    M po/pa.po
    M po/phpmyadmin.pot
    M po/pl.po
    M po/pt.po
    M po/pt_BR.po
    M po/ro.po
    M po/ru.po
    M po/si.po
    M po/sk.po
    M po/sl.po
    M po/sq.po
    M po/sr.po
    M po/sr at latin.po
    M po/sv.po
    M po/ta.po
    M po/te.po
    M po/th.po
    M po/tk.po
    M po/tr.po
    M po/tt.po
    M po/ug.po
    M po/uk.po
    M po/ur.po
    M po/uz.po
    M po/uz at latin.po
    M po/zh_CN.po
    M po/zh_TW.po
    M server_replication.php
    M server_status_monitor.php
    M sql.php
    M test/classes/PMA_Index_test.php
    M test/classes/PMA_Types_MySQL_test.php
    M themes/original/css/common.css.php
    M themes/pmahomme/css/common.css.php

  Log Message:
  -----------
  Merge branch 'master' into OOP_DBI


  Commit: 01cdc5cbf7d58edc167063b9aef866b66fe30625
      https://github.com/phpmyadmin/phpmyadmin/commit/01cdc5cbf7d58edc167063b9aef866b66fe30625
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-24 (Fri, 24 May 2013)

  Changed paths:
    M index.php
    M libraries/DbSearch.class.php
    M libraries/Error.class.php
    M libraries/Table.class.php
    M libraries/dbi/DBIDummy.class.php
    M libraries/replication.inc.php

  Log Message:
  -----------
  Few renamings that got missed


  Commit: 46e5f39e611d355931bf011d5e3659b1d074e60b
      https://github.com/phpmyadmin/phpmyadmin/commit/46e5f39e611d355931bf011d5e3659b1d074e60b
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-24 (Fri, 24 May 2013)

  Changed paths:
    M test/classes/navigation/PMA_Node_test.php

  Log Message:
  -----------
  Set MaxNavigationItems value irrespective of it being set earlier


  Commit: 3a89c9938aa5291538376bb8b617b45fd0251301
      https://github.com/phpmyadmin/phpmyadmin/commit/3a89c9938aa5291538376bb8b617b45fd0251301
  Author: Marc Delisle <marc at infomarc.info>
  Date:   2013-05-25 (Sat, 25 May 2013)

  Changed paths:
    M server_status_monitor.php

  Log Message:
  -----------
  Missing renamings


  Commit: 8b8d1f88f0a69b2eb3f2ec0423ccda4ecc1b07a8
      https://github.com/phpmyadmin/phpmyadmin/commit/8b8d1f88f0a69b2eb3f2ec0423ccda4ecc1b07a8
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-25 (Sat, 25 May 2013)

  Changed paths:
    M server_status_monitor.php

  Log Message:
  -----------
  Merge pull request #1 from lem9/OOP_DBI

Missing renamings


  Commit: 5c9941ab6a5a4abf2a2425377fa77a95c85b8308
      https://github.com/phpmyadmin/phpmyadmin/commit/5c9941ab6a5a4abf2a2425377fa77a95c85b8308
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-25 (Sat, 25 May 2013)

  Changed paths:
    M schema_export.php
    M server_plugins.php
    M server_status_variables.php
    M tbl_chart.php
    M tbl_get_field.php
    M tbl_gis_visualization.php
    M tbl_zoom_select.php

  Log Message:
  -----------
  Some more missing renamings


  Commit: 50b0eed668586ddad896bd92a028f6da7d481c45
      https://github.com/phpmyadmin/phpmyadmin/commit/50b0eed668586ddad896bd92a028f6da7d481c45
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-25 (Sat, 25 May 2013)

  Changed paths:
    M libraries/common.inc.php
    M server_status_monitor.php

  Log Message:
  -----------
  isSuperuser() is also a part of DatabaseInterface class


  Commit: 4e09cb513ba9ac4a7a5c274419bb923ed0f00887
      https://github.com/phpmyadmin/phpmyadmin/commit/4e09cb513ba9ac4a7a5c274419bb923ed0f00887
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-26 (Sun, 26 May 2013)

  Changed paths:
    M libraries/DatabaseInterface.class.php

  Log Message:
  -----------
  Make related functions and integral part of DatabaseInterface class


  Commit: 3dd99512f05d2563bd107197bbb3ed0be6e9e6d1
      https://github.com/phpmyadmin/phpmyadmin/commit/3dd99512f05d2563bd107197bbb3ed0be6e9e6d1
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-26 (Sun, 26 May 2013)

  Changed paths:
    M db_operations.php
    M libraries/DBQbe.class.php
    M libraries/DatabaseInterface.class.php
    M libraries/DisplayResults.class.php
    M libraries/Menu.class.php
    M libraries/Table.class.php
    M libraries/Util.class.php
    M libraries/bookmark.lib.php
    M libraries/core.lib.php
    M libraries/db_info.inc.php
    M libraries/db_table_exists.lib.php
    M libraries/dbi/DBIDrizzle.class.php
    M libraries/dbi/DBIMysql.class.php
    M libraries/dbi/DBIMysqli.class.php
    M libraries/insert_edit.lib.php
    M libraries/plugins/export/ExportCsv.class.php
    M libraries/plugins/export/ExportHtmlword.class.php
    M libraries/plugins/export/ExportJson.class.php
    M libraries/plugins/export/ExportLatex.class.php
    M libraries/plugins/export/ExportMediawiki.class.php
    M libraries/plugins/export/ExportOds.class.php
    M libraries/plugins/export/ExportOdt.class.php
    M libraries/plugins/export/ExportPhparray.class.php
    M libraries/plugins/export/ExportSql.class.php
    M libraries/plugins/export/ExportTexytext.class.php
    M libraries/plugins/export/ExportXml.class.php
    M libraries/plugins/export/ExportYaml.class.php
    M libraries/plugins/export/PMA_ExportPdf.class.php
    M libraries/pmd_common.php
    M libraries/relation.lib.php
    M libraries/schema/Dia_Relation_Schema.class.php
    M libraries/schema/Eps_Relation_Schema.class.php
    M libraries/schema/Export_Relation_Schema.class.php
    M libraries/schema/Pdf_Relation_Schema.class.php
    M libraries/schema/Svg_Relation_Schema.class.php
    M libraries/schema/User_Schema.class.php
    M libraries/schema/Visio_Relation_Schema.class.php
    M libraries/server_common.inc.php
    M libraries/server_privileges.lib.php
    M libraries/sql.lib.php
    M libraries/transformations.lib.php
    M pmd_pdf.php
    M pmd_relation_new.php
    M pmd_relation_upd.php
    M pmd_save_pos.php
    M sql.php
    M tbl_relation.php
    M tbl_zoom_select.php
    M transformation_wrapper.php

  Log Message:
  -----------
  These constants are better as a part of DatabaseInterface class


  Commit: 1ddad55fb5e04e5f8da9f6429d1feb4d43fe9897
      https://github.com/phpmyadmin/phpmyadmin/commit/1ddad55fb5e04e5f8da9f6429d1feb4d43fe9897
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-26 (Sun, 26 May 2013)

  Changed paths:
    M libraries/DatabaseInterface.class.php

  Log Message:
  -----------
  Fix indentation


  Commit: 0dab7f2463ada776ce9b1a8671fa30573777809c
      https://github.com/phpmyadmin/phpmyadmin/commit/0dab7f2463ada776ce9b1a8671fa30573777809c
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-26 (Sun, 26 May 2013)

  Changed paths:
    M libraries/DatabaseInterface.class.php
    M libraries/common.inc.php
    A libraries/database_interface.inc.php
    M test/classes/PMA_DBQbe_test.php
    M test/classes/PMA_DbSearch_test.php
    M test/classes/PMA_Header_test.php
    M test/classes/PMA_Menu_test.php
    M test/classes/PMA_StorageEngine_test.php
    M test/classes/PMA_Table_test.php
    M test/classes/PMA_Types_Drizzle_test.php
    M test/classes/navigation/PMA_Node_test.php
    M test/engines/PMA_StorageEngine_bdb_test.php
    M test/engines/PMA_StorageEngine_binlog_test.php
    M test/engines/PMA_StorageEngine_innodb_test.php
    M test/engines/PMA_StorageEngine_memory_test.php
    M test/engines/PMA_StorageEngine_mrg_myisam_test.php
    M test/engines/PMA_StorageEngine_myisam_test.php
    M test/engines/PMA_StorageEngine_ndbcluster_test.php
    M test/engines/PMA_StorageEngine_pbxt_test.php
    M test/libraries/PMA_bookmark_test.php
    M test/libraries/PMA_build_html_for_db_test.php
    M test/libraries/PMA_operations_test.php
    M test/libraries/PMA_transformation_test.php
    M test/libraries/core/PMA_getTableCount_test_dis.php
    M test/libraries/database_interface_test.php
    M test/libraries/rte/PMA_RTN_getEditorForm_test.php
    M test/libraries/rte/PMA_RTN_getExecuteForm_test.php
    M test/libraries/rte/PMA_TRI_getEditorForm_test.php
    M test/libraries/rte/PMA_TRI_getQueryFromRequest_test.php

  Log Message:
  -----------
  Separate DatabaseInterface class and creation of an instance of it


  Commit: 2baf473ad70b1358fca776ed05c3efbc7e99696e
      https://github.com/phpmyadmin/phpmyadmin/commit/2baf473ad70b1358fca776ed05c3efbc7e99696e
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-26 (Sun, 26 May 2013)

  Changed paths:
    M ChangeLog
    M js/ajax.js
    A js/codemirror/addon/runmode/runmode.js
    M js/functions.js
    M js/indexes.js
    M js/server_privileges.js
    M js/sql.js
    M js/tbl_select.js
    M js/tbl_structure.js
    M libraries/Config.class.php
    M libraries/Header.class.php
    M libraries/Table.class.php
    M libraries/Util.class.php
    M libraries/common.inc.php
    M libraries/config.default.php
    M libraries/plugins/transformations/abstract/SQLTransformationsPlugin.class.php
    M libraries/rte/rte_routines.lib.php
    M libraries/sql.lib.php
    M libraries/sqlparser.lib.php
    M po/af.po
    M po/ar.po
    M po/az.po
    M po/be.po
    M po/be at latin.po
    M po/bg.po
    M po/bn.po
    M po/br.po
    M po/bs.po
    M po/ca.po
    M po/ckb.po
    M po/cs.po
    M po/cy.po
    M po/da.po
    M po/de.po
    M po/el.po
    M po/en_GB.po
    M po/es.po
    M po/et.po
    M po/eu.po
    M po/fa.po
    M po/fi.po
    M po/fr.po
    M po/gl.po
    M po/he.po
    M po/hi.po
    M po/hr.po
    M po/hu.po
    M po/hy.po
    M po/ia.po
    M po/id.po
    M po/it.po
    M po/ja.po
    M po/ka.po
    M po/kk.po
    M po/ko.po
    M po/lt.po
    M po/lv.po
    M po/mk.po
    M po/ml.po
    M po/mn.po
    M po/ms.po
    M po/nb.po
    M po/nl.po
    M po/pa.po
    M po/phpmyadmin.pot
    M po/pl.po
    M po/pt.po
    M po/pt_BR.po
    M po/ro.po
    M po/ru.po
    M po/si.po
    M po/sk.po
    M po/sl.po
    M po/sq.po
    M po/sr.po
    M po/sr at latin.po
    M po/sv.po
    M po/ta.po
    M po/te.po
    M po/th.po
    M po/tk.po
    M po/tr.po
    M po/tt.po
    M po/ug.po
    M po/uk.po
    M po/ur.po
    M po/uz.po
    M po/uz at latin.po
    M po/zh_CN.po
    M po/zh_TW.po
    M server_status.php
    M server_status_monitor.php
    M sql.php
    M tbl_export.php

  Log Message:
  -----------
  Merge branch 'master' into OOP_DBI

Conflicts:
	libraries/database_interface.lib.php


  Commit: 8eb8c995d4a22ca2cd8381c4fdf5bf74a9b4f88b
      https://github.com/phpmyadmin/phpmyadmin/commit/8eb8c995d4a22ca2cd8381c4fdf5bf74a9b4f88b
  Author: Madhura Jayaratne <madhura.cj at gmail.com>
  Date:   2013-05-26 (Sun, 26 May 2013)

  Changed paths:
    M libraries/DatabaseInterface.class.php

  Log Message:
  -----------
  Couple of renamings that got missed


Compare: https://github.com/phpmyadmin/phpmyadmin/compare/a78a75754a93^...8eb8c995d4a2


More information about the Git mailing list