[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 98034b: Remove $GLOBALS['cfg']['Bookmark'] variable

Michal Čihař michal at cihar.com
Thu Jun 12 13:46:11 CEST 2014


  Branch: refs/heads/master
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: 98034ba148b0d9fe2abcb7519c5fbc695a19c594
      https://github.com/phpmyadmin/phpmyadmin/commit/98034ba148b0d9fe2abcb7519c5fbc695a19c594
  Author: Michal Čihař <michal at cihar.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M import.php
    M libraries/bookmark.lib.php
    M libraries/sql.lib.php
    M libraries/sql_query_form.lib.php

  Log Message:
  -----------
  Remove $GLOBALS['cfg']['Bookmark'] variable

It makes it impossible to include bookmark library at any time as when
it is included before configuration is loaded it caches false result for
bookmarks support.

And anyway, using superglobals is always bad idea.

Signed-off-by: Michal Čihař <michal at cihar.com>




More information about the Git mailing list