[phpMyAdmin Git] [phpmyadmin/phpmyadmin] f3ca36: Fix number formatting with different settings of p...

Michal Čihař michal at cihar.com
Tue Aug 30 15:53:27 CEST 2016


  Branch: refs/heads/QA_4_6
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: f3ca367efa5a44161ca6fa3a2a9fa3b9ed24cbb1
      https://github.com/phpmyadmin/phpmyadmin/commit/f3ca367efa5a44161ca6fa3a2a9fa3b9ed24cbb1
  Author: Michal Čihař <michal at cihar.com>
  Date:   2016-08-30 (Tue, 30 Aug 2016)

  Changed paths:
    M ChangeLog
    M libraries/Util.php
    M libraries/common.inc.php
    M test/bootstrap-dist.php
    M test/libraries/common/PMA_formatNumberByteDown_test.php

  Log Message:
  -----------
  Fix number formatting with different settings of precision in PHP

- fixed Util::formatNumber to avoid rounding issues to mess up display
- force precision = 14 to ensure we get sane behavior

With precision set to higher value many things do not behave as expected
producing strange numbers in various places.

For example with precision=19 you get:

php > echo round(1.2, 2);
1.199999999999999956

Fixes #12303

Signed-off-by: Michal Čihař <michal at cihar.com>




More information about the Git mailing list