[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 73499a: Do not delete session on fatal error

Michal Čihař michal at cihar.com
Mon Dec 19 15:28:33 CET 2016


  Branch: refs/heads/master
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: 73499a5e56a5d9fe1f0fa752dd38feee89b1ee65
      https://github.com/phpmyadmin/phpmyadmin/commit/73499a5e56a5d9fe1f0fa752dd38feee89b1ee65
  Author: Michal Čihař <michal at cihar.com>
  Date:   2016-12-13 (Tue, 13 Dec 2016)

  Changed paths:
    M libraries/Util.php
    M libraries/core.lib.php

  Log Message:
  -----------
  Do not delete session on fatal error

I see no reason why this should be done, the fatal error is used
in following cases:

* Very early when there is no session (eg. missing extension)
* Invalid value for parameters
* Invalid invocation like too big request

In neither case session removal will do any good.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 2557709949398c560455b53816f29ea5890c52aa
      https://github.com/phpmyadmin/phpmyadmin/commit/2557709949398c560455b53816f29ea5890c52aa
  Author: Michal Čihař <michal at cihar.com>
  Date:   2016-12-19 (Mon, 19 Dec 2016)

  Changed paths:
    M libraries/Util.php
    M libraries/core.lib.php

  Log Message:
  -----------
  Merge pull request #12807 from nijel/cookie-fatal

Do not delete session on fatal error


  Commit: 3a7eaf8538773378bf13c4599d681d80c1f41764
      https://github.com/phpmyadmin/phpmyadmin/commit/3a7eaf8538773378bf13c4599d681d80c1f41764
  Author: Michal Čihař <michal at cihar.com>
  Date:   2016-12-19 (Mon, 19 Dec 2016)

  Changed paths:
    M libraries/Util.php
    M libraries/core.lib.php

  Log Message:
  -----------
  Merge branch 'QA_4_6'


Compare: https://github.com/phpmyadmin/phpmyadmin/compare/945e615253a8...3a7eaf853877


More information about the Git mailing list