[phpMyAdmin Git] [phpmyadmin/phpmyadmin] bee280: Remove auxiliary_connection flag from DBI backends

[Michal Čihař]

  Branch: refs/heads/master
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: bee2805b34f5d61a3e535478a62001db2524733e
      https://github.com/phpmyadmin/phpmyadmin/commit/bee2805b34f5d61a3e535478a62001db2524733e
  Author: Michal Čihař <michal at cihar.com>
  Date:   2016-07-29 (Fri, 29 Jul 2016)

  Changed paths:
    M libraries/DatabaseInterface.php
    M libraries/dbi/DBIDummy.php
    M libraries/dbi/DBIExtension.php
    M libraries/dbi/DBIMysql.php
    M libraries/dbi/DBIMysqli.php

  Log Message:
  -----------
  Remove auxiliary_connection flag from DBI backends

They do not use it anyway.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 53f541af86dc0f020e36c43b4446943efc0cc675
      https://github.com/phpmyadmin/phpmyadmin/commit/53f541af86dc0f020e36c43b4446943efc0cc675
  Author: Michal Čihař <michal at cihar.com>
  Date:   2016-07-29 (Fri, 29 Jul 2016)

  Changed paths:
    M ChangeLog
    M libraries/dbi/DBIMysql.php
    M libraries/dbi/DBIMysqli.php

  Log Message:
  -----------
  Removed MySQL connection retry without password

This really does not make sense for any decent setup. It is useful only
with http authentication, but still no password is not something we
would want to automatically fall back to.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: f46fd340812fc05e1c9358ca8e8d42932ab7c8f6
      https://github.com/phpmyadmin/phpmyadmin/commit/f46fd340812fc05e1c9358ca8e8d42932ab7c8f6
  Author: Michal Čihař <michal at cihar.com>
  Date:   2016-07-29 (Fri, 29 Jul 2016)

  Changed paths:
    M libraries/DatabaseInterface.php
    M libraries/dbi/DBIDummy.php
    M libraries/dbi/DBIExtension.php
    M libraries/dbi/DBIMysql.php
    M libraries/dbi/DBIMysqli.php
    M test/classes/dbi/DBIMysqlTest.php
    M test/classes/dbi/DBIMysqliTest.php

  Log Message:
  -----------
  Remove is_controluser flag from DBI backends

They no longer need it (it was used only for empty password fallback).

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: f30f65c67a1f0a61da39f14c8d465bef7ea7d0d4
      https://github.com/phpmyadmin/phpmyadmin/commit/f30f65c67a1f0a61da39f14c8d465bef7ea7d0d4
  Author: Michal Čihař <michal at cihar.com>
  Date:   2016-07-29 (Fri, 29 Jul 2016)

  Changed paths:
    M libraries/DatabaseInterface.php
    M libraries/common.inc.php
    M libraries/replication.inc.php

  Log Message:
  -----------
  Indentify connection type by one flag

Use integer values rather than set of boolean flags. This makes it
easier to make decision and makes the code more readable. Also removes
confusion what should happen in case both boolean flags are set.

Signed-off-by: Michal Čihař <michal at cihar.com>


Compare: https://github.com/phpmyadmin/phpmyadmin/compare/9588dbd4aaf7...f30f65c67a1f