[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 51fb18: Move Theme object out of session

[Michal Čihař]

  Branch: refs/heads/master
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: 51fb18612aec88a62f95006fd1906b55b17b91d2
      https://github.com/phpmyadmin/phpmyadmin/commit/51fb18612aec88a62f95006fd1906b55b17b91d2
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-07-17 (Mon, 17 Jul 2017)

  Changed paths:
    M js/get_image.js.php
    M js/messages.php
    M libraries/classes/Config.php
    M libraries/classes/Header.php
    M libraries/classes/ThemeManager.php
    M libraries/classes/Util.php
    M templates/database/designer/database_tables.phtml
    M templates/database/designer/side_menu.phtml
    M templates/database/designer/table_list.phtml
    M test/bootstrap-dist.php
    M test/classes/ConfigTest.php
    M test/classes/HeaderTest.php
    M test/classes/MenuTest.php
    M test/classes/ThemeTest.php
    M test/classes/config/FormDisplayTest.php
    M test/classes/config/FormTest.php
    M test/classes/navigation/NodeDatabaseChildTest.php
    M test/libraries/PMA_relation_test.php
    M test/libraries/common/PMA_checkParameters_test.php
    M test/libraries/rte/PMA_RTN_getEditorForm_test.php

  Log Message:
  -----------
  Move Theme object out of session

Honestly I don't see good reason for storing Theme in session as loading
it from the session will take about same time as loading it from the
disk.

Additionally it seems that current code really didn't really use the
object stored in session, it was constructed with every request anyway
(by ThemeManager::initializeTheme).

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 942e44afe70f5fb5984b577b994a2959f17734fa
      https://github.com/phpmyadmin/phpmyadmin/commit/942e44afe70f5fb5984b577b994a2959f17734fa
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-07-18 (Tue, 18 Jul 2017)

  Changed paths:
    M js/get_image.js.php
    M js/messages.php
    M libraries/classes/Config.php
    M libraries/classes/Header.php
    M libraries/classes/ThemeManager.php
    M libraries/classes/Util.php
    M templates/database/designer/database_tables.phtml
    M templates/database/designer/side_menu.phtml
    M templates/database/designer/table_list.phtml
    M test/bootstrap-dist.php
    M test/classes/ConfigTest.php
    M test/classes/HeaderTest.php
    M test/classes/MenuTest.php
    M test/classes/ThemeTest.php
    M test/classes/config/FormDisplayTest.php
    M test/classes/config/FormTest.php
    M test/classes/navigation/NodeDatabaseChildTest.php
    M test/libraries/PMA_relation_test.php
    M test/libraries/common/PMA_checkParameters_test.php
    M test/libraries/rte/PMA_RTN_getEditorForm_test.php

  Log Message:
  -----------
  Merge pull request #13499 from nijel/theme

Move Theme object out of session


Compare: https://github.com/phpmyadmin/phpmyadmin/compare/964f3d896356...942e44afe70f