[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 3b9fb2: Simplify handling of long URLs in Util::linkOrButt...

Michal Čihař michal at cihar.com
Thu Nov 16 18:52:12 CET 2017


  Branch: refs/heads/master
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: 3b9fb2b664632557866feb083b59743ed60d1e22
      https://github.com/phpmyadmin/phpmyadmin/commit/3b9fb2b664632557866feb083b59743ed60d1e22
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M js/ajax.js
    M js/functions.js
    M js/gis_data_editor.js
    M js/sql.js
    M libraries/classes/Util.php
    M libraries/common.inc.php

  Log Message:
  -----------
  Simplify handling of long URLs in Util::linkOrButton

We no longer create form, but rather rather tag the link to be handled
as POST on the client side.

This way the code is way simpler without need on any special case
handling on server side.

Fixes #13649

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 816c42665af83d8f2652c6c0e9c0d92c63526ae6
      https://github.com/phpmyadmin/phpmyadmin/commit/816c42665af83d8f2652c6c0e9c0d92c63526ae6
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M test/classes/UtilTest.php

  Log Message:
  -----------
  Add tests for Util::linkOrButton

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 50c65bc3fb9aec08b7a24e6482f885e817b5ad2d
      https://github.com/phpmyadmin/phpmyadmin/commit/50c65bc3fb9aec08b7a24e6482f885e817b5ad2d
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M libraries/classes/Display/Results.php
    M libraries/classes/InsertEdit.php
    M libraries/classes/Util.php
    M templates/table/search/input_box.twig
    M test/classes/UtilTest.php

  Log Message:
  -----------
  Remove no longer needed $new_form from Util::linkOrButton

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 1a0bb3ebd54896383aa9de7bf5a2ca62001d249c
      https://github.com/phpmyadmin/phpmyadmin/commit/1a0bb3ebd54896383aa9de7bf5a2ca62001d249c
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M libraries/classes/Util.php

  Log Message:
  -----------
  Avoid using mb_* function for URL length calculation

It is handled in bytes on the webserver side, so use limits in bytes not
in chars as mb_strlen does.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 657ee671fc8532e5c6577474ec3856976eaab8c9
      https://github.com/phpmyadmin/phpmyadmin/commit/657ee671fc8532e5c6577474ec3856976eaab8c9
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M libraries/classes/Util.php

  Log Message:
  -----------
  Avoid double html encoding of link target

This is done when printing the attributes as well.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 99e9854473155a5337fc9361d9eba4bae3d30792
      https://github.com/phpmyadmin/phpmyadmin/commit/99e9854473155a5337fc9361d9eba4bae3d30792
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M libraries/classes/Util.php
    M test/classes/Display/ResultsTest.php

  Log Message:
  -----------
  Always use POST for links containing SQL query

This way the SQL queries will not apper in the web server logs.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 9c087ccffcd6dc2324a63036d19dce2efbafa0fc
      https://github.com/phpmyadmin/phpmyadmin/commit/9c087ccffcd6dc2324a63036d19dce2efbafa0fc
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M libraries/classes/Util.php

  Log Message:
  -----------
  Document when POST is used in Util::linkOrButton

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 486ab532f3f9621dc8fd8b656721e00e57e33a74
      https://github.com/phpmyadmin/phpmyadmin/commit/486ab532f3f9621dc8fd8b656721e00e57e33a74
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M libraries/classes/Util.php

  Log Message:
  -----------
  Remove magic to add message in Util::linkOrButton

The passed parameter should be already valid, we should avoid expensive
processing of the data such as calling strip_tags on every text
containing <img.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 3cd104a45411326c01b968c8acbfc6e98300cead
      https://github.com/phpmyadmin/phpmyadmin/commit/3cd104a45411326c01b968c8acbfc6e98300cead
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M libraries/classes/Util.php

  Log Message:
  -----------
  Remove not needed $force_button paratemet from Util::linkOrButton

It was used to force POST for few links with the SQL, but that
is now done automatically.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: ad72aaecc22ab6e816431a4dda88520a3d5512b1
      https://github.com/phpmyadmin/phpmyadmin/commit/ad72aaecc22ab6e816431a4dda88520a3d5512b1
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M libraries/classes/Display/Results.php
    M libraries/classes/Util.php

  Log Message:
  -----------
  Avoid passing default params to Util::linkOrButton

Do not pass optional parameters with default values.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: f29640c5d8f155e520b4ff30a769d5bf8c2d1ff1
      https://github.com/phpmyadmin/phpmyadmin/commit/f29640c5d8f155e520b4ff30a769d5bf8c2d1ff1
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M libraries/classes/Display/Results.php
    M libraries/classes/InsertEdit.php
    M libraries/classes/Util.php
    M templates/table/search/input_box.twig
    M test/classes/UtilTest.php

  Log Message:
  -----------
  Remove $strip_img parameter from Util::linkOrButton

It did not behave as documented for ages, it only influenced
whether additional text was added to the link.

Callers should use parameters to Util::getIcon to achieve this
(if it is actually needed somewhere)

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 152c4857c2e1c6d259126bb1ff8642120cc665fe
      https://github.com/phpmyadmin/phpmyadmin/commit/152c4857c2e1c6d259126bb1ff8642120cc665fe
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M js/ajax.js
    M js/functions.js
    M js/gis_data_editor.js
    M js/sql.js
    M libraries/classes/Display/Results.php
    M libraries/classes/InsertEdit.php
    M libraries/classes/Util.php
    M libraries/common.inc.php
    M templates/table/search/input_box.twig
    M test/classes/Display/ResultsTest.php
    M test/classes/UtilTest.php

  Log Message:
  -----------
  Merge pull request #13817 from nijel/link-or-button

Simplify handling of long URLs in Util::linkOrButton


Compare: https://github.com/phpmyadmin/phpmyadmin/compare/4669a589c6b8...152c4857c2e1


More information about the Git mailing list