[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 8fbe46: Remove usage of get_scripts.js.php wrapper

Michal Čihař michal at cihar.com
Wed Nov 29 17:05:50 CET 2017


  Branch: refs/heads/master
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: 8fbe46f3e810c361858d6c3b6e2ccbb9ff969ff5
      https://github.com/phpmyadmin/phpmyadmin/commit/8fbe46f3e810c361858d6c3b6e2ccbb9ff969ff5
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M js/ajax.js
    R js/get_scripts.js.php
    M libraries/classes/Scripts.php
    M test/classes/ScriptsTest.php
    M test/libraries/Files_test.php

  Log Message:
  -----------
  Remove usage of get_scripts.js.php wrapper

- this adds significant overhead in sending static files from the server
- the benefit of joining requests is minimal since introduction of HTTP/2
- the onload handlers are now fired directly by individual scripts, what
  makes them really execute when the script is loaded (it could be
  previously executed earlier in case of chunked loading)

Fixes #13840

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 8ef504da912d95e683217228f589bd6d90500384
      https://github.com/phpmyadmin/phpmyadmin/commit/8ef504da912d95e683217228f589bd6d90500384
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M .gitignore
    M doc/faq.rst
    M libraries/classes/ErrorReport.php
    R scripts/line-counts.sh

  Log Message:
  -----------
  Remove line counts logic from the error reporting component

We no longer need this as we download js files directly, so the client
has correct filename and line immediatelly.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 77f0d50bea5ee461920fb92cff832f252e9fdc8a
      https://github.com/phpmyadmin/phpmyadmin/commit/77f0d50bea5ee461920fb92cff832f252e9fdc8a
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M libraries/classes/Controllers/Database/DatabaseStructureController.php
    M libraries/classes/Controllers/Table/TableSearchController.php
    M libraries/classes/InsertEdit.php
    M tbl_replace.php
    M test/classes/InsertEditTest.php

  Log Message:
  -----------
  Add missing dependency on jquery.validate.js

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 5346416625f3196238c55c9e9c2d3d0fef25887d
      https://github.com/phpmyadmin/phpmyadmin/commit/5346416625f3196238c55c9e9c2d3d0fef25887d
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M libraries/classes/Header.php
    M libraries/classes/Scripts.php
    M test/classes/ScriptsTest.php

  Log Message:
  -----------
  Simplify Scripts::addFile API

Removed unused parameter to define ordering of scripts.

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 7ec4059dbb3349969d911646234c638da7791a4e
      https://github.com/phpmyadmin/phpmyadmin/commit/7ec4059dbb3349969d911646234c638da7791a4e
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M .gitignore
    M doc/faq.rst
    M js/ajax.js
    R js/get_scripts.js.php
    M libraries/classes/Controllers/Database/DatabaseStructureController.php
    M libraries/classes/Controllers/Table/TableSearchController.php
    M libraries/classes/ErrorReport.php
    M libraries/classes/Header.php
    M libraries/classes/InsertEdit.php
    M libraries/classes/Scripts.php
    R scripts/line-counts.sh
    M tbl_replace.php
    M test/classes/InsertEditTest.php
    M test/classes/ScriptsTest.php
    M test/libraries/Files_test.php

  Log Message:
  -----------
  Merge pull request #13839 from nijel/scripts

Remove get_scripts wrapper to download javascript


Compare: https://github.com/phpmyadmin/phpmyadmin/compare/bb60b9d53bd6...7ec4059dbb33


More information about the Git mailing list