[phpMyAdmin Git] [phpmyadmin/phpmyadmin] dc6d06: Avoid defining error messages centrally in server ...

[Michal Čihař]

  Branch: refs/heads/master
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: dc6d06f5cabd28d8cef9f326f22c659cb6daa253
      https://github.com/phpmyadmin/phpmyadmin/commit/dc6d06f5cabd28d8cef9f326f22c659cb6daa253
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-09-05 (Tue, 05 Sep 2017)

  Changed paths:
    M libraries/classes/Config/ServerConfigChecks.php

  Log Message:
  -----------
  Avoid defining error messages centrally in server config check

- better load them only when needed
- avoid using PMA_lang which really serves different purpose

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 0b81218a101fc0f4d91a2de33bd5bd0b1e28813d
      https://github.com/phpmyadmin/phpmyadmin/commit/0b81218a101fc0f4d91a2de33bd5bd0b1e28813d
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-09-05 (Tue, 05 Sep 2017)

  Changed paths:
    A libraries/classes/Config/Descriptions.php
    M libraries/classes/Config/FormDisplay.php
    M libraries/classes/Config/PageSettings.php
    M libraries/classes/Config/ServerConfigChecks.php
    M libraries/classes/Controllers/Database/DatabaseStructureController.php
    M libraries/classes/Controllers/Table/TableStructureController.php
    M libraries/common.inc.php
    R libraries/config/config_functions.lib.php
    R libraries/config/messages.inc.php
    M libraries/user_preferences.inc.php
    M prefs_forms.php
    M prefs_manage.php
    M setup/frames/form.inc.php
    M setup/lib/common.inc.php
    M tbl_structure.php
    A test/classes/config/DescriptionTest.php
    M test/classes/config/FormDisplayTest.php
    M test/libraries/PMA_SetupIndex_test.php
    R test/libraries/PMA_config_functions_test.php
    R test/libraries/config/PMA_messages_inc_test.php

  Log Message:
  -----------
  Refactor configuration descriptions into class

This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 89fc55086201501291d2f8692a97389097159d6a
      https://github.com/phpmyadmin/phpmyadmin/commit/89fc55086201501291d2f8692a97389097159d6a
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-09-05 (Tue, 05 Sep 2017)

  Changed paths:
    M libraries/classes/Config/ServerConfigChecks.php

  Log Message:
  -----------
  Use Url::getCommon to generate full URLs

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 6b975e8e1eef35246808dfa8a3bf3769de8131ac
      https://github.com/phpmyadmin/phpmyadmin/commit/6b975e8e1eef35246808dfa8a3bf3769de8131ac
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-09-05 (Tue, 05 Sep 2017)

  Changed paths:
    A test/classes/config/ServerConfigChecksTest.php
    M test/libraries/PMA_SetupIndex_test.php

  Log Message:
  -----------
  Move tests for ServerConfigChecks class to separate file

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: a43dc285f3ed73ec4732d0430da2496ad354b1b6
      https://github.com/phpmyadmin/phpmyadmin/commit/a43dc285f3ed73ec4732d0430da2496ad354b1b6
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-09-05 (Tue, 05 Sep 2017)

  Changed paths:
    M test/classes/config/ServerConfigChecksTest.php

  Log Message:
  -----------
  Split up tests for ServerConfigChecks

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 94219fffab2f9f9fdf6fc1b6a75afc702787a1a7
      https://github.com/phpmyadmin/phpmyadmin/commit/94219fffab2f9f9fdf6fc1b6a75afc702787a1a7
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-09-05 (Tue, 05 Sep 2017)

  Changed paths:
    M libraries/classes/Config/ServerConfigChecks.php
    M test/classes/config/ServerConfigChecksTest.php

  Log Message:
  -----------
  Wrap function_exists in ServerConfigChecks to allow testing

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 205138fdf7fb6a9647c3186fe1d46debabb492da
      https://github.com/phpmyadmin/phpmyadmin/commit/205138fdf7fb6a9647c3186fe1d46debabb492da
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-09-05 (Tue, 05 Sep 2017)

  Changed paths:
    M test/classes/config/DescriptionTest.php

  Log Message:
  -----------
  Add tests for getting all configuration descriptions

Signed-off-by: Michal Čihař <michal at cihar.com>


  Commit: 4b983d66487f7ac1680d9432eb7fff0f76f36ce2
      https://github.com/phpmyadmin/phpmyadmin/commit/4b983d66487f7ac1680d9432eb7fff0f76f36ce2
  Author: Michal Čihař <michal at cihar.com>
  Date:   2017-09-05 (Tue, 05 Sep 2017)

  Changed paths:
    M libraries/classes/Config/Descriptions.php

  Log Message:
  -----------
  Remove unused strings

Signed-off-by: Michal Čihař <michal at cihar.com>


Compare: https://github.com/phpmyadmin/phpmyadmin/compare/78ccbbd7f43c...4b983d66487f