[phpMyAdmin Git] [phpmyadmin/sql-parser] d046cb: Fix building of RenameStatement

Deven Bansod devenbansod.bits at gmail.com
Fri Dec 21 06:36:23 CET 2018


Branch: refs/heads/master
Home: https://github.com/phpmyadmin/sql-parser
Commit: d046cb2b4bf0a0c072644efe391c0cdbd3cfd7f4
https://github.com/phpmyadmin/sql-parser/commit/d046cb2b4bf0a0c072644efe391c0cdbd3cfd7f4
Author: Deven Bansod <devenbansod.bits at gmail.com>
Date: 2018-12-20 (Thu, 12 December 2018) +05:30

Changed paths: 
A tests/Builder/RenameStatementTest.php
M src/Components/RenameOperation.php
M src/Statements/CreateStatement.php
M src/Statements/RenameStatement.php

Log Message:
-----------
Fix building of RenameStatement

* The nuance here is that we don't treat `RENAME TABLE` as the keyword of the clause, only `RENAME` is considered.
* That's why we can't use `Statement::$CLAUSES` directly here (even with value of `3` (see `Statement::$CLAUSES`))
* Providing an overriden definition of `build()` in RenameStatement

Signed-off-by: Deven Bansod <devenbansod.bits at gmail.com>

Commit: 1b644028d693f7140868ba32e4847e5cd866fa4f
https://github.com/phpmyadmin/sql-parser/commit/1b644028d693f7140868ba32e4847e5cd866fa4f
Author: Deven Bansod <devenbansod at users.noreply.github.com>
Date: 2018-12-21 (Fri, 12 December 2018) +05:30

Changed paths: 
A tests/Builder/RenameStatementTest.php
M src/Components/RenameOperation.php
M src/Statements/CreateStatement.php
M src/Statements/RenameStatement.php

Log Message:
-----------
Merge pull request #210 from devenbansod/fix/204

Fix building of RenameStatement



More information about the Git mailing list