[phpMyAdmin Git] [phpmyadmin/phpmyadmin] e816e4: phpstan level 0 (#14405)

[William Desportes]

  Branch: refs/heads/master
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: e816e45c183f49e770b4c36714c509e913d2043c
      https://github.com/phpmyadmin/phpmyadmin/commit/e816e45c183f49e770b4c36714c509e913d2043c
  Author: William Desportes <williamdes at wdes.fr>
  Date:   2018-06-25 (Mon, 25 Jun 2018)

  Changed paths:
    M libraries/classes/Config/Validator.php
    M libraries/classes/Controllers/Server/ServerDatabasesController.php
    M libraries/classes/Database/Qbe.php
    M libraries/classes/DatabaseInterface.php
    M libraries/classes/Error.php
    M libraries/classes/Footer.php
    M libraries/classes/Gis/GisVisualization.php
    M libraries/classes/Logging.php
    M libraries/classes/Plugins.php
    M libraries/classes/Plugins/Export/Helpers/Pdf.php
    M libraries/classes/Plugins/Import/ImportSql.php
    M libraries/classes/Plugins/Schema/Dia/DiaRelationSchema.php
    M libraries/classes/Plugins/Schema/Pdf/Pdf.php
    M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php
    M libraries/classes/Rte/Routines.php
    M libraries/classes/Server/Privileges.php
    M libraries/classes/Table.php
    M libraries/classes/Twig/I18n/TokenParserTrans.php
    M libraries/classes/TwoFactor.php
    M libraries/classes/Types.php
    M phpstan.neon
    M test/bootstrap-phpstan.php
    M test/classes/BookmarkTest.php
    M test/classes/Config/FormTest.php
    M test/classes/Config/ServerConfigChecksTest.php
    M test/classes/Controllers/Server/ServerBinlogControllerTest.php
    M test/classes/Controllers/Server/ServerDatabasesControllerTest.php
    M test/classes/Controllers/Table/TableSearchControllerTest.php
    M test/classes/Database/QbeTest.php
    M test/classes/Display/ResultsTest.php
    M test/classes/ErrorHandlerTest.php
    M test/classes/FooterTest.php
    M test/classes/Gis/GisFactoryTest.php
    M test/classes/Gis/GisGeomTestCase.php
    M test/classes/Gis/GisGeometryTest.php
    M test/classes/Gis/GisLineStringTest.php
    M test/classes/Gis/GisMultiLineStringTest.php
    M test/classes/Gis/GisMultiPointTest.php
    M test/classes/Gis/GisMultiPolygonTest.php
    M test/classes/Gis/GisPointTest.php
    M test/classes/Gis/GisPolygonTest.php
    M test/classes/ListDatabaseTest.php
    M test/classes/MessageTest.php
    M test/classes/Navigation/NavigationTest.php
    M test/classes/Plugins/Export/ExportSqlTest.php
    M test/classes/PmaTestCase.php
    M test/classes/ReplicationGuiTest.php
    M test/classes/ScriptsTest.php
    M test/classes/SystemDatabaseTest.php
    M test/classes/ThemeTest.php
    M test/classes/TwoFactorTest.php
    M test/classes/TypesTest.php
    M test/selenium/ChangePasswordTest.php
    M test/selenium/ServerSettingsTest.php
    M test/selenium/TestBase.php
    M test/selenium/XssTest.php
    M transformation_wrapper.php

  Log Message:
  -----------
  phpstan level 0 (#14405)

* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes at wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes at wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes at wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes at wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes at wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes at wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes at wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes at wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes at wdes.fr>



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.