[phpMyAdmin Git] [phpmyadmin/phpmyadmin] fd3dde: Fixed condition on the emptiness of enum type criteriaValues array (#14648)

Alessandro Dolci alessandro.rn at gmail.com
Wed Oct 31 01:10:17 CET 2018


Branch: refs/heads/QA_4_8
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: fd3dde47a634e23fec7eed09e42fc9c54d858ebc
https://github.com/phpmyadmin/phpmyadmin/commit/fd3dde47a634e23fec7eed09e42fc9c54d858ebc
Author: Alessandro Dolci <alessandro.rn at gmail.com>
Date: 2018-10-30 (Tue, 10 October 2018) -03:00

Changed paths: 
M libraries/classes/Controllers/Table/TableSearchController.php

Log Message:
-----------
Fixed condition on the emptiness of enum type criteriaValues array (#14648)

The if condition has a call to the empty function on the criteriaValues array, but in the considered case that array only contains a '0', so this makes it look empty to the function. I added a control on the first element of the array, to avoid this specific situation.
It's my first contribution, so I hope I did well with the branches. Let me know if there's something missing or to do, I'm happy to help.

Signed-off-by: Alessandro Dolci <alessandro.dolci at pm.me>
(cherry picked from commit 3f5fff3f4d474fd9dd67f54ff2366d2a466e0c07)
Signed-off-by: MaurĂ­cio Meneghini Fauth <mauriciofauth at gmail.com>



More information about the Git mailing list