[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 0d8f6a: Merge isset and unset calls

[Hugues Peccatte]

Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 0d8f6a3a93cbd099366fd76e22d0b35992415ffd
https://github.com/phpmyadmin/phpmyadmin/commit/0d8f6a3a93cbd099366fd76e22d0b35992415ffd
Author: Hugues Peccatte <hugues.peccatte at gmail.com>
Date: 2019-07-16 (Tue, 07 July 2019) -03:00

Changed paths: 
M error_report.php
M examples/openid.php
M import.php
M libraries/classes/Bookmark.php
M libraries/classes/Config.php
M libraries/classes/Config/FormDisplay.php
M libraries/classes/Controllers/HomeController.php
M libraries/classes/Controllers/Table/ChartController.php
M libraries/classes/Controllers/Table/RelationController.php
M libraries/classes/Controllers/Table/StructureController.php
M libraries/classes/Core.php
M libraries/classes/Database/Qbe.php
M libraries/classes/DatabaseInterface.php
M libraries/classes/Error.php
M libraries/classes/ErrorReport.php
M libraries/classes/Font.php
M libraries/classes/Gis/GisGeometry.php
M libraries/classes/Gis/GisVisualization.php
M libraries/classes/Header.php
M libraries/classes/InsertEdit.php
M libraries/classes/Plugins.php
M libraries/classes/Plugins/Auth/AuthenticationCookie.php
M libraries/classes/Plugins/Auth/AuthenticationHttp.php
M libraries/classes/Plugins/AuthenticationPlugin.php
M libraries/classes/Plugins/Export/ExportSql.php
M libraries/classes/Plugins/Export/ExportXml.php
M libraries/classes/Plugins/Export/Helpers/Pdf.php
M libraries/classes/Plugins/Import/ImportCsv.php
M libraries/classes/Plugins/Import/ImportOds.php
M libraries/classes/Plugins/Import/ImportShp.php
M libraries/classes/Plugins/Import/ImportXml.php
M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php
M libraries/classes/Plugins/TwoFactor/Key.php
M libraries/classes/Relation.php
M libraries/classes/ReplicationGui.php
M libraries/classes/Rte/Routines.php
M libraries/classes/Server/Privileges.php
M libraries/classes/Server/Status/Data.php
M libraries/classes/Server/Status/Monitor.php
M libraries/classes/Sql.php
M libraries/classes/SqlQueryForm.php
M libraries/classes/Table.php
M libraries/classes/Util.php
M libraries/db_common.inc.php
M libraries/entry_points/database/tracking.php
M libraries/tbl_columns_definition_form.inc.php
M prefs_manage.php
M sql.php
M tbl_change.php
M tbl_gis_visualization.php
M tbl_operations.php
M tbl_replace.php
M view_create.php

Log Message:
-----------
Merge isset and unset calls

Signed-off-by: Hugues Peccatte <hugues.peccatte at gmail.com>

Commit: 9c0806cfcf9bc60a954c271f939e2f4b42507493
https://github.com/phpmyadmin/phpmyadmin/commit/9c0806cfcf9bc60a954c271f939e2f4b42507493
Author: Hugues Peccatte <hugues.peccatte at gmail.com>
Date: 2019-07-16 (Tue, 07 July 2019) -03:00

Changed paths: 
M db_import.php
M libraries/classes/DatabaseInterface.php
M libraries/classes/File.php
M libraries/classes/Plugins/Export/ExportSql.php
M server_import.php
M tbl_import.php

Log Message:
-----------
Fix static / non-static calls

Signed-off-by: Hugues Peccatte <hugues.peccatte at gmail.com>

Commit: 598a4db58825b52f5b3ac8852ffdcbaad7a4ae99
https://github.com/phpmyadmin/phpmyadmin/commit/598a4db58825b52f5b3ac8852ffdcbaad7a4ae99
Author: Hugues Peccatte <hugues.peccatte at gmail.com>
Date: 2019-07-16 (Tue, 07 July 2019) -03:00

Changed paths: 
M libraries/classes/Advisor.php
M libraries/classes/Config.php
M libraries/classes/Controllers/Table/StructureController.php

Log Message:
-----------
Use short calculation/assignation syntax when possible

Signed-off-by: Hugues Peccatte <hugues.peccatte at gmail.com>

Commit: 41164d2904326639ca1c1bbf060e0fb345f58513
https://github.com/phpmyadmin/phpmyadmin/commit/41164d2904326639ca1c1bbf060e0fb345f58513
Author: Hugues Peccatte <hugues.peccatte at gmail.com>
Date: 2019-07-16 (Tue, 07 July 2019) -03:00

Changed paths: 
M libraries/classes/Config.php
M libraries/classes/Plugins/Import/ImportXml.php
M libraries/classes/StorageEngine.php
M libraries/classes/Table.php
M libraries/classes/Util.php

Log Message:
-----------
Improve function calls order

Signed-off-by: Hugues Peccatte <hugues.peccatte at gmail.com>

Commit: 1b744d0cc8cffa3849b7fb3d3c21f4a64eebd5e5
https://github.com/phpmyadmin/phpmyadmin/commit/1b744d0cc8cffa3849b7fb3d3c21f4a64eebd5e5
Author: Hugues Peccatte <hugues.peccatte at gmail.com>
Date: 2019-07-16 (Tue, 07 July 2019) -03:00

Changed paths: 
M libraries/classes/DatabaseInterface.php

Log Message:
-----------
Simplify code regarding type hinting

Signed-off-by: Hugues Peccatte <hugues.peccatte at gmail.com>

Commit: 6ddb9b3a22453a372a5787cd465c2990b1a9c260
https://github.com/phpmyadmin/phpmyadmin/commit/6ddb9b3a22453a372a5787cd465c2990b1a9c260
Author: Hugues Peccatte <hugues.peccatte at gmail.com>
Date: 2019-07-16 (Tue, 07 July 2019) -03:00

Changed paths: 
M libraries/classes/Export.php
M libraries/classes/Rte/Routines.php

Log Message:
-----------
Use right order of parameters for implode

Signed-off-by: Hugues Peccatte <hugues.peccatte at gmail.com>

Commit: 4447299bdced1191e873def3597d7c54e40b413d
https://github.com/phpmyadmin/phpmyadmin/commit/4447299bdced1191e873def3597d7c54e40b413d
Author: Hugues Peccatte <hugues.peccatte at gmail.com>
Date: 2019-07-16 (Tue, 07 July 2019) -03:00

Changed paths: 
M libraries/classes/Font.php
M libraries/classes/Plugins/Import/ImportCsv.php

Log Message:
-----------
Remaining minor changes

Signed-off-by: Hugues Peccatte <hugues.peccatte at gmail.com>

Commit: ae77d630b156738462098fe35e5c4421f852028d
https://github.com/phpmyadmin/phpmyadmin/commit/ae77d630b156738462098fe35e5c4421f852028d
Author: Hugues Peccatte <hugues.peccatte at gmail.com>
Date: 2019-07-16 (Tue, 07 July 2019) -03:00

Changed paths: 
M libraries/classes/Plugins/Auth/AuthenticationSignon.php
M libraries/common.inc.php
M test/EnvironmentTest.php

Log Message:
-----------
Use constants when possible

Signed-off-by: Hugues Peccatte <hugues.peccatte at gmail.com>

Commit: c233a4364a7278aa4897cccd1c1fe507e2a97379
https://github.com/phpmyadmin/phpmyadmin/commit/c233a4364a7278aa4897cccd1c1fe507e2a97379
Author: Hugues Peccatte <hugues.peccatte at gmail.com>
Date: 2019-07-16 (Tue, 07 July 2019) -03:00

Changed paths: 
M libraries/classes/Config.php
M libraries/classes/Controllers/Server/DatabasesController.php
M show_config_errors.php

Log Message:
-----------
Use right PHP function

Signed-off-by: Hugues Peccatte <hugues.peccatte at gmail.com>

Commit: ffdc2cf7bf66b1e7f1090b9d05794483bc3f4df0
https://github.com/phpmyadmin/phpmyadmin/commit/ffdc2cf7bf66b1e7f1090b9d05794483bc3f4df0
Author: Maurício Meneghini Fauth <mauricio at fauth.dev>
Date: 2019-07-16 (Tue, 07 July 2019) -03:00

Changed paths: 
M db_import.php
M error_report.php
M examples/openid.php
M import.php
M libraries/classes/Advisor.php
M libraries/classes/Bookmark.php
M libraries/classes/Config.php
M libraries/classes/Config/FormDisplay.php
M libraries/classes/Controllers/HomeController.php
M libraries/classes/Controllers/Server/DatabasesController.php
M libraries/classes/Controllers/Table/ChartController.php
M libraries/classes/Controllers/Table/RelationController.php
M libraries/classes/Controllers/Table/StructureController.php
M libraries/classes/Core.php
M libraries/classes/Database/Qbe.php
M libraries/classes/DatabaseInterface.php
M libraries/classes/Error.php
M libraries/classes/ErrorReport.php
M libraries/classes/Export.php
M libraries/classes/File.php
M libraries/classes/Font.php
M libraries/classes/Gis/GisGeometry.php
M libraries/classes/Gis/GisVisualization.php
M libraries/classes/Header.php
M libraries/classes/InsertEdit.php
M libraries/classes/Plugins.php
M libraries/classes/Plugins/Auth/AuthenticationCookie.php
M libraries/classes/Plugins/Auth/AuthenticationHttp.php
M libraries/classes/Plugins/Auth/AuthenticationSignon.php
M libraries/classes/Plugins/AuthenticationPlugin.php
M libraries/classes/Plugins/Export/ExportSql.php
M libraries/classes/Plugins/Export/ExportXml.php
M libraries/classes/Plugins/Export/Helpers/Pdf.php
M libraries/classes/Plugins/Import/ImportCsv.php
M libraries/classes/Plugins/Import/ImportOds.php
M libraries/classes/Plugins/Import/ImportShp.php
M libraries/classes/Plugins/Import/ImportXml.php
M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php
M libraries/classes/Plugins/TwoFactor/Key.php
M libraries/classes/Relation.php
M libraries/classes/ReplicationGui.php
M libraries/classes/Rte/Routines.php
M libraries/classes/Server/Privileges.php
M libraries/classes/Server/Status/Data.php
M libraries/classes/Server/Status/Monitor.php
M libraries/classes/Sql.php
M libraries/classes/SqlQueryForm.php
M libraries/classes/StorageEngine.php
M libraries/classes/Table.php
M libraries/classes/Util.php
M libraries/common.inc.php
M libraries/db_common.inc.php
M libraries/entry_points/database/tracking.php
M libraries/tbl_columns_definition_form.inc.php
M prefs_manage.php
M server_import.php
M show_config_errors.php
M sql.php
M tbl_change.php
M tbl_gis_visualization.php
M tbl_import.php
M tbl_operations.php
M tbl_replace.php
M test/EnvironmentTest.php
M view_create.php

Log Message:
-----------
Merge branch 'Tithugues-fix/minor-improvements'