[phpMyAdmin Git] [phpmyadmin/sql-parser] b47e27: Fix PHP warnings when building an incomplete CASE expression

Thomas Gerbet thomas at gerbet.me
Sun May 5 17:20:06 CEST 2019


Branch: refs/heads/master
Home: https://github.com/phpmyadmin/sql-parser
Commit: b47e27b8724cb2639cccec9430076ef8a68c869c
https://github.com/phpmyadmin/sql-parser/commit/b47e27b8724cb2639cccec9430076ef8a68c869c
Author: Thomas Gerbet <thomas at gerbet.me>
Date: 2019-04-10 (Wed, 04 April 2019) +02:00

Changed paths: 
M src/Components/CaseExpression.php
M tests/Components/CaseExpressionTest.php
M tests/data/parser/parseSelectCase1.out
M tests/data/parser/parseSelectCase2.out
M tests/data/parser/parseSelectCase3.out
M tests/data/parser/parseSelectCase4.out
M tests/data/parser/parseSelectCaseAlias1.out
M tests/data/parser/parseSelectCaseAlias2.out
M tests/data/parser/parseSelectCaseAlias5.out
M tests/data/parser/parseSelectCaseAlias6.out
M tests/data/parser/parseSelectCaseAliasErr1.out
M tests/data/parser/parseSelectCaseAliasErr2.out
M tests/data/parser/parseSelectCaseAliasErr3.out
M tests/data/parser/parseSelectCaseAliasErr4.out
M tests/data/parser/parseSelectCaseErr1.out
M tests/data/parser/parseSelectCaseErr2.out
M tests/data/parser/parseSelectCaseErr3.out
M tests/data/parser/parseSelectCaseErr4.out
M tests/data/parser/parseSelectCaseErr5.out

Log Message:
-----------
Fix PHP warnings when building an incomplete CASE expression

Issue can be reproduced with the following code snippet:
```php
new \PhpMyAdmin\SqlParser\Parser('SELECT a CASE');
// PHP Warning:  count(): Parameter must be an array or an object that implements Countable in src/Components/CaseExpression.php on line 296
// PHP Warning:  count(): Parameter must be an array or an object that implements Countable in src/Components/CaseExpression.php on line 297
```

Commit: a7c5771e608f2e0204f7896d8661b84ec78414bb
https://github.com/phpmyadmin/sql-parser/commit/a7c5771e608f2e0204f7896d8661b84ec78414bb
Author: Isaac Bennetch <bennetch at gmail.com>
Date: 2019-05-05 (Sun, 05 May 2019) -04:00

Changed paths: 
M src/Components/CaseExpression.php
M tests/Components/CaseExpressionTest.php
M tests/data/parser/parseSelectCase1.out
M tests/data/parser/parseSelectCase2.out
M tests/data/parser/parseSelectCase3.out
M tests/data/parser/parseSelectCase4.out
M tests/data/parser/parseSelectCaseAlias1.out
M tests/data/parser/parseSelectCaseAlias2.out
M tests/data/parser/parseSelectCaseAlias5.out
M tests/data/parser/parseSelectCaseAlias6.out
M tests/data/parser/parseSelectCaseAliasErr1.out
M tests/data/parser/parseSelectCaseAliasErr2.out
M tests/data/parser/parseSelectCaseAliasErr3.out
M tests/data/parser/parseSelectCaseAliasErr4.out
M tests/data/parser/parseSelectCaseErr1.out
M tests/data/parser/parseSelectCaseErr2.out
M tests/data/parser/parseSelectCaseErr3.out
M tests/data/parser/parseSelectCaseErr4.out
M tests/data/parser/parseSelectCaseErr5.out

Log Message:
-----------
Merge pull request #241 from LeSuisse/php-warning-incomplete-case-expression

Fix PHP warnings when building an incomplete CASE expression



More information about the Git mailing list