[phpMyAdmin Git] [phpmyadmin/phpmyadmin] ca3c5e: Remove underscore prefix from method names

charliewindred charliewindred at gmail.com
Wed Jun 3 00:21:45 CEST 2020 

Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: ca3c5e17b041690d585794d4595f2e7250cdd589
https://github.com/phpmyadmin/phpmyadmin/commit/ca3c5e17b041690d585794d4595f2e7250cdd589
Author: charliewindred <charliewindred at gmail.com>
Date: 2020-06-02 (Tue, 06 June 2020) +01:00

Changed paths: 
M libraries/classes/Config.php
M libraries/classes/Config/FormDisplay.php
M libraries/classes/Config/PageSettings.php
M libraries/classes/Database/Qbe.php
M libraries/classes/Footer.php
M libraries/classes/Gis/GisGeometryCollection.php
M libraries/classes/Gis/GisMultiPolygon.php
M libraries/classes/Gis/GisPolygon.php
M libraries/classes/Gis/GisVisualization.php
M libraries/classes/Header.php
M libraries/classes/Html/Generator.php
M libraries/classes/Index.php
M libraries/classes/Menu.php
M libraries/classes/OutputBuffering.php
M libraries/classes/Plugins/Auth/AuthenticationCookie.php
M libraries/classes/Plugins/Export/ExportCodegen.php
M libraries/classes/Plugins/Export/ExportMediawiki.php
M libraries/classes/Plugins/Export/ExportPdf.php
M libraries/classes/Plugins/Export/ExportSql.php
M libraries/classes/Plugins/Export/ExportXml.php
M libraries/classes/Plugins/Import/ImportCsv.php
M libraries/classes/Plugins/Import/ImportMediawiki.php
M libraries/classes/Plugins/Import/ImportSql.php
M libraries/classes/Plugins/Schema/Dia/DiaRelationSchema.php
M libraries/classes/Plugins/Schema/Dia/RelationStatsDia.php
M libraries/classes/Plugins/Schema/Eps/EpsRelationSchema.php
M libraries/classes/Plugins/Schema/Eps/TableStatsEps.php
M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php
M libraries/classes/Plugins/Schema/Pdf/TableStatsPdf.php
M libraries/classes/Plugins/Schema/RelationStats.php
M libraries/classes/Plugins/Schema/Svg/SvgRelationSchema.php
M libraries/classes/Plugins/Schema/Svg/TableStatsSvg.php
M libraries/classes/RecentFavoriteTable.php
M libraries/classes/Response.php
M libraries/classes/Scripts.php
M libraries/classes/Server/Status/Data.php
M libraries/classes/Server/SysInfo/SunOs.php
M libraries/classes/Server/SysInfo/WindowsNt.php
M libraries/classes/Setup/ConfigGenerator.php
M libraries/classes/Table.php
M libraries/classes/ThemeManager.php
M libraries/classes/Tracker.php
M libraries/classes/Util.php
M test/classes/Database/DesignerTest.php
M test/classes/Gis/GisMultiPolygonTest.php
M test/classes/Gis/GisPolygonTest.php
M test/selenium/CreateDropDatabaseTest.php
M test/selenium/Database/EventsTest.php
M test/selenium/Database/OperationsTest.php
M test/selenium/Database/ProceduresTest.php
M test/selenium/Database/TriggersTest.php
M test/selenium/ExportTest.php
M test/selenium/ImportTest.php
M test/selenium/NormalizationTest.php
M test/selenium/ServerSettingsTest.php
M test/selenium/SqlQueryTest.php
M test/selenium/Table/CreateTest.php
M test/selenium/Table/InsertTest.php
M test/selenium/TrackingTest.php

Log Message:
-----------
Remove underscore prefix from method names

Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred at gmail.com>

Commit: 195c11d928ae2066a769ba0f718dede7121f80fa
https://github.com/phpmyadmin/phpmyadmin/commit/195c11d928ae2066a769ba0f718dede7121f80fa
Author: charliewindred <charliewindred at gmail.com>
Date: 2020-06-02 (Tue, 06 June 2020) +01:00

Changed paths: 
M libraries/classes/Response.php

Log Message:
-----------
Fixed unused private methods in Response.php

Removed missed underscores that caused unused private method errors.

Signed-off-by: charliewindred <charliewindred at gmail.com>

Commit: cec8c6f9b3665ba0fdf7e8139cdd053d908e71f9
https://github.com/phpmyadmin/phpmyadmin/commit/cec8c6f9b3665ba0fdf7e8139cdd053d908e71f9
Author: charliewindred <charliewindred at gmail.com>
Date: 2020-06-02 (Tue, 06 June 2020) +02:00

Changed paths: 
M phpstan-baseline.neon

Log Message:
-----------
Updated baselines

Updated baselines after fixing previous errors.

Signed-off-by: charliewindred <charliewindred at gmail.com>

Commit: 7d792e88f67f685205c92cdd2e94abc9f9a53e2e
https://github.com/phpmyadmin/phpmyadmin/commit/7d792e88f67f685205c92cdd2e94abc9f9a53e2e
Author: charliewindred <charliewindred at gmail.com>
Date: 2020-06-02 (Tue, 06 June 2020) +02:00

Changed paths: 
M test/classes/Config/FormDisplayTest.php
M test/classes/Database/QbeTest.php
M test/classes/FooterTest.php
M test/classes/Gis/GisVisualizationTest.php
M test/classes/Plugins/Auth/AuthenticationCookieTest.php
M test/classes/Plugins/Export/ExportCodegenTest.php
M test/classes/Plugins/Export/ExportSqlTest.php
M test/classes/Setup/ConfigGeneratorTest.php
M test/classes/TableTest.php
M test/classes/TrackerTest.php

Log Message:
-----------
Removed underscores from unit test methods

Removed underscore prefixes from unit test method calls.

Signed-off-by: charliewindred <charliewindred at gmail.com>

Commit: 707d2635318de1719c4ffe3c9ba03be4254f0b8d
https://github.com/phpmyadmin/phpmyadmin/commit/707d2635318de1719c4ffe3c9ba03be4254f0b8d
Author: William Desportes <williamdes at wdes.fr>
Date: 2020-06-02 (Tue, 06 June 2020) +02:00

Changed paths: 
M test/classes/Plugins/Export/ExportPdfTest.php

Log Message:
-----------
Fix testSetGetPdf and testSetGetPdfTitle

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 3f0b7390e2aaa82d63b3318aa14ff44fdf27c5f5
https://github.com/phpmyadmin/phpmyadmin/commit/3f0b7390e2aaa82d63b3318aa14ff44fdf27c5f5
Author: William Desportes <williamdes at wdes.fr>
Date: 2020-06-02 (Tue, 06 June 2020) +02:00

Changed paths: 
M libraries/classes/Plugins/Schema/Dia/RelationStatsDia.php
M test/classes/Config/FormDisplayTest.php
M test/classes/Plugins/Auth/AuthenticationCookieTest.php

Log Message:
-----------
Fix documentation after removing _ from private methods

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: a13e5d1c16fb55ff82a6c6faedeb591d019e02c0
https://github.com/phpmyadmin/phpmyadmin/commit/a13e5d1c16fb55ff82a6c6faedeb591d019e02c0
Author: William Desportes <williamdes at wdes.fr>
Date: 2020-06-03 (Wed, 06 June 2020) +02:00

Changed paths: 
M test/classes/Database/SearchTest.php
M test/classes/FooterTest.php

Log Message:
-----------
Fix tests documentation after removing _ from private methods

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 9668731fe6ce924788b21d958e33525e30f3173b
https://github.com/phpmyadmin/phpmyadmin/commit/9668731fe6ce924788b21d958e33525e30f3173b
Author: William Desportes <williamdes at wdes.fr>
Date: 2020-06-03 (Wed, 06 June 2020) +02:00

Changed paths: 
M test/selenium/NormalizationTest.php
M test/selenium/SqlQueryTest.php

Log Message:
-----------
Fix selenium tests warnings on private test methods after removing _

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 7c50dc71a0b70bd7b44f31840299583c20e4f665
https://github.com/phpmyadmin/phpmyadmin/commit/7c50dc71a0b70bd7b44f31840299583c20e4f665
Author: William Desportes <williamdes at wdes.fr>
Date: 2020-06-03 (Wed, 06 June 2020) +02:00

Changed paths: 
M libraries/classes/Config.php
M libraries/classes/Config/FormDisplay.php
M libraries/classes/Config/PageSettings.php
M libraries/classes/Database/Qbe.php
M libraries/classes/Footer.php
M libraries/classes/Gis/GisGeometryCollection.php
M libraries/classes/Gis/GisMultiPolygon.php
M libraries/classes/Gis/GisPolygon.php
M libraries/classes/Gis/GisVisualization.php
M libraries/classes/Header.php
M libraries/classes/Html/Generator.php
M libraries/classes/Index.php
M libraries/classes/Menu.php
M libraries/classes/OutputBuffering.php
M libraries/classes/Plugins/Auth/AuthenticationCookie.php
M libraries/classes/Plugins/Export/ExportCodegen.php
M libraries/classes/Plugins/Export/ExportMediawiki.php
M libraries/classes/Plugins/Export/ExportPdf.php
M libraries/classes/Plugins/Export/ExportSql.php
M libraries/classes/Plugins/Export/ExportXml.php
M libraries/classes/Plugins/Import/ImportCsv.php
M libraries/classes/Plugins/Import/ImportMediawiki.php
M libraries/classes/Plugins/Import/ImportSql.php
M libraries/classes/Plugins/Schema/Dia/DiaRelationSchema.php
M libraries/classes/Plugins/Schema/Dia/RelationStatsDia.php
M libraries/classes/Plugins/Schema/Eps/EpsRelationSchema.php
M libraries/classes/Plugins/Schema/Eps/TableStatsEps.php
M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php
M libraries/classes/Plugins/Schema/Pdf/TableStatsPdf.php
M libraries/classes/Plugins/Schema/RelationStats.php
M libraries/classes/Plugins/Schema/Svg/SvgRelationSchema.php
M libraries/classes/Plugins/Schema/Svg/TableStatsSvg.php
M libraries/classes/RecentFavoriteTable.php
M libraries/classes/Response.php
M libraries/classes/Scripts.php
M libraries/classes/Server/Status/Data.php
M libraries/classes/Server/SysInfo/SunOs.php
M libraries/classes/Server/SysInfo/WindowsNt.php
M libraries/classes/Setup/ConfigGenerator.php
M libraries/classes/Table.php
M libraries/classes/ThemeManager.php
M libraries/classes/Tracker.php
M libraries/classes/Util.php
M phpstan-baseline.neon
M test/classes/Config/FormDisplayTest.php
M test/classes/Database/DesignerTest.php
M test/classes/Database/QbeTest.php
M test/classes/Database/SearchTest.php
M test/classes/FooterTest.php
M test/classes/Gis/GisMultiPolygonTest.php
M test/classes/Gis/GisPolygonTest.php
M test/classes/Gis/GisVisualizationTest.php
M test/classes/Plugins/Auth/AuthenticationCookieTest.php
M test/classes/Plugins/Export/ExportCodegenTest.php
M test/classes/Plugins/Export/ExportPdfTest.php
M test/classes/Plugins/Export/ExportSqlTest.php
M test/classes/Setup/ConfigGeneratorTest.php
M test/classes/TableTest.php
M test/classes/TrackerTest.php
M test/selenium/CreateDropDatabaseTest.php
M test/selenium/Database/EventsTest.php
M test/selenium/Database/OperationsTest.php
M test/selenium/Database/ProceduresTest.php
M test/selenium/Database/TriggersTest.php
M test/selenium/ExportTest.php
M test/selenium/ImportTest.php
M test/selenium/NormalizationTest.php
M test/selenium/ServerSettingsTest.php
M test/selenium/SqlQueryTest.php
M test/selenium/Table/CreateTest.php
M test/selenium/Table/InsertTest.php
M test/selenium/TrackingTest.php

Log Message:
-----------
Merge #16159 - Remove underscore prefix from method names

Pull-request: #16159

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: b0021bf84d8b8abd81008668fb3e55f6396046c1
https://github.com/phpmyadmin/phpmyadmin/commit/b0021bf84d8b8abd81008668fb3e55f6396046c1
Author: William Desportes <williamdes at wdes.fr>
Date: 2020-06-03 (Wed, 06 June 2020) +02:00

Changed paths: 
M libraries/classes/DatabaseInterface.php
M libraries/classes/Pdf.php
M libraries/classes/Plugins/Export/ExportSql.php
M libraries/classes/Plugins/Export/ExportXml.php
M phpcs.xml.dist

Log Message:
-----------
Fixes: #16149 - Remove underscore prefix from all method names

Ref: #16159

Signed-off-by: William Desportes <williamdes at wdes.fr>

More information about the Git mailing list