[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 5dad1d: Fix: Don't add multiple OpenLayers maps, remove listeners on dispose

[Maximilian Krög]

Branch: refs/heads/QA_5_1
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 5dad1d0bb7ad24a00b95f9f1bc66ef2e9e71ef57
https://github.com/phpmyadmin/phpmyadmin/commit/5dad1d0bb7ad24a00b95f9f1bc66ef2e9e71ef57
Author: Maximilian Krög <maxi_kroeg at web.de>
Date: 2021-08-10 (Tue, 08 August 2021) +02:00

Changed paths: 
M js/src/table/gis_visualization.js
M libraries/classes/Gis/GisVisualization.php
M templates/table/gis_visualization/gis_visualization.twig

Log Message:
-----------
Fix: Don't add multiple OpenLayers maps, remove listeners on dispose

With 5.1 the map is only created when it is first shown, but every second time
switching to the map a new instance is created because zero is returned when no new
map was created.

OpenLayers adds a resize listener to the window when a target is defined to
handle size adjustments, but this means setTarget(null) has to be called to
fully dispose of the added listener when the map is no longer needed.

Signed-off-by: Maximilian Krög <maxi_kroeg at web.de>

Commit: d804e60820f28f953874bf2f5cdd97d8c1a97e22
https://github.com/phpmyadmin/phpmyadmin/commit/d804e60820f28f953874bf2f5cdd97d8c1a97e22
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-14 (Sat, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Query/Utilities.php
M libraries/classes/Table.php

Log Message:
-----------
Fix broken docs link after FK types mismatch error

See: https://web.archive.org/web/20200921164945/https://dev.mysql.com/doc/refman/8.0/en/innodb-foreign-key-constraints.html

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: ff6da222262b88089b5a569f65577b46871aac43
https://github.com/phpmyadmin/phpmyadmin/commit/ff6da222262b88089b5a569f65577b46871aac43
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-14 (Sat, 08 August 2021) +02:00

Changed paths: 
M ChangeLog

Log Message:
-----------
Add a ChangeLog entry for d804e60820

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: d7c2af5f1e0c6b7795264014dceb075fe5244c0d
https://github.com/phpmyadmin/phpmyadmin/commit/d7c2af5f1e0c6b7795264014dceb075fe5244c0d
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-14 (Sat, 08 August 2021) +02:00

Changed paths: 
M js/src/table/gis_visualization.js
M libraries/classes/Gis/GisVisualization.php
M templates/table/gis_visualization/gis_visualization.twig

Log Message:
-----------
Merge #17036 - Fix: Don't add multiple OpenLayers maps, remove listeners on dispose

Pull-request: #17036

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 53faf984d7c2e423970dc76e51089f21a5254a9e
https://github.com/phpmyadmin/phpmyadmin/commit/53faf984d7c2e423970dc76e51089f21a5254a9e
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-14 (Sat, 08 August 2021) +02:00

Changed paths: 
M ChangeLog

Log Message:
-----------
Add a ChangeLog entry for d7c2af5f1e

Pull-request: #17036

Signed-off-by: William Desportes <williamdes at wdes.fr>