[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 2ea46a: Ref #16906 - Return an error message if the pma storage db could not be selected

[William Desportes]

Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 2ea46aa1131065125b45f2b3818a86d952a491a5
https://github.com/phpmyadmin/phpmyadmin/commit/2ea46aa1131065125b45f2b3818a86d952a491a5
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-27 (Fri, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Relation.php

Log Message:
-----------
Ref #16906 - Return an error message if the pma storage db could not be selected

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 9c0dcc20433497563e4a6623e5cf951a5bc36978
https://github.com/phpmyadmin/phpmyadmin/commit/9c0dcc20433497563e4a6623e5cf951a5bc36978
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-27 (Fri, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Relation.php

Log Message:
-----------
Fix #16906 - Use the control connection to create the storage database and tables

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: bb2c869e4cf3974b5fb4c88dd9b135f578b0c042
https://github.com/phpmyadmin/phpmyadmin/commit/bb2c869e4cf3974b5fb4c88dd9b135f578b0c042
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-27 (Fri, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Relation.php

Log Message:
-----------
Ref #16906 - Clear the relation cache after the control db was created

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: b527b13e2d0cbc949f07fffcd4878d805e4de9ba
https://github.com/phpmyadmin/phpmyadmin/commit/b527b13e2d0cbc949f07fffcd4878d805e4de9ba
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-27 (Fri, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Relation.php

Log Message:
-----------
Old typo fix

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: c01e681c33150a6b1c50b0da044f144337bffe1c
https://github.com/phpmyadmin/phpmyadmin/commit/c01e681c33150a6b1c50b0da044f144337bffe1c
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-28 (Sat, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Relation.php

Log Message:
-----------
Prevent overriding user setting while auto fixing pma storage

Once the table was created it was overriding the setting. It should respect that the user said the table will be named pma__userconfig_table and not pma__userconfig (the default value).
If the database had the default tables in it, the detection would silently mark them as the right tables totally ignoring the user defined settings for the table names.

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 576decd1f4d4821af5382805e749ee5eb60da316
https://github.com/phpmyadmin/phpmyadmin/commit/576decd1f4d4821af5382805e749ee5eb60da316
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-28 (Sat, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Relation.php

Log Message:
-----------
Fix coding standard issues

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: c775db6b4d3dac88f588e23495661f8b167e41c0
https://github.com/phpmyadmin/phpmyadmin/commit/c775db6b4d3dac88f588e23495661f8b167e41c0
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-28 (Sat, 08 August 2021) +02:00

Changed paths: 
M test/classes/RelationTest.php

Log Message:
-----------
Ref #16906 - Add tests for Relation::getDefaultPmaTableNames

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: b0ec0fd11209d28b3d54139701c0a84c4b5ae796
https://github.com/phpmyadmin/phpmyadmin/commit/b0ec0fd11209d28b3d54139701c0a84c4b5ae796
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-28 (Sat, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Relation.php
M test/classes/DatabaseInterfaceTest.php
M test/classes/RelationTest.php

Log Message:
-----------
Fix #16906 - Replace table names with the configuration ones while creating the storage tables

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: dc5cf4766b52f1d04528cb53c204678263fcfbc4
https://github.com/phpmyadmin/phpmyadmin/commit/dc5cf4766b52f1d04528cb53c204678263fcfbc4
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-28 (Sat, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Relation.php

Log Message:
-----------
Fix #16906 - Escape the table name that is checked with backquotes on canAccessStorageTable function

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 2b177839bf8ed044222e25ec51bbefb908dc57dd
https://github.com/phpmyadmin/phpmyadmin/commit/2b177839bf8ed044222e25ec51bbefb908dc57dd
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-28 (Sat, 08 August 2021) +02:00

Changed paths: 
M test/classes/DatabaseInterfaceTest.php
M test/classes/RelationTest.php
M test/classes/TwoFactorTest.php

Log Message:
-----------
Fix tests after dc5cf4766b

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: f7a328842d8d3d473e5b904c4b6b316ba3bf8cef
https://github.com/phpmyadmin/phpmyadmin/commit/f7a328842d8d3d473e5b904c4b6b316ba3bf8cef
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-31 (Tue, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Controllers/CheckRelationsController.php

Log Message:
-----------
Fix #16906 - Fix the caching effect on the feature list

Before this fix you needed to click twice on create tables to see a full list of green checks.
As part of the values where fetched by a global and the feature list values by this $cfgRelation passed as a parameter.

This was visible when the pmadb existed but had no tables in it.

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 2d307ed06285528375be24eb1b6dc43006a5259d
https://github.com/phpmyadmin/phpmyadmin/commit/2d307ed06285528375be24eb1b6dc43006a5259d
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-31 (Tue, 08 August 2021) +02:00

Changed paths: 
M libraries/classes/Controllers/CheckRelationsController.php
M libraries/classes/Relation.php
M test/classes/DatabaseInterfaceTest.php
M test/classes/RelationTest.php
M test/classes/TwoFactorTest.php

Log Message:
-----------
Merge branch 'QA_5_1'

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: df651fe5a590bbfcf4c14d5710fc8dff444eb510
https://github.com/phpmyadmin/phpmyadmin/commit/df651fe5a590bbfcf4c14d5710fc8dff444eb510
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-31 (Tue, 08 August 2021) +02:00

Changed paths: 
M ChangeLog

Log Message:
-----------
Add 7 ChangeLog entries for #16906

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: bd78d5ff0611910d89ed842120b4685eeef71139
https://github.com/phpmyadmin/phpmyadmin/commit/bd78d5ff0611910d89ed842120b4685eeef71139
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-31 (Tue, 08 August 2021) +02:00

Changed paths: 
M psalm-baseline.xml

Log Message:
-----------
Update psalm baseline

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 828d8e1de49efe12a01b73e2f95ffde5c95335f3
https://github.com/phpmyadmin/phpmyadmin/commit/828d8e1de49efe12a01b73e2f95ffde5c95335f3
Author: William Desportes <williamdes at wdes.fr>
Date: 2021-08-31 (Tue, 08 August 2021) +02:00

Changed paths: 
M ChangeLog
M psalm-baseline.xml
M test/classes/DatabaseInterfaceTest.php
M test/classes/RelationTest.php

Log Message:
-----------
Merge branch 'QA_5_1'

Also fixed tests from previous merge: 2d307ed06285528375be24eb1b6dc43006a5259d

Signed-off-by: William Desportes <williamdes at wdes.fr>