[phpMyAdmin Git] [phpmyadmin/phpmyadmin] a42803: Psalm fixes 3 (#17221)

Kamil Tekiela tekiela246 at gmail.com
Fri Dec 3 16:40:22 CET 2021


Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: a42803297c3110ac10247a5e5a4b663bf1849f59
https://github.com/phpmyadmin/phpmyadmin/commit/a42803297c3110ac10247a5e5a4b663bf1849f59
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2021-12-03 (Fri, 12 December 2021) -03:00

Changed paths: 
M libraries/classes/Controllers/Export/ExportController.php
M libraries/classes/Database/Qbe.php
M libraries/classes/Database/Triggers.php
M libraries/classes/Display/Results.php
M libraries/classes/Plugins/Export/ExportSql.php
M libraries/classes/Server/Privileges.php
M libraries/classes/Utils/HttpRequest.php
M phpstan-baseline.neon
M psalm-baseline.xml
M test/classes/Plugins/Export/ExportSqlTest.php
M test/classes/Server/PrivilegesTest.php

Log Message:
-----------
Psalm fixes 3 (#17221)

* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* Small bug fixes

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* non-falsy-string is always true

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* currentSearch property is nullable

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* Remove unusued parameter $columnIndex

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* Use parameters instead of globals in sendEditor()

The two globals in this method are read-only. There is an unused
parameter in the signature. Let's add one more and use them instead of globals.

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* Remove unusued parameter $crlf

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>



More information about the Git mailing list