[phpMyAdmin Git] [phpmyadmin/sql-parser] f56b02: Refactoring and improving the support of the WITH statement and making other statements aware of it

Fawzi E. Abdulfattah iifawzie at gmail.com
Wed Dec 29 15:35:11 CET 2021


Branch: refs/heads/master
Home: https://github.com/phpmyadmin/sql-parser
Commit: f56b0273e011b3a22ad57365973f7437159d43f2
https://github.com/phpmyadmin/sql-parser/commit/f56b0273e011b3a22ad57365973f7437159d43f2
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-06 (Mon, 12 December 2021) +02:00

Changed paths: 
A tests/data/parser/parseWithStatement.in
A tests/data/parser/parseWithStatement.out
A tests/data/parser/parseWithStatement2.in
A tests/data/parser/parseWithStatement2.out
A tests/data/parser/parseWithStatement3.in
A tests/data/parser/parseWithStatement3.out
M src/Statements/CreateStatement.php
M src/Statements/InsertStatement.php
M src/Statements/WithStatement.php
M tests/Builder/CreateStatementTest.php
M tests/Parser/WithStatementTest.php
M tests/data/parser/parseCreateViewAsWithAs.out

Log Message:
-----------
Refactoring and improving the support of the WITH statement and making other statements aware of it

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: 835a537d485a24bfd9b377728b500890caa3f51f
https://github.com/phpmyadmin/sql-parser/commit/835a537d485a24bfd9b377728b500890caa3f51f
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-06 (Mon, 12 December 2021) +02:00

Changed paths: 
A tests/data/parser/parseWithStatement1.in
A tests/data/parser/parseWithStatement1.out
A tests/data/parser/parseWithStatementErr.in
A tests/data/parser/parseWithStatementErr.out
A tests/data/parser/parseWithStatementErr1.in
A tests/data/parser/parseWithStatementErr1.out
A tests/data/parser/parseWithStatementErr2.in
A tests/data/parser/parseWithStatementErr2.out
A tests/data/parser/parseWithStatementErr3.in
A tests/data/parser/parseWithStatementErr3.out
A tests/data/parser/parseWithStatementErr4.in
A tests/data/parser/parseWithStatementErr4.out
A tests/data/parser/parseWithStatementErr5.in
A tests/data/parser/parseWithStatementErr5.out
A tests/data/parser/parseWithStatementErr6.in
A tests/data/parser/parseWithStatementErr6.out
M src/Statements/CreateStatement.php
M src/Statements/WithStatement.php
M tests/Parser/WithStatementTest.php
M tests/data/parser/parseWithStatement2.in
M tests/data/parser/parseWithStatement2.out
M tests/data/parser/parseWithStatement3.in
M tests/data/parser/parseWithStatement3.out

Log Message:
-----------
Adding more test cases for withStatements

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: 75436a9e3458d3dd0c7394545cb4441a7bfb0f67
https://github.com/phpmyadmin/sql-parser/commit/75436a9e3458d3dd0c7394545cb4441a7bfb0f67
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-06 (Mon, 12 December 2021) +02:00

Changed paths: 
M src/Statements/CreateStatement.php
M src/Statements/InsertStatement.php
M src/Statements/WithStatement.php
M tests/Builder/CreateStatementTest.php
M tests/Parser/WithStatementTest.php
M tests/data/parser/parseWithStatement.out
M tests/data/parser/parseWithStatement2.out
M tests/data/parser/parseWithStatementErr.out
M tests/data/parser/parseWithStatementErr3.out
M tests/data/parser/parseWithStatementErr5.out
M tests/data/parser/parseWithStatementErr6.out

Log Message:
-----------
Fixing phpstan issues, and adding more test cases

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: 29611305a4cced9415720216817b3fcc65de5b1a
https://github.com/phpmyadmin/sql-parser/commit/29611305a4cced9415720216817b3fcc65de5b1a
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-06 (Mon, 12 December 2021) +02:00

Changed paths: 
A tests/data/parser/parseWithStatement4.in
A tests/data/parser/parseWithStatement4.out
A tests/data/parser/parseWithStatement5.in
A tests/data/parser/parseWithStatement5.out
A tests/data/parser/parseWithStatement6.in
A tests/data/parser/parseWithStatement6.out
M tests/Builder/CreateStatementTest.php
M tests/Parser/WithStatementTest.php

Log Message:
-----------
Adding more tests for withStatements

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: 85a6461ed722acfcb8e2f70eb7e2c992282b24f6
https://github.com/phpmyadmin/sql-parser/commit/85a6461ed722acfcb8e2f70eb7e2c992282b24f6
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-06 (Mon, 12 December 2021) +02:00

Changed paths: 
M src/Statements/WithStatement.php
M tests/data/parser/parseWithStatement4.out
M tests/data/parser/parseWithStatementErr.out
M tests/data/parser/parseWithStatementErr1.out
M tests/data/parser/parseWithStatementErr2.out
M tests/data/parser/parseWithStatementErr3.out
M tests/data/parser/parseWithStatementErr4.out
M tests/data/parser/parseWithStatementErr5.out
M tests/data/parser/parseWithStatementErr6.out

Log Message:
-----------
Improve types for Psalm and error's message improvement

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: f5269d7ff85e5ba689f60ef85983fef2aed616d6
https://github.com/phpmyadmin/sql-parser/commit/f5269d7ff85e5ba689f60ef85983fef2aed616d6
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-06 (Mon, 12 December 2021) +02:00

Changed paths: 
A tests/data/parser/parseWithStatementErr7.in
A tests/data/parser/parseWithStatementErr7.out
A tests/data/parser/parseWithStatementErr8.in
A tests/data/parser/parseWithStatementErr8.out
M tests/Parser/WithStatementTest.php

Log Message:
-----------
Adding more test cases

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: 3516c9403e20628199dc13dc5245ca29e1bb447d
https://github.com/phpmyadmin/sql-parser/commit/3516c9403e20628199dc13dc5245ca29e1bb447d
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-06 (Mon, 12 December 2021) +02:00

Changed paths: 
M tests/Builder/CreateStatementTest.php

Log Message:
-----------
Uncommenting tests

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: 199ba667074430e2f4a66a77a74b67250b36c878
https://github.com/phpmyadmin/sql-parser/commit/199ba667074430e2f4a66a77a74b67250b36c878
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-06 (Mon, 12 December 2021) +02:00

Changed paths: 
M src/Statements/WithStatement.php

Log Message:
-----------
updating comments

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: cd49677a17e807f2a8c244025e183c21a7603c92
https://github.com/phpmyadmin/sql-parser/commit/cd49677a17e807f2a8c244025e183c21a7603c92
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-06 (Mon, 12 December 2021) +02:00

Changed paths: 
A tests/data/parser/parseWithStatement7.in
A tests/data/parser/parseWithStatement7.out
M src/Statements/WithStatement.php
M tests/Parser/WithStatementTest.php

Log Message:
-----------
Explicitly check ON DUPLICATE KEY UPDATE and adding a test case

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: f1585a9dc8671e8e5eb90b7addf0482c0db50dc6
https://github.com/phpmyadmin/sql-parser/commit/f1585a9dc8671e8e5eb90b7addf0482c0db50dc6
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-07 (Tue, 12 December 2021) +02:00

Changed paths: 
M src/Statements/WithStatement.php
M tests/Builder/CreateStatementTest.php
M tests/Parser/WithStatementTest.php
M tests/data/parser/parseCreateViewAsWithAs.out
M tests/data/parser/parseWithStatement.out
M tests/data/parser/parseWithStatement1.out
M tests/data/parser/parseWithStatement2.out
M tests/data/parser/parseWithStatement3.out
M tests/data/parser/parseWithStatement4.out
M tests/data/parser/parseWithStatement5.out
M tests/data/parser/parseWithStatement7.out
M tests/data/parser/parseWithStatementErr.out
M tests/data/parser/parseWithStatementErr1.out
M tests/data/parser/parseWithStatementErr2.out
M tests/data/parser/parseWithStatementErr3.out
M tests/data/parser/parseWithStatementErr4.out
M tests/data/parser/parseWithStatementErr5.out
M tests/data/parser/parseWithStatementErr6.out
M tests/data/parser/parseWithStatementErr7.out
M tests/data/parser/parseWithStatementErr8.out

Log Message:
-----------
Update the with Build statement to build the cteStatement

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: bd86fb3c6989c11062155a58abd273bed8ff1d51
https://github.com/phpmyadmin/sql-parser/commit/bd86fb3c6989c11062155a58abd273bed8ff1d51
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-07 (Tue, 12 December 2021) +02:00

Changed paths: 
M src/Statements/WithStatement.php

Log Message:
-----------
handle: cteStatementParser could be null

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: c8f72ec53193e416eaf3344ce5c4114cc842ba5d
https://github.com/phpmyadmin/sql-parser/commit/c8f72ec53193e416eaf3344ce5c4114cc842ba5d
Author: Fawzi E. Abdulfattah <iifawzie at gmail.com>
Date: 2021-12-11 (Sat, 12 December 2021) +02:00

Changed paths: 
M tests/Builder/CreateStatementTest.php

Log Message:
-----------
remove duplicated test

Signed-off-by: Fawzi E. Abdulfattah <iifawzie at gmail.com>

Commit: 403e38d78337abd73117e5074d12d25b356a63a1
https://github.com/phpmyadmin/sql-parser/commit/403e38d78337abd73117e5074d12d25b356a63a1
Author: Maurício Meneghini Fauth <mauricio at fauth.dev>
Date: 2021-12-29 (Wed, 12 December 2021) -03:00

Changed paths: 
A tests/data/parser/parseWithStatement.in
A tests/data/parser/parseWithStatement.out
A tests/data/parser/parseWithStatement1.in
A tests/data/parser/parseWithStatement1.out
A tests/data/parser/parseWithStatement2.in
A tests/data/parser/parseWithStatement2.out
A tests/data/parser/parseWithStatement3.in
A tests/data/parser/parseWithStatement3.out
A tests/data/parser/parseWithStatement4.in
A tests/data/parser/parseWithStatement4.out
A tests/data/parser/parseWithStatement5.in
A tests/data/parser/parseWithStatement5.out
A tests/data/parser/parseWithStatement6.in
A tests/data/parser/parseWithStatement6.out
A tests/data/parser/parseWithStatement7.in
A tests/data/parser/parseWithStatement7.out
A tests/data/parser/parseWithStatementErr.in
A tests/data/parser/parseWithStatementErr.out
A tests/data/parser/parseWithStatementErr1.in
A tests/data/parser/parseWithStatementErr1.out
A tests/data/parser/parseWithStatementErr2.in
A tests/data/parser/parseWithStatementErr2.out
A tests/data/parser/parseWithStatementErr3.in
A tests/data/parser/parseWithStatementErr3.out
A tests/data/parser/parseWithStatementErr4.in
A tests/data/parser/parseWithStatementErr4.out
A tests/data/parser/parseWithStatementErr5.in
A tests/data/parser/parseWithStatementErr5.out
A tests/data/parser/parseWithStatementErr6.in
A tests/data/parser/parseWithStatementErr6.out
A tests/data/parser/parseWithStatementErr7.in
A tests/data/parser/parseWithStatementErr7.out
A tests/data/parser/parseWithStatementErr8.in
A tests/data/parser/parseWithStatementErr8.out
M src/Statements/CreateStatement.php
M src/Statements/InsertStatement.php
M src/Statements/WithStatement.php
M tests/Builder/CreateStatementTest.php
M tests/Parser/WithStatementTest.php
M tests/data/parser/parseCreateViewAsWithAs.out

Log Message:
-----------
Merge pull request #363 from iifawzi/support-with-statements

Completing, refactoring and improving the `WITH` statements parser



More information about the Git mailing list