[phpMyAdmin Git] [phpmyadmin/phpmyadmin] debb6a: Move html from server/select to template

Daniel Tiringer tiringerdaniel at gmail.com
Fri May 7 18:01:38 CEST 2021


Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: debb6af80f33544dd222b917b9fb69ea4decd239
https://github.com/phpmyadmin/phpmyadmin/commit/debb6af80f33544dd222b917b9fb69ea4decd239
Author: Daniel Tiringer <tiringerdaniel at gmail.com>
Date: 2021-05-05 (Wed, 05 May 2021) +02:00

Changed paths: 
A templates/server/select/index.twig
A templates/server/select/server_options.twig
M libraries/classes/Server/Select.php
M test/classes/Server/SelectTest.php

Log Message:
-----------
Move html from server/select to template

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Factor out logic from server listing

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Create the base twig skeleton

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Insert template and variables to form part

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Insert list view template part

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Insert just options fork

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Factor out repeating code into server_options template

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Render the template

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Comment out test parts that don't work due to translate

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Fix the typos in the translatable elements

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Refactor the test into separate scenarios

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Remove indentation spaces

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Codesniffer cleanup

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Add test for fieldset existence

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Code style fixes

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Reorder lines in test

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Replace include function with tag

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Removing the escape calls

Signed-off-by: Daniel Tiringer <tiringerdaniel at tutanota.com>

Commit: 06b01ac63fcdd6246f8966ec5c1191e8cf4bbeb4
https://github.com/phpmyadmin/phpmyadmin/commit/06b01ac63fcdd6246f8966ec5c1191e8cf4bbeb4
Author: MaurĂ­cio Meneghini Fauth <mauricio at fauth.dev>
Date: 2021-05-07 (Fri, 05 May 2021) -03:00

Changed paths: 
A templates/server/select/index.twig
A templates/server/select/server_options.twig
M libraries/classes/Server/Select.php
M test/classes/Server/SelectTest.php

Log Message:
-----------
Merge pull request #16875 from danielTiringer/14801-extract-server-select-html-to-twig

Extract Server/Select HTML to Twig



More information about the Git mailing list