[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 5c8a4e: Remove pass-by-ref

Kamil Tekiela tekiela246 at gmail.com
Sun Apr 10 16:44:38 CEST 2022 

Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 5c8a4e90a063c28f44033a1bdb7c4b5e2ecc835a
https://github.com/phpmyadmin/phpmyadmin/commit/5c8a4e90a063c28f44033a1bdb7c4b5e2ecc835a
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Import.php
M libraries/classes/Plugins/Import/ImportXml.php

Log Message:
-----------
Remove pass-by-ref

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 06e4c77f64e1ed00a769a350538cb51a79a1c610
https://github.com/phpmyadmin/phpmyadmin/commit/06e4c77f64e1ed00a769a350538cb51a79a1c610
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Import.php

Log Message:
-----------
Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: b3759ba7e4d428a99248dcaccd8c8c156d129651
https://github.com/phpmyadmin/phpmyadmin/commit/b3759ba7e4d428a99248dcaccd8c8c156d129651
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Plugins/Import/ImportSql.php

Log Message:
-----------
Remove count()

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 0def6a56fcfb0d2652aeb231f782eeb998407ecf
https://github.com/phpmyadmin/phpmyadmin/commit/0def6a56fcfb0d2652aeb231f782eeb998407ecf
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Import.php

Log Message:
-----------
Remove boolean use of strcmp()

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: a09fa965a43d588167d637a9e569a5372650ff66
https://github.com/phpmyadmin/phpmyadmin/commit/a09fa965a43d588167d637a9e569a5372650ff66
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Import.php

Log Message:
-----------
Refactor the for loop

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 69b5e5e1590cdb00c2ec8c5798da337dd83d51f0
https://github.com/phpmyadmin/phpmyadmin/commit/69b5e5e1590cdb00c2ec8c5798da337dd83d51f0
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Import.php

Log Message:
-----------
Fix phpdoc types

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 009a92c545bd17dc9fd414bf6a2fb498501877db
https://github.com/phpmyadmin/phpmyadmin/commit/009a92c545bd17dc9fd414bf6a2fb498501877db
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Plugins/Import/ImportSql.php

Log Message:
-----------
Set parameter type

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: ad0acda8b2af9e47dccc0d2f83f2131312e7aab1
https://github.com/phpmyadmin/phpmyadmin/commit/ad0acda8b2af9e47dccc0d2f83f2131312e7aab1
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Import.php
M libraries/classes/Plugins/Import/ImportCsv.php
M libraries/classes/Plugins/Import/ImportLdi.php
M libraries/classes/Plugins/Import/ImportMediawiki.php
M libraries/classes/Plugins/Import/ImportOds.php
M libraries/classes/Plugins/Import/ImportShp.php
M libraries/classes/Plugins/Import/ImportSql.php
M libraries/classes/Plugins/Import/ImportXml.php
M test/classes/ImportTest.php

Log Message:
-----------
Remove  parameter

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: ade85420a80633047e26205182f99aabda0c5a4c
https://github.com/phpmyadmin/phpmyadmin/commit/ade85420a80633047e26205182f99aabda0c5a4c
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Import.php
M psalm.xml
M test/classes/Controllers/Import/ImportControllerTest.php
M test/classes/ImportTest.php
M test/classes/Plugins/Import/ImportCsvTest.php
M test/classes/Plugins/Import/ImportLdiTest.php
M test/classes/Plugins/Import/ImportMediawikiTest.php
M test/classes/Plugins/Import/ImportOdsTest.php
M test/classes/Plugins/Import/ImportShpTest.php
M test/classes/Plugins/Import/ImportSqlTest.php
M test/classes/Plugins/Import/ImportXmlTest.php

Log Message:
-----------
Inline runQueryPost()

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

import

Commit: c2edf8534c50454ab2e04fd3bb52457397bffe59
https://github.com/phpmyadmin/phpmyadmin/commit/c2edf8534c50454ab2e04fd3bb52457397bffe59
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Plugins/Import/ImportSql.php

Log Message:
-----------
Change empty for stricter comparison

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: ff4614d581f00419b969a4e8d02393b4d2ca1bd6
https://github.com/phpmyadmin/phpmyadmin/commit/ff4614d581f00419b969a4e8d02393b4d2ca1bd6
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Import.php

Log Message:
-----------
Use null-coalesce

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: d043ceedc638b140fce80098d78b453a9e600232
https://github.com/phpmyadmin/phpmyadmin/commit/d043ceedc638b140fce80098d78b453a9e600232
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Controllers/Import/ImportController.php
M libraries/classes/Controllers/Sql/SqlController.php
M libraries/classes/Import.php
M libraries/classes/Plugins/Import/ImportCsv.php
M libraries/classes/Plugins/Import/ImportLdi.php
M libraries/classes/Plugins/Import/ImportMediawiki.php
M libraries/classes/Plugins/Import/ImportOds.php
M libraries/classes/Plugins/Import/ImportShp.php
M libraries/classes/Plugins/Import/ImportSql.php
M libraries/classes/Plugins/Import/ImportXml.php
M libraries/classes/Plugins/Import/README.md
M libraries/classes/Plugins/ImportPlugin.php
M test/classes/ImportTest.php

Log Message:
-----------
Refactor $sql_data

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 9469fd9eebe25fdfe0931a36edd388e91dc0dffc
https://github.com/phpmyadmin/phpmyadmin/commit/9469fd9eebe25fdfe0931a36edd388e91dc0dffc
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Import.php

Log Message:
-----------
Remove redundant if statement with elseif

The string even when trimmed will never be empty. Checking for "0" string makes no sense in my opinion and null is an impossible value (despite PHPStan not recognizing it).

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 8e367a2c9c78840cc3450f86731b2d5643ea229a
https://github.com/phpmyadmin/phpmyadmin/commit/8e367a2c9c78840cc3450f86731b2d5643ea229a
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M libraries/classes/Plugins/Import/ImportCsv.php
M libraries/classes/Plugins/Import/ImportLdi.php
M libraries/classes/Plugins/Import/ImportMediawiki.php
M libraries/classes/Plugins/Import/ImportOds.php
M libraries/classes/Plugins/Import/ImportShp.php
M libraries/classes/Plugins/Import/ImportSql.php
M libraries/classes/Plugins/Import/ImportXml.php
M libraries/classes/Plugins/ImportPlugin.php
M phpstan-baseline.neon

Log Message:
-----------
Update phpstan-baseline.neon

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 6181dca1c0965473292651fe84c034d9de56624c
https://github.com/phpmyadmin/phpmyadmin/commit/6181dca1c0965473292651fe84c034d9de56624c
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-03-17 (Thu, 03 March 2022) +00:00

Changed paths: 
M psalm-baseline.xml

Log Message:
-----------
Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 06909939b0984d1117b5c132c58396131646a662
https://github.com/phpmyadmin/phpmyadmin/commit/06909939b0984d1117b5c132c58396131646a662
Author: Maurício Meneghini Fauth <mauricio at fauth.dev>
Date: 2022-04-10 (Sun, 04 April 2022) -03:00

Changed paths: 
M libraries/classes/Controllers/Import/ImportController.php
M libraries/classes/Controllers/Sql/SqlController.php
M libraries/classes/Import.php
M libraries/classes/Plugins/Import/ImportCsv.php
M libraries/classes/Plugins/Import/ImportLdi.php
M libraries/classes/Plugins/Import/ImportMediawiki.php
M libraries/classes/Plugins/Import/ImportOds.php
M libraries/classes/Plugins/Import/ImportShp.php
M libraries/classes/Plugins/Import/ImportSql.php
M libraries/classes/Plugins/Import/ImportXml.php
M libraries/classes/Plugins/Import/README.md
M libraries/classes/Plugins/ImportPlugin.php
M phpstan-baseline.neon
M psalm-baseline.xml
M psalm.xml
M test/classes/Controllers/Import/ImportControllerTest.php
M test/classes/ImportTest.php
M test/classes/Plugins/Import/ImportCsvTest.php
M test/classes/Plugins/Import/ImportLdiTest.php
M test/classes/Plugins/Import/ImportMediawikiTest.php
M test/classes/Plugins/Import/ImportOdsTest.php
M test/classes/Plugins/Import/ImportShpTest.php
M test/classes/Plugins/Import/ImportSqlTest.php
M test/classes/Plugins/Import/ImportXmlTest.php

Log Message:
-----------
Merge pull request #17444 from kamil-tekiela/Refactor-importSQL

Refactor import sql

More information about the Git mailing list