[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 6264f6: Various refactorings 2 (#17965)

[Kamil Tekiela]

Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 6264f6f1eada7f500780226c921cf74c00b2563e
https://github.com/phpmyadmin/phpmyadmin/commit/6264f6f1eada7f500780226c921cf74c00b2563e
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-12-24 (Sat, 12 December 2022) -03:00

Changed paths: 
M libraries/classes/Advisory/Advisor.php
M libraries/classes/BrowseForeigners.php
M libraries/classes/Config.php
M libraries/classes/Controllers/Import/ImportController.php
M libraries/classes/Controllers/Preferences/ManageController.php
M libraries/classes/Controllers/Table/RelationController.php
M libraries/classes/Controllers/Table/Structure/PartitioningController.php
M libraries/classes/Controllers/Table/ZoomSearchController.php
M libraries/classes/Core.php
M libraries/classes/Database/CentralColumns.php
M libraries/classes/Database/Qbe.php
M libraries/classes/DatabaseInterface.php
M libraries/classes/Display/Results.php
M libraries/classes/Export.php
M libraries/classes/FieldMetadata.php
M libraries/classes/Header.php
M libraries/classes/Html/Generator.php
M libraries/classes/Import.php
M libraries/classes/Index.php
M libraries/classes/InsertEdit.php
M libraries/classes/IpAllowDeny.php
M libraries/classes/Message.php
M libraries/classes/Operations.php
M libraries/classes/Partitioning/TablePartitionDefinition.php
M libraries/classes/Plugins/Export/ExportCodegen.php
M libraries/classes/Plugins/Export/ExportSql.php
M libraries/classes/Plugins/Import/ImportMediawiki.php
M libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php
M libraries/classes/ReplicationGui.php
M libraries/classes/Sanitize.php
M libraries/classes/Server/Privileges.php
M libraries/classes/Sql.php
M libraries/classes/StorageEngine.php
M libraries/classes/Table.php
M libraries/classes/Types.php
M libraries/classes/Util.php
M libraries/classes/Utils/Gis.php
M libraries/classes/ZipExtension.php
M phpstan-baseline.neon
M psalm-baseline.xml
M test/classes/Advisory/AdvisorTest.php
M test/classes/Partitioning/TablePartitionDefinitionTest.php

Log Message:
-----------
Various refactorings 2 (#17965)

* Remove extra blank lines
* Remove useless param annotations
* Refactor Index::singleton
* Refactor Config.php
* Refactor Header::addRecentTable()
* Collapse return statement into a single line
* Refactor Message.php
* Convert $getUniqueCondition into a scalar
* Code style
* Fix invalid return phpdoc
* Remove unused variable
* Remove redundant empty array checks
* Refactor Export::closeFile()
* Simplify else statement
* Remove redundant else
* Refactor TablePartitionDefinition::getDetails
* Simpler returns
* Add types for getCellContent()
* Remove useless method mngInsideStructComm

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>