[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 9a34ec: Remove invalid condition

[Kamil Tekiela]

Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 9a34ec9fdfd1615ce264b599306231d747d53344
https://github.com/phpmyadmin/phpmyadmin/commit/9a34ec9fdfd1615ce264b599306231d747d53344
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Table/Search.php
M phpstan-baseline.neon

Log Message:
-----------
Remove invalid condition

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 84eba89cd2a8af9e531828c454a07a9c47a39168
https://github.com/phpmyadmin/phpmyadmin/commit/84eba89cd2a8af9e531828c454a07a9c47a39168
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Setup/Index.php

Log Message:
-----------
Remove pass-by-ref

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 01438e9d7a4c5b06a731709b4344a6304dfd8fdb
https://github.com/phpmyadmin/phpmyadmin/commit/01438e9d7a4c5b06a731709b4344a6304dfd8fdb
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/DatabaseInterface.php
M libraries/classes/Dbal/DbalInterface.php

Log Message:
-----------
Update docblocks for nullable parameters

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: a4cb49080a274b5d4fc016ef30bef22867b0e9e7
https://github.com/phpmyadmin/phpmyadmin/commit/a4cb49080a274b5d4fc016ef30bef22867b0e9e7
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/DatabaseInterface.php

Log Message:
-----------
Extract common part from if

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 415eb2c8d799b36fc35638c0a443a2519a2d4afd
https://github.com/phpmyadmin/phpmyadmin/commit/415eb2c8d799b36fc35638c0a443a2519a2d4afd
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/DatabaseInterface.php

Log Message:
-----------
Convert ternary to boolean expression

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: d5dbc316c035dfdd62b3e9dc92471cec49f7405e
https://github.com/phpmyadmin/phpmyadmin/commit/d5dbc316c035dfdd62b3e9dc92471cec49f7405e
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/DatabaseInterface.php

Log Message:
-----------
Remove matching default values

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 5883ca608ed4ce731881e84ca675af3374b9b771
https://github.com/phpmyadmin/phpmyadmin/commit/5883ca608ed4ce731881e84ca675af3374b9b771
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/DatabaseInterface.php
M libraries/classes/Dbal/DbalInterface.php

Log Message:
-----------
Add param and return type

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 146897658754c9d901e365b5876a0b94fe5daca8
https://github.com/phpmyadmin/phpmyadmin/commit/146897658754c9d901e365b5876a0b94fe5daca8
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Table/Search.php

Log Message:
-----------
Convert phpdoc to param type

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 4c22cf1f13d73701b127eec0c41a48a863d7f44b
https://github.com/phpmyadmin/phpmyadmin/commit/4c22cf1f13d73701b127eec0c41a48a863d7f44b
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/InsertEdit.php

Log Message:
-----------
Remove pass-by-ref

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: af4b8938b8dbb51a300a62bdf5f0d4ce38994aef
https://github.com/phpmyadmin/phpmyadmin/commit/af4b8938b8dbb51a300a62bdf5f0d4ce38994aef
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Display/Results.php

Log Message:
-----------
Collapse if statements into one

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: cf16a3c55a016b86da542d1ea6d0bb0fdfe8e661
https://github.com/phpmyadmin/phpmyadmin/commit/cf16a3c55a016b86da542d1ea6d0bb0fdfe8e661
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Display/Results.php

Log Message:
-----------
Remove redundant parentheses

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 75b5c3241c8175e23313cd3f97a067d8fa6b0453
https://github.com/phpmyadmin/phpmyadmin/commit/75b5c3241c8175e23313cd3f97a067d8fa6b0453
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Display/Results.php
M templates/display/results/table_navigation_button.twig

Log Message:
-----------
Remove optional $onclick parameter

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 0cd422954b01aa5bf43acc468a109e7d33da0859
https://github.com/phpmyadmin/phpmyadmin/commit/0cd422954b01aa5bf43acc468a109e7d33da0859
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Display/Results.php

Log Message:
-----------
Remove redundant arguments

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 6e8a04c4abe9f4cb89147a697514ec3067709b04
https://github.com/phpmyadmin/phpmyadmin/commit/6e8a04c4abe9f4cb89147a697514ec3067709b04
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Display/Results.php

Log Message:
-----------
Remove redundant condition

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 202b17c34c260b38357d83cd547ee3f51e8e3667
https://github.com/phpmyadmin/phpmyadmin/commit/202b17c34c260b38357d83cd547ee3f51e8e3667
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Controllers/Export/ExportController.php

Log Message:
-----------
Replace if with coalesce

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 9afa59487ea1df5972f12944387ea7a59eb44713
https://github.com/phpmyadmin/phpmyadmin/commit/9afa59487ea1df5972f12944387ea7a59eb44713
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Controllers/View/CreateController.php

Log Message:
-----------
Collapse if statements into one

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 73b7094b2bc37459bfb5b6b4f06975c115db1989
https://github.com/phpmyadmin/phpmyadmin/commit/73b7094b2bc37459bfb5b6b4f06975c115db1989
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-01-06 (Thu, 01 January 2022) +00:00

Changed paths: 
M libraries/classes/Controllers/Table/OperationsController.php

Log Message:
-----------
Remove redundant isset

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 24224f9c84c46d2a05c09c3e4f08a12f0f1f2049
https://github.com/phpmyadmin/phpmyadmin/commit/24224f9c84c46d2a05c09c3e4f08a12f0f1f2049
Author: Maurício Meneghini Fauth <mauricio at fauth.dev>
Date: 2022-01-06 (Thu, 01 January 2022) -03:00

Changed paths: 
M libraries/classes/Controllers/Export/ExportController.php
M libraries/classes/Controllers/Table/OperationsController.php
M libraries/classes/Controllers/View/CreateController.php
M libraries/classes/DatabaseInterface.php
M libraries/classes/Dbal/DbalInterface.php
M libraries/classes/Display/Results.php
M libraries/classes/InsertEdit.php
M libraries/classes/Setup/Index.php
M libraries/classes/Table/Search.php
M phpstan-baseline.neon
M templates/display/results/table_navigation_button.twig

Log Message:
-----------
Merge pull request #17269 from kamil-tekiela/autofix-1

A collection of small code refactorings