[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 4035ec: Make getJsValue use json_encode

Kamil Tekiela tekiela246 at gmail.com
Tue Oct 18 01:24:36 CEST 2022


Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 4035ec7e355af76d7720ec733ecc6b32d3ee6c66
https://github.com/phpmyadmin/phpmyadmin/commit/4035ec7e355af76d7720ec733ecc6b32d3ee6c66
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M libraries/classes/Sanitize.php
M phpstan-baseline.neon
M test/classes/SanitizeTest.php

Log Message:
-----------
Make getJsValue use json_encode

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 270ad693eb06f1294ba7582001e1a16e65ccff33
https://github.com/phpmyadmin/phpmyadmin/commit/270ad693eb06f1294ba7582001e1a16e65ccff33
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M libraries/classes/Config/FormDisplay.php
M libraries/classes/Header.php
M templates/config/form_display/display.twig

Log Message:
-----------
Replace uses of escapeJsString with json_encode

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: fd7b043cf3203b0196affdafb9b9015e1b3fbb5d
https://github.com/phpmyadmin/phpmyadmin/commit/fd7b043cf3203b0196affdafb9b9015e1b3fbb5d
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M libraries/classes/Config/FormDisplayTemplate.php
M test/classes/Config/FormDisplayTemplateTest.php

Log Message:
-----------
Use json_encode in addJsValidate

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: f2a83311aef1b4294fa52b27edcc250b63d81fbb
https://github.com/phpmyadmin/phpmyadmin/commit/f2a83311aef1b4294fa52b27edcc250b63d81fbb
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M libraries/classes/Controllers/Table/ChangeController.php
M libraries/classes/InsertEdit.php
M test/classes/Controllers/Table/ChangeControllerTest.php
M test/classes/InsertEditTest.php

Log Message:
-----------
Simplify onchange in InsertEdit.php

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: c9e6767850677845381dd653b61030c460a56959
https://github.com/phpmyadmin/phpmyadmin/commit/c9e6767850677845381dd653b61030c460a56959
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M libraries/classes/Html/Generator.php

Log Message:
-----------
Refactor linkOrButton

Warning: there are no tests and this part seems to be unused.
Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 3c0281ce4132f220c41a1ccc3710676dc96c624e
https://github.com/phpmyadmin/phpmyadmin/commit/3c0281ce4132f220c41a1ccc3710676dc96c624e
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M libraries/classes/Tracking.php

Log Message:
-----------
Remove Sanitize::escapeJsString from Tracking

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 2c1c873220ba8ca074c4d1a18151171c85206142
https://github.com/phpmyadmin/phpmyadmin/commit/2c1c873220ba8ca074c4d1a18151171c85206142
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M libraries/classes/UrlRedirector.php
M templates/javascript/redirect.twig

Log Message:
-----------
Use json_encode in javascript/redirect

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 48e3f7f882c2bea8fd8448029bef49d255461c42
https://github.com/phpmyadmin/phpmyadmin/commit/48e3f7f882c2bea8fd8448029bef49d255461c42
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M templates/header_location.twig
M templates/import/javascript.twig
M templates/scripts.twig

Log Message:
-----------
Use Twig's JS escaping

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: bd287cf79e09a56fba121cdf69edb799b74116d0
https://github.com/phpmyadmin/phpmyadmin/commit/bd287cf79e09a56fba121cdf69edb799b74116d0
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M libraries/classes/Twig/SanitizeExtension.php
M templates/table/insert/column_row.twig

Log Message:
-----------
Remove custom Twig escape_js_string filter

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: f835485588cbfcec0e1c4d12bc8ef20c9dfff4ce
https://github.com/phpmyadmin/phpmyadmin/commit/f835485588cbfcec0e1c4d12bc8ef20c9dfff4ce
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M libraries/classes/Plugins/Transformations/Abs/DateFormatTransformationsPlugin.php
M libraries/classes/Sanitize.php
M libraries/classes/Twig/SanitizeExtension.php
M phpstan-baseline.neon
M templates/import/javascript.twig
M test/classes/CoreTest.php
M test/classes/Plugins/Transformations/TransformationPluginsTest.php
M test/classes/SanitizeTest.php

Log Message:
-----------
Remove remaining bits of Sanitize::jsFormat

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 93d19942245f287648f73d0c45599350c87db677
https://github.com/phpmyadmin/phpmyadmin/commit/93d19942245f287648f73d0c45599350c87db677
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M psalm-baseline.xml

Log Message:
-----------
Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 3cc128b47cd12a90903b465b2939fc9c6ee922c7
https://github.com/phpmyadmin/phpmyadmin/commit/3cc128b47cd12a90903b465b2939fc9c6ee922c7
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M templates/header_location.twig
M templates/import/javascript.twig
M templates/javascript/redirect.twig
M templates/scripts.twig
M templates/table/insert/column_row.twig

Log Message:
-----------
e('js') to escape('js')

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 7ca71c79df41b9cc9ac96e133cbb7a31b7b2a297
https://github.com/phpmyadmin/phpmyadmin/commit/7ca71c79df41b9cc9ac96e133cbb7a31b7b2a297
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2022-10-17 (Mon, 10 October 2022) +01:00

Changed paths: 
M phpstan-baseline.neon

Log Message:
-----------
Update phpstan-baseline.neon

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 02161370941332d3ceff1c6462be4e5a8d5e6b4a
https://github.com/phpmyadmin/phpmyadmin/commit/02161370941332d3ceff1c6462be4e5a8d5e6b4a
Author: Maurício Meneghini Fauth <mauricio at fauth.dev>
Date: 2022-10-17 (Mon, 10 October 2022) -03:00

Changed paths: 
M libraries/classes/Config/FormDisplay.php
M libraries/classes/Config/FormDisplayTemplate.php
M libraries/classes/Controllers/Table/ChangeController.php
M libraries/classes/Header.php
M libraries/classes/Html/Generator.php
M libraries/classes/InsertEdit.php
M libraries/classes/Plugins/Transformations/Abs/DateFormatTransformationsPlugin.php
M libraries/classes/Sanitize.php
M libraries/classes/Tracking.php
M libraries/classes/Twig/SanitizeExtension.php
M libraries/classes/UrlRedirector.php
M phpstan-baseline.neon
M psalm-baseline.xml
M templates/config/form_display/display.twig
M templates/header_location.twig
M templates/import/javascript.twig
M templates/javascript/redirect.twig
M templates/scripts.twig
M templates/table/insert/column_row.twig
M test/classes/Config/FormDisplayTemplateTest.php
M test/classes/Controllers/Table/ChangeControllerTest.php
M test/classes/CoreTest.php
M test/classes/InsertEditTest.php
M test/classes/Plugins/Transformations/TransformationPluginsTest.php
M test/classes/SanitizeTest.php

Log Message:
-----------
Merge pull request #17799 from kamil-tekiela/js-escaping

Refactor JS escaping mechanism



More information about the Git mailing list