[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 5b6596: Fix for #18060 Console height "Not a non-negative number" error

Tue Apr 11 20:48:06 CEST 2023

Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 5b6596994062bf636c329a8565fe553965e1d5c9
https://github.com/phpmyadmin/phpmyadmin/commit/5b6596994062bf636c329a8565fe553965e1d5c9
Author: Ajmal Hassan <iamajmalhassan at gmail.com>
Date: 2023-02-07 (Tue, 02 February 2023) +05:30

Changed paths: 
M js/src/console.js

Log Message:
-----------
Fix for #18060 Console height "Not a non-negative number" error

Passed the height through Math.round() function before it gets stored in the session.

Signed-off-by: Ajmal Hassan <iamajmalhassan at gmail.com>

Commit: 89bcefeadb5b3c5ef2e71fd8adc1824df82d5096
https://github.com/phpmyadmin/phpmyadmin/commit/89bcefeadb5b3c5ef2e71fd8adc1824df82d5096
Author: Maximilian Krög <maxi_kroeg at web.de>
Date: 2023-03-01 (Wed, 03 March 2023) +01:00

Changed paths: 
M libraries/classes/InsertEdit.php
M test/classes/InsertEditTest.php

Log Message:
-----------
Fix inserting gis-data via insert/edit form

Signed-off-by: Maximilian Krög <maxi_kroeg at web.de>

Commit: 1477c34c0696489615b5b586a33323b28f8572df
https://github.com/phpmyadmin/phpmyadmin/commit/1477c34c0696489615b5b586a33323b28f8572df
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2023-04-05 (Wed, 04 April 2023) +01:00

Changed paths: 
M templates/table/tracking/main.twig

Log Message:
-----------
Remove float-end class

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: e0dc51563870273a5ab3dcf97a39d9098f0f6603
https://github.com/phpmyadmin/phpmyadmin/commit/e0dc51563870273a5ab3dcf97a39d9098f0f6603
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-05 (Wed, 04 April 2023) +02:00

Changed paths: 
M phpstan-baseline.neon
M psalm-baseline.xml
M test/classes/ConfigStorage/RelationTest.php

Log Message:
-----------
Add tests for #18266 - unable to disable a feature

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 5a0ecbf3462d61100ec36015d45cc49b27db50a6
https://github.com/phpmyadmin/phpmyadmin/commit/5a0ecbf3462d61100ec36015d45cc49b27db50a6
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M templates/table/tracking/main.twig

Log Message:
-----------
Merge #18324 - [UI] Remove float-end class on tracking versions table

Pull-request: #18324

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 83a5f352cbffb277d307130be190c2072ced29e5
https://github.com/phpmyadmin/phpmyadmin/commit/83a5f352cbffb277d307130be190c2072ced29e5
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M ChangeLog

Log Message:
-----------
Add a ChangeLog entry for 5a0ecbf346

Ref: 5a0ecbf3462d61100ec36015d45cc49b27db50a6

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: cf78e7ef336b9c4a70adaa17e14039c699f4d11e
https://github.com/phpmyadmin/phpmyadmin/commit/cf78e7ef336b9c4a70adaa17e14039c699f4d11e
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M ChangeLog

Log Message:
-----------
Add a ChangeLog entry for #18266

Ref: #18266
Pull-request: #18319

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: cdc48b36d16390c67bd05d9d167190750e2e34b2
https://github.com/phpmyadmin/phpmyadmin/commit/cdc48b36d16390c67bd05d9d167190750e2e34b2
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M ChangeLog

Log Message:
-----------
Add ChangeLog entries for ee9c9a0300, #18235 and #18249

Ref: ee9c9a03002e5e659d345b725173bd1e05b619d3
Pull-request: #18245
Pull-request: #18281

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: e64b59dbf8ee83dc69d7fa8ee038091d184aad3f
https://github.com/phpmyadmin/phpmyadmin/commit/e64b59dbf8ee83dc69d7fa8ee038091d184aad3f
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M js/src/console.js

Log Message:
-----------
Merge #18072 - Fix #18060 - Console height "Not a non-negative number" error

Fixes: #18060
Pull-request: #18072

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 2adb45e345062352baf7a154771f2394db97558d
https://github.com/phpmyadmin/phpmyadmin/commit/2adb45e345062352baf7a154771f2394db97558d
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M ChangeLog

Log Message:
-----------
Add a ChangeLog entry for #18060

Ref: #18060
Pull-request: #18072

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: e5826048d8e97ce166bf138af6e2e9891b0fec36
https://github.com/phpmyadmin/phpmyadmin/commit/e5826048d8e97ce166bf138af6e2e9891b0fec36
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M js/src/codemirror/addon/lint/sql-lint.js

Log Message:
-----------
Fix /lint request, request as ajax_request=true

Or failed requests will do `Failed to parse JSON: Unexpected token '<', "<!doctype "... is not valid JSON`

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 4b90c55337d18e38b23f1700412ef619faa95b04
https://github.com/phpmyadmin/phpmyadmin/commit/4b90c55337d18e38b23f1700412ef619faa95b04
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M js/src/database/events.js
M js/src/database/routines.js
M js/src/database/triggers.js

Log Message:
-----------
Fix width/height of create routines modal(dialog) and width of routines/triggers/events modals(dialogs)

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 182bf4333f5ad653642e8ab03fb6956ae74ba77f
https://github.com/phpmyadmin/phpmyadmin/commit/182bf4333f5ad653642e8ab03fb6956ae74ba77f
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M ChangeLog

Log Message:
-----------
Add a ChangeLog entry for 4b90c55337

Ref: 4b90c55337d18e38b23f1700412ef619faa95b04

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: b3138ff28222d1c544138f1c79e8d04cdde6ceb5
https://github.com/phpmyadmin/phpmyadmin/commit/b3138ff28222d1c544138f1c79e8d04cdde6ceb5
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M test/classes/ConfigStorage/RelationTest.php

Log Message:
-----------
Fix tests for relation

Ref: e0dc51563870273a5ab3dcf97a39d9098f0f6603

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 068fc4df7458d8715f5c65958cbfc7f21372e1d3
https://github.com/phpmyadmin/phpmyadmin/commit/068fc4df7458d8715f5c65958cbfc7f21372e1d3
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-07 (Fri, 04 April 2023) +02:00

Changed paths: 
M test/classes/VersionInformationTest.php

Log Message:
-----------
Fix failing testGetLatestVersion in random order

I could not reproduce it, but cleared the cache just in case

Random-order-seed: 1680865303

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 4cec0f1163fda71fb8013b510cd448161aee8def
https://github.com/phpmyadmin/phpmyadmin/commit/4cec0f1163fda71fb8013b510cd448161aee8def
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-08 (Sat, 04 April 2023) +02:00

Changed paths: 
M libraries/classes/ConfigStorage/Relation.php
M libraries/classes/Controllers/HomeController.php
M test/classes/ConfigStorage/RelationTest.php

Log Message:
-----------
Stop pmadb database detection when all features are disabled

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: de724d623e808ee1d7534b2c1ad96283f639e088
https://github.com/phpmyadmin/phpmyadmin/commit/de724d623e808ee1d7534b2c1ad96283f639e088
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-08 (Sat, 04 April 2023) +02:00

Changed paths: 
M psalm-baseline.xml

Log Message:
-----------
Update psalm baseline

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: 2a7cf790d6e652b41222de753a2d8d6168925a80
https://github.com/phpmyadmin/phpmyadmin/commit/2a7cf790d6e652b41222de753a2d8d6168925a80
Author: William Desportes <williamdes at wdes.fr>
Date: 2023-04-08 (Sat, 04 April 2023) +02:00

Changed paths: 
M ChangeLog

Log Message:
-----------
Add a ChangeLog entry for 4cec0f1163

Ref: 4cec0f1163fda71fb8013b510cd448161aee8def

Signed-off-by: William Desportes <williamdes at wdes.fr>

Commit: d0997e0377c0064a1af60f4cf05c9889ddae7ab8
https://github.com/phpmyadmin/phpmyadmin/commit/d0997e0377c0064a1af60f4cf05c9889ddae7ab8
Author: Maurício Meneghini Fauth <mauricio at fauth.dev>
Date: 2023-04-08 (Sat, 04 April 2023) -03:00

Changed paths: 
M libraries/classes/InsertEdit.php
M test/classes/InsertEditTest.php

Log Message:
-----------
Merge pull request #18188 from MoonE/qa-fix-gis-insert-form

Fix inserting gis-data via insert/edit form

Commit: 0ff3f101343c207fa04d91b4921325ca4c04c7ef
https://github.com/phpmyadmin/phpmyadmin/commit/0ff3f101343c207fa04d91b4921325ca4c04c7ef
Author: MoonE <maxi_kroeg at web.de>
Date: 2023-04-08 (Sat, 04 April 2023) -03:00

Changed paths: 
A test/classes/Controllers/GisDataEditorControllerTest.php
M libraries/classes/Controllers/GisDataEditorController.php
M psalm-baseline.xml

Log Message:
-----------
Fix editing GEOMETRYCOLLECTION EMPTY (#18189)

* Test editing empty geometry collection

- 'GEOMETRYCOLLECTION()'
- 'GEOMETRYCOLLECTION EMPTY'

Signed-off-by: Maximilian Krög <maxi_kroeg at web.de>

* Fix editing GEOMETRYCOLLECTION EMPTY

Instead of searching for first parenthesis look for word end.
Parsing was and is somewhat unsafe, though it works with the data
received from ST_AsText.

Signed-off-by: Maximilian Krög <maxi_kroeg at web.de>

---------

Signed-off-by: Maximilian Krög <maxi_kroeg at web.de>

Commit: 022e7b509f53c1d2890e06aff7ccf1f0c2c2dd07
https://github.com/phpmyadmin/phpmyadmin/commit/022e7b509f53c1d2890e06aff7ccf1f0c2c2dd07
Author: Kristijan \"Fremen\" Velkovski <me at krisfremen.com>
Date: 2023-04-09 (Sun, 04 April 2023) +02:00

Changed paths: 
M po/mk.po

Log Message:
-----------
Translated using Weblate (Macedonian)

Currently translated at 26.6% (913 of 3427 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/
Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me at krisfremen.com>

Commit: 4b6c25762e99c72a649052e807b407dbc0b6d3fe
https://github.com/phpmyadmin/phpmyadmin/commit/4b6c25762e99c72a649052e807b407dbc0b6d3fe
Author: Meno25 <mfarag25 at gmail.com>
Date: 2023-04-09 (Sun, 04 April 2023) +02:00

Changed paths: 
M po/ar.po

Log Message:
-----------
Translated using Weblate (Arabic)

Currently translated at 48.7% (1669 of 3427 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/ar/
Signed-off-by: Meno25 <mfarag25 at gmail.com>

Commit: fedfdc3aa304cdb2833efc3e5ce695b5541d6627
https://github.com/phpmyadmin/phpmyadmin/commit/fedfdc3aa304cdb2833efc3e5ce695b5541d6627
Author: Deleted User <noreply+60134 at weblate.org>
Date: 2023-04-10 (Mon, 04 April 2023) +02:00

Changed paths: 
M po/ar.po

Log Message:
-----------
Translated using Weblate (Arabic)

Currently translated at 48.9% (1678 of 3427 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/ar/
Signed-off-by: Deleted User <noreply+60134 at weblate.org>

Commit: 1ec721d46cd33281f173f789e5b14d8098fec103
https://github.com/phpmyadmin/phpmyadmin/commit/1ec721d46cd33281f173f789e5b14d8098fec103
Author: Meno25 <meno25mail at gmail.com>
Date: 2023-04-10 (Mon, 04 April 2023) +02:00

Changed paths: 
M po/ar.po

Log Message:
-----------
Translated using Weblate (Arabic)

Currently translated at 48.9% (1678 of 3427 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/ar/
Signed-off-by: Meno25 <meno25mail at gmail.com>

Commit: 3117bf540064eae079a289f93dc55cfd6257588b
https://github.com/phpmyadmin/phpmyadmin/commit/3117bf540064eae079a289f93dc55cfd6257588b
Author: Meno25 <meno25mail at gmail.com>
Date: 2023-04-11 (Tue, 04 April 2023) +02:00

Changed paths: 
M po/ar.po

Log Message:
-----------
Translated using Weblate (Arabic)

Currently translated at 48.9% (1678 of 3427 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/ar/
Signed-off-by: Meno25 <meno25mail at gmail.com>

Commit: 85fa45ca32e03aeefee1a87fb8369b3e366704d3
https://github.com/phpmyadmin/phpmyadmin/commit/85fa45ca32e03aeefee1a87fb8369b3e366704d3
Author: Temuri Doghonadze <temuri.doghonadze at gmail.com>
Date: 2023-04-11 (Tue, 04 April 2023) +02:00

Changed paths: 
M po/ka.po

Log Message:
-----------
Translated using Weblate (Georgian)

Currently translated at 22.1% (759 of 3427 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/ka/
Signed-off-by: Temuri Doghonadze <temuri.doghonadze at gmail.com>

Commit: e104f66d97c5380cb2ddb1b7f94e92dfc814ede2
https://github.com/phpmyadmin/phpmyadmin/commit/e104f66d97c5380cb2ddb1b7f94e92dfc814ede2
Author: Maurício Meneghini Fauth <mauricio at fauth.dev>
Date: 2023-04-11 (Tue, 04 April 2023) -03:00

Changed paths: 
A test/classes/Controllers/GisDataEditorControllerTest.php
M ChangeLog
M js/src/codemirror/addon/lint/sql-lint.ts
M js/src/database/events.ts
M js/src/database/routines.ts
M js/src/database/triggers.ts
M js/src/modules/console.ts
M libraries/classes/ConfigStorage/Relation.php
M libraries/classes/Controllers/GisDataEditorController.php
M libraries/classes/Controllers/HomeController.php
M libraries/classes/InsertEdit.php
M phpstan-baseline.neon
M psalm-baseline.xml
M templates/table/tracking/main.twig
M test/classes/ConfigStorage/RelationTest.php
M test/classes/InsertEditTest.php
M test/classes/VersionInformationTest.php

Log Message:
-----------
Merge branch 'QA_5_2'

Signed-off-by: Maurício Meneghini Fauth <mauricio at fauth.dev>