[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 276577: Remove $GLOBALS['PMA_PHP_SELF'] (#18149)

Kamil Tekiela tekiela246 at gmail.com
Mon Feb 27 21:56:34 CET 2023


Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 276577ca2adebf31c1dd09e124f29e87790b5d59
https://github.com/phpmyadmin/phpmyadmin/commit/276577ca2adebf31c1dd09e124f29e87790b5d59
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2023-02-27 (Mon, 02 February 2023) -03:00

Changed paths: 
M libraries/classes/Common.php
M libraries/classes/Config.php
M libraries/classes/Controllers/AbstractController.php
M libraries/classes/Routing.php
M libraries/classes/Server/Status/Data.php
M libraries/classes/UserPreferences.php
M libraries/services.php
M phpstan-baseline.neon
M psalm-baseline.xml
M test/classes/AbstractTestCase.php
M test/classes/CommonTest.php
M test/classes/Config/PageSettingsTest.php
M test/classes/ConfigTest.php
M test/classes/Controllers/AbstractControllerTest.php
M test/classes/Controllers/CheckRelationsControllerTest.php
M test/classes/Controllers/Database/MultiTableQuery/TablesControllerTest.php
M test/classes/Controllers/Database/PrivilegesControllerTest.php
M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php
M test/classes/Controllers/Database/Structure/RealRowCountControllerTest.php
M test/classes/Controllers/Database/StructureControllerTest.php
M test/classes/Controllers/Export/ExportControllerTest.php
M test/classes/Controllers/Export/Template/CreateControllerTest.php
M test/classes/Controllers/Export/Template/DeleteControllerTest.php
M test/classes/Controllers/Export/Template/LoadControllerTest.php
M test/classes/Controllers/Export/Template/UpdateControllerTest.php
M test/classes/Controllers/Import/ImportControllerTest.php
M test/classes/Controllers/NavigationControllerTest.php
M test/classes/Controllers/Normalization/MainControllerTest.php
M test/classes/Controllers/Server/BinlogControllerTest.php
M test/classes/Controllers/Server/CollationsControllerTest.php
M test/classes/Controllers/Server/Databases/CreateControllerTest.php
M test/classes/Controllers/Server/Databases/DestroyControllerTest.php
M test/classes/Controllers/Server/DatabasesControllerTest.php
M test/classes/Controllers/Server/EnginesControllerTest.php
M test/classes/Controllers/Server/PluginsControllerTest.php
M test/classes/Controllers/Server/Privileges/AccountLockControllerTest.php
M test/classes/Controllers/Server/Privileges/AccountUnlockControllerTest.php
M test/classes/Controllers/Server/PrivilegesControllerTest.php
M test/classes/Controllers/Server/ShowEngineControllerTest.php
M test/classes/Controllers/Server/Status/AdvisorControllerTest.php
M test/classes/Controllers/Server/Status/Monitor/GeneralLogControllerTest.php
M test/classes/Controllers/Server/Status/Monitor/LogVarsControllerTest.php
M test/classes/Controllers/Server/Status/Monitor/QueryAnalyzerControllerTest.php
M test/classes/Controllers/Server/Status/Monitor/SlowLogControllerTest.php
M test/classes/Controllers/Server/Status/MonitorControllerTest.php
M test/classes/Controllers/Server/Status/Processes/RefreshControllerTest.php
M test/classes/Controllers/Server/Status/ProcessesControllerTest.php
M test/classes/Controllers/Server/Status/QueriesControllerTest.php
M test/classes/Controllers/Server/Status/StatusControllerTest.php
M test/classes/Controllers/Server/Status/VariablesControllerTest.php
M test/classes/Controllers/Server/VariablesControllerTest.php
M test/classes/Controllers/Sql/EnumValuesControllerTest.php
M test/classes/Controllers/Sql/SetValuesControllerTest.php
M test/classes/Controllers/Table/FindReplaceControllerTest.php
M test/classes/Controllers/Table/ImportControllerTest.php
M test/classes/Controllers/Table/IndexRenameControllerTest.php
M test/classes/Controllers/Table/IndexesControllerTest.php
M test/classes/Controllers/Table/OperationsControllerTest.php
M test/classes/Controllers/Table/PrivilegesControllerTest.php
M test/classes/Controllers/Table/RecentFavoriteControllerTest.php
M test/classes/Controllers/Table/RelationControllerTest.php
M test/classes/Controllers/Table/ReplaceControllerTest.php
M test/classes/Controllers/Table/SearchControllerTest.php
M test/classes/Controllers/Table/SqlControllerTest.php
M test/classes/Controllers/Table/Structure/ChangeControllerTest.php
M test/classes/Controllers/Table/Structure/SaveControllerTest.php
M test/classes/Controllers/Table/StructureControllerTest.php
M test/classes/Controllers/Table/TrackingControllerTest.php
M test/classes/Controllers/Table/TriggersControllerTest.php
M test/classes/Controllers/Table/ZoomSearchControllerTest.php
M test/classes/Controllers/Transformation/OverviewControllerTest.php
M test/classes/CoreTest.php
M test/classes/Database/EventsTest.php
M test/classes/Database/RoutinesTest.php
M test/classes/Database/TriggersTest.php
M test/classes/Display/ResultsTest.php
M test/classes/FooterTest.php
M test/classes/HeaderTest.php
M test/classes/InsertEditTest.php
M test/classes/MenuTest.php
M test/classes/Navigation/NavigationTreeTest.php
M test/classes/Plugins/Auth/AuthenticationConfigTest.php
M test/classes/Plugins/Auth/AuthenticationCookieTest.php
M test/classes/Plugins/Auth/AuthenticationHttpTest.php
M test/classes/Plugins/Auth/AuthenticationSignonTest.php
M test/classes/Plugins/Export/ExportCsvTest.php
M test/classes/Plugins/Export/ExportHtmlwordTest.php
M test/classes/Plugins/Export/ExportMediawikiTest.php
M test/classes/Plugins/Export/ExportPhparrayTest.php
M test/classes/Plugins/Export/ExportSqlTest.php
M test/classes/Plugins/Export/ExportTexytextTest.php
M test/classes/Plugins/Export/ExportYamlTest.php
M test/classes/Plugins/Schema/SvgRelationSchemaTest.php
M test/classes/Plugins/TwoFactor/WebAuthnTest.php
M test/classes/ResponseTest.php
M test/classes/RoutingTest.php
M test/classes/Setup/FormProcessingTest.php
M test/classes/SqlQueryFormTest.php
M test/classes/SqlTest.php
M test/classes/Stubs/ResponseRenderer.php
M test/classes/Table/IndexesTest.php
M test/classes/TrackingTest.php
M test/classes/TwoFactorTest.php
M test/classes/UserPreferencesTest.php

Log Message:
-----------
Remove $GLOBALS['PMA_PHP_SELF'] (#18149)

* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>



More information about the Git mailing list