[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 7a2233: Designer controller globals (#17985)

Kamil Tekiela tekiela246 at gmail.com
Fri Jan 27 02:58:26 CET 2023


Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 7a2233416757bcb3f3c12e402d5e8d70a95d2649
https://github.com/phpmyadmin/phpmyadmin/commit/7a2233416757bcb3f3c12e402d5e8d70a95d2649
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2023-01-26 (Thu, 01 January 2023) -03:00

Changed paths: 
M libraries/classes/Controllers/Database/CentralColumnsController.php
M libraries/classes/Controllers/Database/DesignerController.php
M libraries/classes/Controllers/Database/EventsController.php
M libraries/classes/Controllers/Database/ExportController.php
M libraries/classes/Controllers/Database/ImportController.php
M libraries/classes/Controllers/Database/OperationsController.php
M libraries/classes/Controllers/Database/PrivilegesController.php
M libraries/classes/Controllers/Database/QueryByExampleController.php
M libraries/classes/Controllers/Database/RoutinesController.php
M libraries/classes/Controllers/Database/SearchController.php
M libraries/classes/Controllers/Database/StructureController.php
M libraries/classes/Controllers/Database/TrackingController.php
M libraries/classes/Controllers/Database/TriggersController.php
M libraries/classes/Controllers/Export/ExportController.php
M libraries/classes/Controllers/Preferences/ManageController.php
M libraries/classes/Controllers/Server/ExportController.php
M libraries/classes/Controllers/Server/PrivilegesController.php
M libraries/classes/Controllers/Table/ExportController.php
M libraries/classes/Controllers/Table/TriggersController.php
M libraries/classes/Database/Designer.php
M libraries/classes/Query/Utilities.php
M libraries/classes/Util.php
M phpstan-baseline.neon
M psalm-baseline.xml
M test/classes/UtilTest.php

Log Message:
-----------
Designer controller globals (#17985)

* Remove globals from DesignerController
* Remove $GLOBALS['params'] in ManageController
* Remove $GLOBALS['params']
* Remove $GLOBALS['total_num_tables']
* Remove $GLOBALS['tooltip_truename']
* Remove $GLOBALS['tooltip_aliasname']
* Remove $GLOBALS['pos']
* Remove $GLOBALS['tables'] (partially)
* Remove $GLOBALS['num_tables'] (partially)
* Remove redundant calls to Util::getDbInfo()
* Move unrelated functionality out of getDbInfo()
* Extract new method getTableListPosition()
* Code style changes
* Update phpstan-baseline.neon

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>



More information about the Git mailing list