[phpMyAdmin Git] [phpmyadmin/phpmyadmin] f7524f: Minor code refactoring of Privileges.php (#17993)

[Kamil Tekiela]

Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: f7524fd3b981913b2373254042c9d61d174fbe11
https://github.com/phpmyadmin/phpmyadmin/commit/f7524fd3b981913b2373254042c9d61d174fbe11
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2023-01-28 (Sat, 01 January 2023) -03:00

Changed paths: 
M libraries/classes/Controllers/Server/PrivilegesController.php
M libraries/classes/Server/Privileges.php
M libraries/classes/UserPassword.php
M phpstan-baseline.neon
M psalm-baseline.xml
M test/classes/Controllers/Server/PrivilegesControllerTest.php
M test/classes/Server/PrivilegesTest.php
M test/classes/Stubs/DbiDummy.php

Log Message:
-----------
Minor code refactoring of Privileges.php (#17993)

* Small fixes
* Replace escapeString with quoteString
This also fixes bug with $_POST['old_username'].
* Add userExists() method
* Merge if statements
* Use ServerRequest for $initial
* Extract getExportPageTitle from getExportUserDefinitionTextarea
* Update baselines
* Complete redesign of getCurrentAuthenticationPlugin()
* Add method getEmptyUserNotice()
* Remove redundant variable sets and unsets
* Add method checkStructureOfPrivilegeTable()
* Remove testGetHtmlForViewUsersError()
* Privatize getAddUserHtmlFieldset
* Improve tests for mysql.user table checks

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>