[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 719bc9: $column['values'] is never set anywhere

Kamil Tekiela tekiela246 at gmail.com
Thu May 25 02:16:08 CEST 2023


Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 719bc917976268eeabaf910fe769864ebebcfc1d
https://github.com/phpmyadmin/phpmyadmin/commit/719bc917976268eeabaf910fe769864ebebcfc1d
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2023-05-23 (Tue, 05 May 2023) +01:00

Changed paths: 
M libraries/classes/InsertEdit.php
M phpstan-baseline.neon
M psalm-baseline.xml
M templates/table/insert/column_row.twig

Log Message:
-----------
$column['values'] is never set anywhere

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 919bf36460ec734b8751e27e021f2aa51ca38da2
https://github.com/phpmyadmin/phpmyadmin/commit/919bf36460ec734b8751e27e021f2aa51ca38da2
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2023-05-23 (Tue, 05 May 2023) +01:00

Changed paths: 
M libraries/classes/InsertEdit.php
M phpstan-baseline.neon
M psalm-baseline.xml
M templates/table/insert/column_row.twig
M test/classes/InsertEditTest.php

Log Message:
-----------
Move getColumnTitle() out of $column

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 90c0dc3b302b7d1eaf1d914c068f432a23c48402
https://github.com/phpmyadmin/phpmyadmin/commit/90c0dc3b302b7d1eaf1d914c068f432a23c48402
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2023-05-23 (Tue, 05 May 2023) +01:00

Changed paths: 
M libraries/classes/InsertEdit.php
M libraries/classes/Plugins/IOTransformationsPlugin.php
M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php
M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php
M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php
M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php
M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php

Log Message:
-----------
Remove unused params in IO plugins

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: fa826f737a8cd7c6ce389bc96e838ec91668939d
https://github.com/phpmyadmin/phpmyadmin/commit/fa826f737a8cd7c6ce389bc96e838ec91668939d
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2023-05-23 (Tue, 05 May 2023) +01:00

Changed paths: 
A libraries/classes/InsertEditColumn.php
M libraries/classes/Database/Routines.php
M libraries/classes/Html/Generator.php
M libraries/classes/InsertEdit.php
M phpstan-baseline.neon
M psalm-baseline.xml
M templates/table/insert/column_row.twig
M templates/table/insert/value_column_for_other_datatype.twig
M test/classes/Html/GeneratorTest.php
M test/classes/InsertEditTest.php
M test/classes/Plugins/Transformations/TransformationPluginsTest.php

Log Message:
-----------
Implement InsertEditColumn

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 7838a42a34ea6a644086b29ae9ce714d5431469c
https://github.com/phpmyadmin/phpmyadmin/commit/7838a42a34ea6a644086b29ae9ce714d5431469c
Author: Kamil Tekiela <tekiela246 at gmail.com>
Date: 2023-05-23 (Tue, 05 May 2023) +01:00

Changed paths: 
M libraries/classes/Controllers/Table/ReplaceController.php
M libraries/classes/InsertEdit.php
M libraries/classes/Query/Generator.php
M test/classes/InsertEditTest.php
M test/classes/Query/GeneratorTest.php

Log Message:
-----------
Move buildInsertSqlQuery to Generator

Signed-off-by: Kamil Tekiela <tekiela246 at gmail.com>

Commit: 62ec1bcc2c14c465ed688c8805b7a645e9d1e2bd
https://github.com/phpmyadmin/phpmyadmin/commit/62ec1bcc2c14c465ed688c8805b7a645e9d1e2bd
Author: Maurício Meneghini Fauth <mauricio at fauth.dev>
Date: 2023-05-24 (Wed, 05 May 2023) -03:00

Changed paths: 
A libraries/classes/InsertEditColumn.php
M libraries/classes/Controllers/Table/ReplaceController.php
M libraries/classes/Database/Routines.php
M libraries/classes/Html/Generator.php
M libraries/classes/InsertEdit.php
M libraries/classes/Plugins/IOTransformationsPlugin.php
M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php
M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php
M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php
M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php
M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php
M libraries/classes/Query/Generator.php
M phpstan-baseline.neon
M psalm-baseline.xml
M templates/table/insert/column_row.twig
M templates/table/insert/value_column_for_other_datatype.twig
M test/classes/Html/GeneratorTest.php
M test/classes/InsertEditTest.php
M test/classes/Plugins/Transformations/TransformationPluginsTest.php
M test/classes/Query/GeneratorTest.php

Log Message:
-----------
Merge pull request #18445 from kamil-tekiela/InsertEdit-pt4

InsertEdit refactoring - part 4



More information about the Git mailing list