Hello,
I've created a Gitter room[1] for discussions related to Google Summer
of Code. We've had several requests from potential students to use
this tool, but because we don't use it as a development team this room
is running on a trial basis.
Since a portion of the student application period involves reaching
out to the team and introducing themselves, we thought this was a good
opportunity to introduce Gitter to our workflow. This email list will
remain the primary communication channel, but students who are more
comfortable with Gitter are welcome to use that instead.
I've also added a section to the wiki[2] encouraging students to
introduce themselves early in the process.
Any feedback on these changes is welcome.
Isaac
1 - https://gitter.im/phpmyadmin/GSoC
2 - https://github.com/phpmyadmin/phpmyadmin/wiki/GSoC_2018_applicant_guide/_co…
Hello.
This week I was researching how to increase code coverage and found a few
things that would make it easier to write unit tests and make the code
cleaner.
The main point is to use dependency injection whenever possible, as this
makes it easier to mock the dependencies. To facilitate this, we can reduce
the use of static methods in favor of instance methods. This would give us
a constructor method, which would make it easier to manage dependencies.
Another point is that we currently use $GLOBALS as a simplified service
locator. We can replace this with the dependency injection container. This
would reduce the 'action at a distance' problems, in addition to decoupling
the classes.
I would like to know what you think about it. Any feedback is welcome.
Maurício Meneghini Fauth
See <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/14033/display/redirect?…>
Changes:
[carusogabriel34] Use assertNotSame
------------------------------------------
Started by GitHub push by mauriciofauth
[EnvInject] - Loading node environment variables.
Building in workspace <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/>
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/phpmyadmin/phpmyadmin.git # timeout=10
Fetching upstream changes from https://github.com/phpmyadmin/phpmyadmin.git
> git --version # timeout=10
> git fetch --tags --progress https://github.com/phpmyadmin/phpmyadmin.git +refs/heads/*:refs/remotes/origin/*
> git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 7ce0025dae4f103b435a67bef95bb4c728f42bb5 (origin/master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 7ce0025dae4f103b435a67bef95bb4c728f42bb5
Commit message: "Merge pull request #13936 from carusogabriel/assertions"
> git rev-list --no-walk 91ee20e7574519d57c2fa920b89c0a1c79c73d1c # timeout=10
> git tag -a -f -m Jenkins Build #14033 jenkins-phpMyAdmin-continuous-14033 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the SCM step.
[EnvInject] - Injecting as environment variables the properties content
TESTSUITE_URL=http://ci-live.phpmyadmin.net/phpMyAdmin-continuous/workspace/
TESTSUITE_USER=pmatest
TESTSUITE_DATABASE=pmatest
XTESTSUITE_BROWSERSTACK_USER=michaliha
TESTSUITE_SERVER=localhost
[EnvInject] - Variables injected successfully.
[workspace] $ /bin/sh -xe /tmp/jenkins433280040343000196.sh
+ composer update --no-interaction
Loading composer repositories with package information
Updating dependencies (including require-dev)
[Composer\Repository\RepositorySecurityException]
The contents of https://packagist.org/p/provider-latest%240cbfb40ab72a881d21b70f78286d39cd7… do not match its signature. This should indicate a man-in-the-middle attack. Try running composer again and report this if you think it is a mistake.
update [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--lock] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [--with-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>]...
Build step 'Execute shell' marked build as failure
[CHECKSTYLE] Skipping publisher since build result is FAILURE
[JSLINT] Skipping publisher since build result is FAILURE
[DRY] Collecting duplicate code analysis files...
[DRY] Searching for all files in <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> that match the pattern build/logs/pmd-cpd.xml
[DRY] Parsing 1 file in <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/>
[DRY] Successfully parsed file <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.x…> with 12 unique warnings and 0 duplicates.
[DRY] Computing warning deltas based on reference build #14032
[TASKS] Skipping publisher since build result is FAILURE
[ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #14032
Recording plot data
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing PHPUnit-3.x (default)
[xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'.
[xUnit] [ERROR] - Test reports were found but not all of them are new. Did all the tests run?
* <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml> is 16 min old
[xUnit] [INFO] - Failing BUILD.
[xUnit] [INFO] - There are errors when processing test results.
[xUnit] [INFO] - Skipping tests recording.
[xUnit] [INFO] - Stop build.
