On Mon, 2011-06-13 at 20:56 +0200, Tyron Madlener wrote:
On Mon, Jun 13, 2011 at 8:12 PM, Rouslan Placella rouslan@placella.com wrote:
On Mon, 2011-06-13 at 19:18 +0200, Tyron Madlener wrote:
On Mon, Jun 13, 2011 at 2:52 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
I've committed a bunch of fixes for bugs/style glitches that I found. I didn't test my stuff with the original theme before.
There's still some issues that I'd like to mention:
- Chart export under IE8 still doesn't work yet. Though the canvg
author told me he would work on it next Sunday.
- I've just discovered chart export in other browsers is a bit
glitchy, as canvg ignores the svg element attribute visibility="hidden" - however I dug into the canvg code and fixed this for text and path elements (which before created a lot of overlapping text elements on pie charts). So now there is only this odd cross in the upper left corner and some other weird element rendered at the bottom center of the image. I've reported this bug and it's fix as well. So that might be fixed real soon.
- On real-time charts, it sometimes happened to me that the refreshing
stopped after I have exported it. I couldn't reproduce this yet.
Just seen those real-time charts for the first time now. Nice work, that is so cool! =D
Glad to hear that :) The highcharts library is doing a really good job there.
BTW, I noticed that when switching from one tab (say "server traffic") with real-time chart to another one (say "query statistics") and then back, the refresh also stops.
Odd, that doesn't happen to me. In Chrome it keeps refreshing when I tab away and it keeps refreshing when I tab back. What browser do you use? Any javascript errors in the console?
Error is with Firefox 4.0.1 / Ubuntu Linux 64-bit Works fine in Chrome 11 and Opera 11 though. Nothing in the error console.
Also, you probably already aware of this, but with JavaScript turned off the status page looks really bad now. There are lots of things out of place, some gibberish JS object being printed and also the "realtime chart" button that does nothing.
- I'm still not entirely sure of whether the processes table should be
merged into the status page. I'm currently leaving it there now to get the right inspiration what to do with it :-)
- The chrome console gives me odd errors on highcharts pies: "Error: A
negative value for rect <height> is not allowed" - this should be a bug of highcharts and is I guess some SVG Error (there's not stacktrace available).
- Using 'display chart' on big amounts of data creates a lot of client lag.
- My branch includes a differently behaving PMA_formatNumber() which
might affect other areas of pma
Other than that, I'd be glad to see my changes in master :-)
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
I've just fixed this in git.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel