Wasn't sure of whether to mail this to Michal or the mailing list, but I guess a bigger audience also means more feedback :)
I am in the process of replacing pChart in pma and finishing on the table charting feature. Since the pChart-Version was rather difficult to use I thought I'd offer the user some choice about which column data is used for what. While implementing, I was orienting in the examples given by http://wiki.phpmyadmin.net/pma/Charts#Data_formats_for_query_results_chart where I was slightly surprised by the odd data format of the examples. It doesn't allow any graph with more than 2 series. So I thought the most logical of way representing table data is by selecting one column as x-axis and let the other columns be different series within the graph.
So looking at the examples, the logical continuation of example 2 would be:
SELECT 225 AS 'Value1', 653 AS 'Value2', '2009-11' AS 'Month' UNION SELECT 1157, 855, '2009-12' UNION SELECT 569, 253, '2010-01' UNION SELECT 282, 455, '2010-02' UNION SELECT 2960, 3552, '2010-03'
...which will display the date on the X-Axis and 2 series (Value1 and Value2) in the graph.
However, in order to allow data like in the original example3 I've added a select list where one can select what the series types should be. The default selection is to use all columns except the selected xaxis but you can also select a specific column from where it should read all possible types (so this column should probably be a ENUM or similar).
So when charting the original example3 with Type set to Column, Series=Operator, X-Axis=Month and Stacking on we get the same result again. I'm not quite sure whether such solution will make sense for everyone so I'm asking here if it is :-)
Current differences over the pChart implementation: - Everything updates as you type/select. No more Redraw button is required - New charting types: (Horizontal-)Bar and Spline - No editable Area/Legend Margins (who needs that?) - Have as many Series (=Columns-1) as you want, not only 3 - Select the column you want to be the x-axis, so you don't need to know by heart where in your query result the x-axis column is supposed to be. - If a column contains the word date or time it will be pre-selected as xaxis - No width/height selection, instead just mouse-drag the chart to the right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
Hi
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
I've just fixed this in git.
On Mon, 2011-06-13 at 14:52 +0200, Michal Čihař wrote:
Hi
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
I found a bug (I think). To reproduce:
* go to demo server * go to sakila db * go to actor table * click profiling checkbox * do some action that is handled via AJAX E.g.: (sort by column, show 30 rows starting at row X, go to page X, etc) * you get a warning: "Notice in ./sql.php#904 Undefined variable: url_query" * the chart disappears
Regards, Rouslan
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
I've just fixed this in git.
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi
Dne Mon, 13 Jun 2011 14:39:53 +0100 Rouslan Placella rouslan@placella.com napsal(a):
I found a bug (I think). To reproduce:
- go to demo server
- go to sakila db
- go to actor table
- click profiling checkbox
- do some action that is handled via AJAX E.g.: (sort by column, show 30 rows starting at row X, go to page X, etc)
- you get a warning: "Notice in ./sql.php#904 Undefined variable: url_query"
- the chart disappears
Indeed, this looks like a regression.
On Mon, Jun 13, 2011 at 3:39 PM, Rouslan Placella rouslan@placella.com wrote:
On Mon, 2011-06-13 at 14:52 +0200, Michal Čihař wrote:
Hi
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
I found a bug (I think). To reproduce:
- go to demo server
- go to sakila db
- go to actor table
- click profiling checkbox
- do some action that is handled via AJAX E.g.:
(sort by column, show 30 rows starting at row X, go to page X, etc)
- you get a warning:
"Notice in ./sql.php#904 Undefined variable: url_query"
- the chart disappears
That's even 2 bugs, I'm fixing them now.
Regards, Rouslan
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
I've just fixed this in git.
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Mon, Jun 13, 2011 at 3:39 PM, Rouslan Placella rouslan@placella.com wrote:
On Mon, 2011-06-13 at 14:52 +0200, Michal Čihař wrote:
Hi
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
I found a bug (I think). To reproduce:
- go to demo server
- go to sakila db
- go to actor table
- click profiling checkbox
- do some action that is handled via AJAX E.g.:
(sort by column, show 30 rows starting at row X, go to page X, etc)
- you get a warning:
"Notice in ./sql.php#904 Undefined variable: url_query"
- the chart disappears
Ok, I've fixed both now.
On ajax request, server.common.inc.php is not included, where $url_query is defined. So if it is not defined it will use 'PMA_generate_common_url($db);' now
As for the second, the only nice way I can think of to fix that is to add a inline-js function call to create the chart. Previously I generated the chart on $(document).ready(), which of course doesn't get called when an ajax request updates the page. Wasn't there some jQuery event feature that fires every time the DOM Tree updates?
I should actually unload the chart when it gets overwritten in the DOM, at least according to what the highcharts docs say about chart.destroy(): "Removes the chart and purges memory. This method should be called before writing a new chart into the same container. It is called internally on window unload to prevent leaks."
Maybe we should implement some universal beforeAjaxLoad, afterAjaxLoad event to which I can bind to for reloading/destroying the chart each time.
Regards, Rouslan
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
I've just fixed this in git.
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Mon, Jun 13, 2011 at 2:52 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
I've committed a bunch of fixes for bugs/style glitches that I found. I didn't test my stuff with the original theme before.
There's still some issues that I'd like to mention:
- Chart export under IE8 still doesn't work yet. Though the canvg author told me he would work on it next Sunday. - I've just discovered chart export in other browsers is a bit glitchy, as canvg ignores the svg element attribute visibility="hidden" - however I dug into the canvg code and fixed this for text and path elements (which before created a lot of overlapping text elements on pie charts). So now there is only this odd cross in the upper left corner and some other weird element rendered at the bottom center of the image. I've reported this bug and it's fix as well. So that might be fixed real soon. - On real-time charts, it sometimes happened to me that the refreshing stopped after I have exported it. I couldn't reproduce this yet. - I'm still not entirely sure of whether the processes table should be merged into the status page. I'm currently leaving it there now to get the right inspiration what to do with it :-) - The chrome console gives me odd errors on highcharts pies: "Error: A negative value for rect <height> is not allowed" - this should be a bug of highcharts and is I guess some SVG Error (there's not stacktrace available). - Using 'display chart' on big amounts of data creates a lot of client lag. - My branch includes a differently behaving PMA_formatNumber() which might affect other areas of pma
Other than that, I'd be glad to see my changes in master :-)
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
I've just fixed this in git.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Mon, 2011-06-13 at 19:18 +0200, Tyron Madlener wrote:
On Mon, Jun 13, 2011 at 2:52 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
I've committed a bunch of fixes for bugs/style glitches that I found. I didn't test my stuff with the original theme before.
There's still some issues that I'd like to mention:
- Chart export under IE8 still doesn't work yet. Though the canvg
author told me he would work on it next Sunday.
- I've just discovered chart export in other browsers is a bit
glitchy, as canvg ignores the svg element attribute visibility="hidden" - however I dug into the canvg code and fixed this for text and path elements (which before created a lot of overlapping text elements on pie charts). So now there is only this odd cross in the upper left corner and some other weird element rendered at the bottom center of the image. I've reported this bug and it's fix as well. So that might be fixed real soon.
- On real-time charts, it sometimes happened to me that the refreshing
stopped after I have exported it. I couldn't reproduce this yet.
Just seen those real-time charts for the first time now. Nice work, that is so cool! =D
BTW, I noticed that when switching from one tab (say "server traffic") with real-time chart to another one (say "query statistics") and then back, the refresh also stops.
- I'm still not entirely sure of whether the processes table should be
merged into the status page. I'm currently leaving it there now to get the right inspiration what to do with it :-)
- The chrome console gives me odd errors on highcharts pies: "Error: A
negative value for rect <height> is not allowed" - this should be a bug of highcharts and is I guess some SVG Error (there's not stacktrace available).
- Using 'display chart' on big amounts of data creates a lot of client lag.
- My branch includes a differently behaving PMA_formatNumber() which
might affect other areas of pma
Other than that, I'd be glad to see my changes in master :-)
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
I've just fixed this in git.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Mon, Jun 13, 2011 at 8:12 PM, Rouslan Placella rouslan@placella.com wrote:
On Mon, 2011-06-13 at 19:18 +0200, Tyron Madlener wrote:
On Mon, Jun 13, 2011 at 2:52 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
I've committed a bunch of fixes for bugs/style glitches that I found. I didn't test my stuff with the original theme before.
There's still some issues that I'd like to mention:
- Chart export under IE8 still doesn't work yet. Though the canvg
author told me he would work on it next Sunday.
- I've just discovered chart export in other browsers is a bit
glitchy, as canvg ignores the svg element attribute visibility="hidden" - however I dug into the canvg code and fixed this for text and path elements (which before created a lot of overlapping text elements on pie charts). So now there is only this odd cross in the upper left corner and some other weird element rendered at the bottom center of the image. I've reported this bug and it's fix as well. So that might be fixed real soon.
- On real-time charts, it sometimes happened to me that the refreshing
stopped after I have exported it. I couldn't reproduce this yet.
Just seen those real-time charts for the first time now. Nice work, that is so cool! =D
Glad to hear that :) The highcharts library is doing a really good job there.
BTW, I noticed that when switching from one tab (say "server traffic") with real-time chart to another one (say "query statistics") and then back, the refresh also stops.
Odd, that doesn't happen to me. In Chrome it keeps refreshing when I tab away and it keeps refreshing when I tab back. What browser do you use? Any javascript errors in the console?
- I'm still not entirely sure of whether the processes table should be
merged into the status page. I'm currently leaving it there now to get the right inspiration what to do with it :-)
- The chrome console gives me odd errors on highcharts pies: "Error: A
negative value for rect <height> is not allowed" - this should be a bug of highcharts and is I guess some SVG Error (there's not stacktrace available).
- Using 'display chart' on big amounts of data creates a lot of client lag.
- My branch includes a differently behaving PMA_formatNumber() which
might affect other areas of pma
Other than that, I'd be glad to see my changes in master :-)
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
I've just fixed this in git.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Mon, 2011-06-13 at 20:56 +0200, Tyron Madlener wrote:
On Mon, Jun 13, 2011 at 8:12 PM, Rouslan Placella rouslan@placella.com wrote:
On Mon, 2011-06-13 at 19:18 +0200, Tyron Madlener wrote:
On Mon, Jun 13, 2011 at 2:52 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
I've committed a bunch of fixes for bugs/style glitches that I found. I didn't test my stuff with the original theme before.
There's still some issues that I'd like to mention:
- Chart export under IE8 still doesn't work yet. Though the canvg
author told me he would work on it next Sunday.
- I've just discovered chart export in other browsers is a bit
glitchy, as canvg ignores the svg element attribute visibility="hidden" - however I dug into the canvg code and fixed this for text and path elements (which before created a lot of overlapping text elements on pie charts). So now there is only this odd cross in the upper left corner and some other weird element rendered at the bottom center of the image. I've reported this bug and it's fix as well. So that might be fixed real soon.
- On real-time charts, it sometimes happened to me that the refreshing
stopped after I have exported it. I couldn't reproduce this yet.
Just seen those real-time charts for the first time now. Nice work, that is so cool! =D
Glad to hear that :) The highcharts library is doing a really good job there.
BTW, I noticed that when switching from one tab (say "server traffic") with real-time chart to another one (say "query statistics") and then back, the refresh also stops.
Odd, that doesn't happen to me. In Chrome it keeps refreshing when I tab away and it keeps refreshing when I tab back. What browser do you use? Any javascript errors in the console?
Error is with Firefox 4.0.1 / Ubuntu Linux 64-bit Works fine in Chrome 11 and Opera 11 though. Nothing in the error console.
Also, you probably already aware of this, but with JavaScript turned off the status page looks really bad now. There are lots of things out of place, some gibberish JS object being printed and also the "realtime chart" button that does nothing.
- I'm still not entirely sure of whether the processes table should be
merged into the status page. I'm currently leaving it there now to get the right inspiration what to do with it :-)
- The chrome console gives me odd errors on highcharts pies: "Error: A
negative value for rect <height> is not allowed" - this should be a bug of highcharts and is I guess some SVG Error (there's not stacktrace available).
- Using 'display chart' on big amounts of data creates a lot of client lag.
- My branch includes a differently behaving PMA_formatNumber() which
might affect other areas of pma
Other than that, I'd be glad to see my changes in master :-)
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
I've just fixed this in git.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Mon, Jun 13, 2011 at 9:31 PM, Rouslan Placella rouslan@placella.com wrote:
On Mon, 2011-06-13 at 20:56 +0200, Tyron Madlener wrote:
On Mon, Jun 13, 2011 at 8:12 PM, Rouslan Placella rouslan@placella.com wrote:
On Mon, 2011-06-13 at 19:18 +0200, Tyron Madlener wrote:
On Mon, Jun 13, 2011 at 2:52 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
I've committed a bunch of fixes for bugs/style glitches that I found. I didn't test my stuff with the original theme before.
There's still some issues that I'd like to mention:
- Chart export under IE8 still doesn't work yet. Though the canvg
author told me he would work on it next Sunday.
- I've just discovered chart export in other browsers is a bit
glitchy, as canvg ignores the svg element attribute visibility="hidden" - however I dug into the canvg code and fixed this for text and path elements (which before created a lot of overlapping text elements on pie charts). So now there is only this odd cross in the upper left corner and some other weird element rendered at the bottom center of the image. I've reported this bug and it's fix as well. So that might be fixed real soon.
- On real-time charts, it sometimes happened to me that the refreshing
stopped after I have exported it. I couldn't reproduce this yet.
Just seen those real-time charts for the first time now. Nice work, that is so cool! =D
Glad to hear that :) The highcharts library is doing a really good job there.
BTW, I noticed that when switching from one tab (say "server traffic") with real-time chart to another one (say "query statistics") and then back, the refresh also stops.
Odd, that doesn't happen to me. In Chrome it keeps refreshing when I tab away and it keeps refreshing when I tab back. What browser do you use? Any javascript errors in the console?
Error is with Firefox 4.0.1 / Ubuntu Linux 64-bit Works fine in Chrome 11 and Opera 11 though. Nothing in the error console.
I will check it out once I get access to a working Firefox. On my machine FF is extremely slow. Just tried it on IE8 and Opera, works on both of them.
Also, you probably already aware of this, but with JavaScript turned off the status page looks really bad now. There are lots of things out of place, some gibberish JS object being printed and also the "realtime chart" button that does nothing.
Hm well, I can set the buttons, json code and filters fieldset to invisible. Then it would look about the same as the old version of the status page.
- I'm still not entirely sure of whether the processes table should be
merged into the status page. I'm currently leaving it there now to get the right inspiration what to do with it :-)
- The chrome console gives me odd errors on highcharts pies: "Error: A
negative value for rect <height> is not allowed" - this should be a bug of highcharts and is I guess some SVG Error (there's not stacktrace available).
- Using 'display chart' on big amounts of data creates a lot of client lag.
- My branch includes a differently behaving PMA_formatNumber() which
might affect other areas of pma
Other than that, I'd be glad to see my changes in master :-)
P.S.: There seems to be a problem when using the sql statements given on the wiki within the db links SQL page. Once the query is executed and you click on display chart or export it just redirects you to the main page again.
I've just fixed this in git.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Hi
Dne Mon, 13 Jun 2011 20:31:48 +0100 Rouslan Placella rouslan@placella.com napsal(a):
On Mon, 2011-06-13 at 20:56 +0200, Tyron Madlener wrote:
On Mon, Jun 13, 2011 at 8:12 PM, Rouslan Placella rouslan@placella.com wrote:
BTW, I noticed that when switching from one tab (say "server traffic") with real-time chart to another one (say "query statistics") and then back, the refresh also stops.
Odd, that doesn't happen to me. In Chrome it keeps refreshing when I tab away and it keeps refreshing when I tab back. What browser do you use? Any javascript errors in the console?
Error is with Firefox 4.0.1 / Ubuntu Linux 64-bit Works fine in Chrome 11 and Opera 11 though. Nothing in the error console.
That's exactly what I see as well, Firefox 4.0.1 on openSUSE.
On Tue, Jun 14, 2011 at 1:45 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Mon, 13 Jun 2011 20:31:48 +0100 Rouslan Placella rouslan@placella.com napsal(a):
On Mon, 2011-06-13 at 20:56 +0200, Tyron Madlener wrote:
On Mon, Jun 13, 2011 at 8:12 PM, Rouslan Placella rouslan@placella.com wrote:
BTW, I noticed that when switching from one tab (say "server traffic") with real-time chart to another one (say "query statistics") and then back, the refresh also stops.
Odd, that doesn't happen to me. In Chrome it keeps refreshing when I tab away and it keeps refreshing when I tab back. What browser do you use? Any javascript errors in the console?
Error is with Firefox 4.0.1 / Ubuntu Linux 64-bit Works fine in Chrome 11 and Opera 11 though. Nothing in the error console.
That's exactly what I see as well, Firefox 4.0.1 on openSUSE.
I've fixed this issue now. Was caused by a bug in FF causing an exception on certain SVG functions on hidden elements.
Now tabs are not set to "display:none" anymore but just outside the viewable area, as suggested on http://jqueryui.com/demos/tabs/#...my_slider.2C_Google_Map.2C_sIFR_etc._not_...
The change is required in jquery-ui-1.8.custom.css so this file should not be overwritten anymore :/
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi
Dne Tue, 14 Jun 2011 17:13:02 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
I've fixed this issue now. Was caused by a bug in FF causing an exception on certain SVG functions on hidden elements.
Now tabs are not set to "display:none" anymore but just outside the viewable area, as suggested on http://jqueryui.com/demos/tabs/#...my_slider.2C_Google_Map.2C_sIFR_etc._not_...
The change is required in jquery-ui-1.8.custom.css so this file should not be overwritten anymore :/
AFAIR there were already some changes to that file before, so this does not change that much...
Hi
Dne Mon, 13 Jun 2011 14:52:58 +0200 Michal Čihař michal@cihar.com napsal(a):
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
As there were no strong objections, I've merged the branch right now. This way anybody can start using new charts and other additions.
There are still few bugs, which will be addressed, but I don't think anyone of them would be a blocker.
Michal Čihař a écrit :
Hi
Dne Mon, 13 Jun 2011 14:52:58 +0200 Michal Čihař michal@cihar.com napsal(a):
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
As there were no strong objections, I've merged the branch right now. This way anybody can start using new charts and other additions.
There are still few bugs, which will be addressed, but I don't think anyone of them would be a blocker.
Michal, please add a ChangeLog entry for the new features.
Michal Čihař a écrit :
Hi
Dne Mon, 13 Jun 2011 14:52:58 +0200 Michal Čihař michal@cihar.com napsal(a):
Dne Thu, 9 Jun 2011 17:04:30 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
Current differences over the pChart implementation:
- Everything updates as you type/select. No more Redraw button is required
- New charting types: (Horizontal-)Bar and Spline
- No editable Area/Legend Margins (who needs that?)
- Have as many Series (=Columns-1) as you want, not only 3
- Select the column you want to be the x-axis, so you don't need to
know by heart where in your query result the x-axis column is supposed to be.
- If a column contains the word date or time it will be pre-selected as xaxis
- No width/height selection, instead just mouse-drag the chart to the
right size.
Please check it out at http://demo.phpmyadmin.net/gsoc-tyron/
Looks nice, thanks!
I'd like to merge your changes back to master, any opinions about that?
As there were no strong objections, I've merged the branch right now. This way anybody can start using new charts and other additions.
There are still few bugs, which will be addressed, but I don't think anyone of them would be a blocker.
When clicking Status I see at the top of page:
'; echo __('Runtime Information'); ?>
Hi
Dne Tue, 14 Jun 2011 08:03:15 -0400 Marc Delisle marc@infomarc.info napsal(a):
When clicking Status I see at the top of page:
'; echo __('Runtime Information'); ?>
Was caused by occasional use of <? instead of <?php. Fixed in git.
-
Marc Delisle -
Michal Čihař -
Rouslan Placella -
Tyron Madlener