On 7/4/14, 4:12 PM, Chirayu Chiripal wrote:
Please, review the work I have done so far: https://github.com/D-storm/phpmyadmin/tree/FR-637. So that I can come to know if I am missing something or not. Tasks to be done yet includes: Mechanism to change input fields & One plugin to demonstrate/test this and fix failing testcases.
There is a scenario where I can reproduce some warning/error messages using the transformations (pasted below), but I've confirmed that they also exist in master so they're unrelated to your work here. I'm mentioning it here (1) in case anyone else encounters the messages and thinks about reporting them to you and (2) so I can file a proper bug report shortly.
Regards, ~isaac
Warning in ./libraries/dbi/DBIMysqli.class.php#258 mysqli_query() expects parameter 2 to be string, object given
Backtrace
./libraries/dbi/DBIMysqli.class.php#258: mysqli_query( object, object, integer 0, ) ./libraries/DatabaseInterface.class.php#180: PMA_DBI_Mysqli->realQuery( object, object, integer 1, ) ./libraries/DatabaseInterface.class.php#1406: PMA_DatabaseInterface->tryQuery( object, NULL, integer 1, boolean false, ) ./libraries/insert_edit.lib.php#2440: PMA_DatabaseInterface->fetchValue(object) ./tbl_replace.php#421: PMA_verifyWhetherValueCanBeTruncatedAndAppendExtraData( string 'test', string 'transforms', string 'sql', array, ) Warning in ./libraries/dbi/DBIMysqli.class.php#450 mysqli_num_rows() expects parameter 1 to be mysqli_result, null given
Backtrace
./libraries/dbi/DBIMysqli.class.php#450: mysqli_num_rows(NULL) ./libraries/DatabaseInterface.class.php#2135: PMA_DBI_Mysqli->numRows(NULL) ./libraries/DatabaseInterface.class.php#1413: PMA_DatabaseInterface->numRows(NULL) ./libraries/insert_edit.lib.php#2440: PMA_DatabaseInterface->fetchValue(object) ./tbl_replace.php#421: PMA_verifyWhetherValueCanBeTruncatedAndAppendExtraData( string 'test', string 'transforms', string 'sql', array, )