4 Oct
2005
4 Oct
'05
6:16 a.m.
On Tue 4. 10. 2005 13:04, Sebastian Mendel wrote:
Michal Čihař wrote:
Hi
On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
i would like to commit this into CVS, if no one is against.
I just quickly looked at the patch, My comments follow. The all do not address new code, however when the code is being touched, it could be cleaned up :-). Those are just minor issues, generally I like it.
- do not hardcode color in global css
- do not change error reporting
- you can rely on fact that all cfg parameters are set, this
includes PmaAbsoluteUri
also $GLOBALS['cfg']['Bookmark']['db'] ?
If there is server selected PMA_getBookmarksParam will fill it.
--
Michal Čihař | http://cihar.com