On Tue, Oct 1, 2013 at 5:44 PM, Madhura Jayaratne <madhura.cj@gmail.com>wrote:
On Tue, Oct 1, 2013 at 5:29 PM, Dieter Adriaenssens < dieter.adriaenssens@gmail.com> wrote:
Hi Marc,
You seem to have broken the build. ;) By changing the version from 4.1-dev to 4.1.0-alpha1, one if the tests fails because it checks the generated default config file with a fixed string (expected version code is 4.1-dev).
A possible solution is to use the version variable in the test, to avoid a broken test in the future. Or to update the expected version in the test as part of the release process.
First solution sounds better. I think release scripts should not have to worry about updating tests.
Fixed with
https://github.com/phpmyadmin/phpmyadmin/commit/878488d4693eec00f642a71edf1e... -- Thanks and Regards, Madhura Jayaratne