Hello,
On 6/16/14 8:09 AM, Chirayu Chiripal wrote:
Hello Isaac Sir,
Please review this branch: https://github.com/D-storm/phpmyadmin/tree/FR-755
Tasks to be done yet (Will be pushed soon):
- Fix failing test cases and improve test cases.
Yes, this is quite good but I have a few minor suggestions.
1) There should be some way to inform the user once they've selected this option. I have a few ideas about this but don't prefer one over the other at the moment.
What do you think of adding a checkbox in front of the text "Change Database/Table/Column names". When the user clicks the checkbox or the text, the dialog appears; once the dialog is closed the checkbox is checked.
An alternative is making an icon appear in front of the text (a green checkbox, probably) once the dialog is closed.
I think it's important to give visual feedback that the feature is going to be active.
2) I suggest adding a "reset" button to the dialog which would clear all values. I also think the upper-right X (close button) should abandon any changes made; right now it saves those changes.
3) I think we should call this "Rename exported database/column/table names" -- but I'm open to other suggestions.
4) I've tested with many columns and the dialog properly adjusts downward, so this is good behavior.
I'll make some comments in GitHub as well.
Thanks.
-- Regards, Chirayu Chiripal phpMyAdmin Intern - Google Summer of Code 2014 https://chirayuchiripal.wordpress.com/
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel