On Fri, Nov 25, 2016 at 1:10 PM, Michal Čihař michal@cihar.com wrote:
Hi
Isaac Bennetch píše v Pá 25. 11. 2016 v 12:21 -0500:
On Fri, Nov 25, 2016 at 8:02 AM, Isaac Bennetch bennetch@gmail.com wrote:
Do we need a quick release of 4.6.51 because of #12735 ?
What's the best way to handle this? Since QA_4_6 is so fresh, should I just base the release on QA_4_6 (which at the moment includes Michal's Node.js fix and a few language improvements? I think that's better than cherry-picking the fix back to a branch created from RELEASE_4_6_5 because the history will be cleaner, but it will include a few more fixes than just the issue mentioned.
There is nothing Node.js related from me, just sanity checks in php- gettext to avoid miserable failure when mbstring is not there. This should be fine for release. So I'd release from QA_4_6.
I was slightly mistaken, the commit I was referring is Node.php, not Node.js — anyway, I'll release from QA_4_6 this evening.
issue #12735 Incorrect parameters to escapeString in Node.php
See also https://github.com/phpmyadmin/phpmyadmin/compare/RELEASE_4_6_5...QA_4_6
Regards
-- Michal Čihař | https://cihar.com/ | https://weblate.org/
Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers