29 Jun
2017
29 Jun
'17
5:42 a.m.
Hi,
I have almost made phpmyadmin responsive. Now only the designer tab is
remaining. Have a look into this branch for review:
https://github.com/manishbisht/phpmyadmin/blob/responsive-design/
I am looking forward for your suggestions and feedback
Thanks,
Manish Bisht
Email : hi(a)manishbisht.me
Website : https://manishbisht.me
29 Jun
29 Jun
10:09 a.m.
Hello
Manish Bisht píše v Čt 29. 06. 2017 v 14:12 +0530:
I have almost made phpmyadmin responsive. Now only the
designer tab
is remaining. Have a look into this branch for review: https://github
.com/manishbisht/phpmyadmin/blob/responsive-design/
I am looking forward for your suggestions and feedback
Unfortunately I didn't yet get to deeper testing, but a little bit of
feedback on the code:
- avoid including commented out debug statements (//console.log(wmax);)
- you'we commented out most of PMA_tbl_structure_menu_resizer_callback
and it now doesn't return value as it used to
- you probably want to regenerate sprites to include left and right
icons
--
Michal Čihař | https://cihar.com/ | https://weblate.org/
10:12 a.m.
regenerate sprites means new icons ?
Manish Bisht
Email : hi(a)manishbisht.me
Website : https://manishbisht.me
On Thu, Jun 29, 2017 at 6:39 PM, Michal Čihař <michal(a)cihar.com> wrote:
Hello
Manish Bisht píše v Čt 29. 06. 2017 v 14:12 +0530:
I have almost made phpmyadmin responsive. Now
only the designer tab
is remaining. Have a look into this branch for review: https://github
.com/manishbisht/phpmyadmin/blob/responsive-design/
I am looking forward for your suggestions and feedback
Unfortunately I didn't yet get to deeper testing, but a little bit of
feedback on the code:
- avoid including commented out debug statements (//console.log(wmax);)
- you'we commented out most of PMA_tbl_structure_menu_resizer_callback
and it now doesn't return value as it used to
- you probably want to regenerate sprites to include left and right
icons
--
Michal Čihař | https://cihar.com/ | https://weblate.org/
_______________________________________________
Developers mailing list
Developers(a)phpmyadmin.net
https://lists.phpmyadmin.net/mailman/listinfo/developers
10:23 a.m.
Hi
Manish Bisht píše v Čt 29. 06. 2017 v 18:42 +0530:
regenerate sprites means new icons ?
No the sprites image, which is loaded once instead of may small icons,
see https://github.com/phpmyadmin/phpmyadmin/wiki/Icons_Sprites_Usage
--
Michal Čihař | https://cihar.com/ | https://weblate.org/
11:25 a.m.
Thanks for the link, I have fixed all the three issues and pushed them live
also.
Let me know if you have more suggestions.
Manish Bisht
Email : hi(a)manishbisht.me
Website : https://manishbisht.me
On Thu, Jun 29, 2017 at 6:53 PM, Michal Čihař <michal(a)cihar.com> wrote:
Hi
Manish Bisht píše v Čt 29. 06. 2017 v 18:42 +0530:
regenerate sprites means new icons ?
No the sprites image, which is loaded once instead of may small icons,
see https://github.com/phpmyadmin/phpmyadmin/wiki/Icons_Sprites_Usage
--
Michal Čihař | https://cihar.com/ | https://weblate.org/
_______________________________________________
Developers mailing list
Developers(a)phpmyadmin.net
https://lists.phpmyadmin.net/mailman/listinfo/developers
2627
days inactive
2627
days old
4 comments
2 participants
participants (2)
-
Manish Bisht -
Michal Čihař