Hi,
I have almost made phpmyadmin responsive. Now only the designer tab is remaining. Have a look into this branch for review: https://github.com/manishbisht/phpmyadmin/blob/responsive-design/
I am looking forward for your suggestions and feedback
Thanks,
Manish Bisht Email : hi@manishbisht.me Website : https://manishbisht.me
Hello
Manish Bisht píše v Čt 29. 06. 2017 v 14:12 +0530:
I have almost made phpmyadmin responsive. Now only the designer tab is remaining. Have a look into this branch for review: https://github .com/manishbisht/phpmyadmin/blob/responsive-design/
I am looking forward for your suggestions and feedback
Unfortunately I didn't yet get to deeper testing, but a little bit of feedback on the code:
- avoid including commented out debug statements (//console.log(wmax);) - you'we commented out most of PMA_tbl_structure_menu_resizer_callback and it now doesn't return value as it used to - you probably want to regenerate sprites to include left and right icons
regenerate sprites means new icons ?
Manish Bisht Email : hi@manishbisht.me Website : https://manishbisht.me
On Thu, Jun 29, 2017 at 6:39 PM, Michal Čihař michal@cihar.com wrote:
Hello
Manish Bisht píše v Čt 29. 06. 2017 v 14:12 +0530:
I have almost made phpmyadmin responsive. Now only the designer tab is remaining. Have a look into this branch for review: https://github .com/manishbisht/phpmyadmin/blob/responsive-design/
I am looking forward for your suggestions and feedback
Unfortunately I didn't yet get to deeper testing, but a little bit of feedback on the code:
- avoid including commented out debug statements (//console.log(wmax);)
- you'we commented out most of PMA_tbl_structure_menu_resizer_callback
and it now doesn't return value as it used to
- you probably want to regenerate sprites to include left and right
icons
-- Michal Čihař | https://cihar.com/ | https://weblate.org/
Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
Hi
Manish Bisht píše v Čt 29. 06. 2017 v 18:42 +0530:
regenerate sprites means new icons ?
No the sprites image, which is loaded once instead of may small icons, see https://github.com/phpmyadmin/phpmyadmin/wiki/Icons_Sprites_Usage
Thanks for the link, I have fixed all the three issues and pushed them live also.
Let me know if you have more suggestions.
Manish Bisht Email : hi@manishbisht.me Website : https://manishbisht.me
On Thu, Jun 29, 2017 at 6:53 PM, Michal Čihař michal@cihar.com wrote:
Hi
Manish Bisht píše v Čt 29. 06. 2017 v 18:42 +0530:
regenerate sprites means new icons ?
No the sprites image, which is loaded once instead of may small icons, see https://github.com/phpmyadmin/phpmyadmin/wiki/Icons_Sprites_Usage
-- Michal Čihař | https://cihar.com/ | https://weblate.org/
Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
-
Manish Bisht -
Michal Čihař