[Phpmyadmin-devel] Changes in SOB checking in pull requests
Hi all I've just changed way we check SOB lines in our pull requests. This check is no longer done by Travis, but rather by separate hook, which comments on individual commits in case SOB is missing. You can see example here: https://github.com/nijel/phpmyadmin/commit/6b22d159530337efab1def4d613387ac3... Source code for the hook is in our scripts repo: https://github.com/phpmyadmin/scripts/tree/master/hooks This has advantage that authors get direct feedback mentioning what is wrong and also these comments are directly visibly in pull request. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař a écrit :
Hi all
I've just changed way we check SOB lines in our pull requests. This check is no longer done by Travis, but rather by separate hook, which comments on individual commits in case SOB is missing. You can see example here:
https://github.com/nijel/phpmyadmin/commit/6b22d159530337efab1def4d613387ac3...
Source code for the hook is in our scripts repo:
https://github.com/phpmyadmin/scripts/tree/master/hooks
This has advantage that authors get direct feedback mentioning what is wrong and also these comments are directly visibly in pull request.
Thanks Michal, this will be very helpful. -- Marc Delisle http://infomarc.info | http://phpmyadmin.net
2014-03-13 11:54 GMT+01:00 Michal Čihař <michal@cihar.com>:
Hi all
I've just changed way we check SOB lines in our pull requests. This check is no longer done by Travis, but rather by separate hook, which comments on individual commits in case SOB is missing. You can see example here:
https://github.com/nijel/phpmyadmin/commit/6b22d159530337efab1def4d613387ac3...
Source code for the hook is in our scripts repo:
https://github.com/phpmyadmin/scripts/tree/master/hooks
This has advantage that authors get direct feedback mentioning what is wrong and also these comments are directly visibly in pull request.
Nice work ! Hugues.
Hi Dne Thu, 13 Mar 2014 11:54:25 +0100 Michal Čihař <michal@cihar.com> napsal(a):
Source code for the hook is in our scripts repo:
https://github.com/phpmyadmin/scripts/tree/master/hooks
This has advantage that authors get direct feedback mentioning what is wrong and also these comments are directly visibly in pull request.
I've just added check for tab characters in the code to the same hook, the sample message it has fired can be seen here: https://github.com/ganeshaditya1/phpmyadmin/commit/396ac695d439b0ac37f9c7c7e... -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
On Wed, Mar 19, 2014 at 11:39 PM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Thu, 13 Mar 2014 11:54:25 +0100 Michal Čihař <michal@cihar.com> napsal(a):
Source code for the hook is in our scripts repo:
https://github.com/phpmyadmin/scripts/tree/master/hooks
This has advantage that authors get direct feedback mentioning what is wrong and also these comments are directly visibly in pull request.
I've just added check for tab characters in the code to the same hook, the sample message it has fired can be seen here:
https://github.com/ganeshaditya1/phpmyadmin/commit/396ac695d439b0ac37f9c7c7e...
That's great!, something I always wanted. Thanks Michal. Another area for improvement would be to warn about trailing white spaces :)
-- Thanks and Regards, Madhura Jayaratne
Hi Dne Wed, 19 Mar 2014 23:46:14 +0530 Madhura Jayaratne <madhura.cj@gmail.com> napsal(a):
Another area for improvement would be to warn about trailing white spaces :)
Well best would be to run PHPCS on the diff, but I haven't figured out how to do that. Anyway I've added trailing whitespace and DOS end of lines to the list of checks: https://github.com/phpmyadmin/phpmyadmin/pull/1080 -- Michal Čihař | http://cihar.com | http://phpmyadmin.net
Le 2014-03-20 05:33, Michal Čihař a écrit :
Hi
Dne Wed, 19 Mar 2014 23:46:14 +0530 Madhura Jayaratne <madhura.cj@gmail.com> napsal(a):
Another area for improvement would be to warn about trailing white spaces :)
Well best would be to run PHPCS on the diff, but I haven't figured out how to do that.
Anyway I've added trailing whitespace and DOS end of lines to the list of checks:
Good idea! -- Marc Delisle http://phpmyadmin.net
On 3/19/14 2:09 PM, Michal Čihař wrote:
Hi
Dne Thu, 13 Mar 2014 11:54:25 +0100 Michal Čihař <michal@cihar.com> napsal(a):
Source code for the hook is in our scripts repo:
https://github.com/phpmyadmin/scripts/tree/master/hooks
This has advantage that authors get direct feedback mentioning what is wrong and also these comments are directly visibly in pull request.
I've just added check for tab characters in the code to the same hook, the sample message it has fired can be seen here:
https://github.com/ganeshaditya1/phpmyadmin/commit/396ac695d439b0ac37f9c7c7e...
Great work Michal. These improvements are the "little things" that make development and code checks so much easier over time. It's great to see these checks improve our tests and coverage.
participants (5)
-
Hugues Peccatte -
Isaac Bennetch -
Madhura Jayaratne -
Marc Delisle -
Michal Čihař