Hi, I am new here for GSOC. After reading the idea listed on link: https://wiki.phpmyadmin.net/pma/GSoC_2013_Ideas_List#Automated_testing I am quite interested on the topic: Automatic testing. I have some developing experience on selenium and PHP Code Coverage. I has digged into the phpmyadmin project. 1. I fork a phpmyadmin project https://github.com/adamgsoc2013/phpmyadmin 2. take some learning about the CI and Codecoverage on PHPMyadmin I am very familiar with the CI env and PHP code coverage, because I just finished a similiar project when I Intern on Yahoo! last year. I finished a automatic testing job: 1. PHP UNIT code and Functional testing code. 2. Commit to GIT will trigger a CI build. 3. The CI build is done by: slenium + Firefox+ Xvfb (so that we dont need display) 4. output the code coverage report. About the topic, at least two things should be done: 1. create more test cases to increase the code-coverage of the test-suite From the following data, Total48.55%11386 / 2345248.04%368 / 76615.79%9 / 57 libraries47.45%10894 / 2296048.04%368 / 76615.79%9 / 57 2. set up the necessary scripts to automate this. https://github.com/adamgsoc2013/phpmyadmin/tree/master/scripts I would like to send some patch to improve the code coverage. I am looking forward to hearing from you. thanks adam From: adam Date: 2013-03-21 00:40 To: Dieter Adriaenssens; phpmyadmin-devel Subject: about project: Automatic testing Thanks for your reply, Dieter I will dig into the information that you gave me deeper. I am very familiar with the CI env and PHP code coverage, because I just finished a similiar project when I Intern on Yahoo! last year. when I intern on Yahoo! last year, I finished a automatic testing job: 1. PHP UNIT code and Functional testing code. 2. Commit to SVN will trigger a CI build. 3. The CI build is done by: slenium + Firefox+ Xvfb (so that we dont need screen) 4. output the code coverage report. adam From: Dieter Adriaenssens Date: 2013-03-19 17:49 To: adamgsoc2013; phpmyadmin-devel Subject: Re: [Phpmyadmin-devel] new here for GSOC 2013/3/19 adam <adamgsoc2013(a)gmail.com>om>: Hi, If you are interested in applying for a GSoC project, you can take a look at our applicant guide [0], it will tell you what we expect from applicants. In case of the automated testing idea : A good way to start is to have a look at the current tests [1] and code coverage [2]. We expect you to provide a patch as part of your project proposal, so you can add a few tests to show us that you understand the code. [0] http://wiki.phpmyadmin.net/pma/GSoC_2013_Applicant_Guide [1] http://wiki.phpmyadmin.net/pma/Unit_Testing [2] http://ci.phpmyadmin.net/job/phpMyAdmin/cloverphp -- Kind regards, Dieter Adriaenssens

Hi first of all it is not needed to CC all my emails, using mailing list is enough :-). Dne Sat, 23 Mar 2013 18:18:36 +0800 adam <adamgsoc2013(a)gmail.com> napsal(a): You don't have to learn everything from the code, we have much of that documented: http://wiki.phpmyadmin.net/pma/Development Yes for links and for backward compatibility with non AJAX versions. Because they are not run in any testcase and they are not included in coverage report because of that. Yes, that's one of the goals for this GSoC project. Pretty much everything about testing is automated in build.xml in project root. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

Hi, I have a question about current Automatic testing process. When one guy finished a piece of code on the library folder about the Backend logic. Should he follows some instructions before check in code besides Code-review? 1. UT implementation 2. Regression --> this will be checked by CI Job 3. running regression and UT on his dev box? In my mind, the fomal processes should be: 1. add logic code 2. add UT code 3. test on dev box 4. run UT & regression test on dev box 5. code review after pass 1-4 6. checkin code 7. check CI build ..... thanks adam From: adam Date: 2013-03-26 18:17 To: phpmyadmin-devel Subject: Re: Re: [Phpmyadmin-devel] Automatic testing thanks MichalČihař, Yes, I am setting up the CI env on my dev box. after that, I can run the test report on my dev box, so that I can manager everything before checking code. right, we should increase the code coverage of Backend class since there are logic related. and the render php may be changed easily. thanks, adam From: MichalČihař Date: 2013-03-25 17:54 To: phpmyadmin-devel Subject: Re: [Phpmyadmin-devel] Automatic testing Hi first of all it is not needed to CC all my emails, using mailing list is enough :-). Dne Sat, 23 Mar 2013 18:18:36 +0800 adam <adamgsoc2013(a)gmail.com> napsal(a): You don't have to learn everything from the code, we have much of that documented: http://wiki.phpmyadmin.net/pma/Development Yes for links and for backward compatibility with non AJAX versions. Because they are not run in any testcase and they are not included in coverage report because of that. Yes, that's one of the goals for this GSoC project. Pretty much everything about testing is automated in build.xml in project root. -- Michal Čihař | http://cihar.com | http://blog.cihar.com ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

Hi Dieter, thanks for your reply. I was trying to apply the GSOC topic: Automatic testing. so I want to check with you guys about the fomal process In my mind, the regression tests is different from the unit tests. or in other word, we can say that the regression test include Unit tests. the regression test can include function test case beside unit tests. In my mind, in order to gurantee the code quality, UNIT test just cover the code logic, but Fuinctional test can be end to end case with real case. I agree with you. so the process should be: 1. Add UT code 2. Add logic code 3. test on dev box 4. run UT & regression test on dev box 5. check coding style compliance, with PHP_CodeSniffer <---- I think we should do it before code-review 6. code review 7 checkin code 8 check CI build result thanks, Adam

Hi, I also spent some time to think about the functional test case as well. ( I think this can be one part of the GSOC topic Automatic testing as well.) I think Selenium can cover Functional case as well. take index.php for example, we can use Selenium to load the index.php, and check the page element, such as <mainFrameset> and <frame_navigation> in other word, we can use selenium to check Page element is loaded correctly, I think this work is as important as Unit test. other benefit, we can cover phpmyadmin can work well one GradeA browsers. 1. check the page is loaded correctly 2. check the page is working well on GradeA browsers. 3. check the css/js is working well ...... and checking in code. totally agree, codesniffer can be one part of CI job, if the codesniffer failed, the CI should failed as well. thanks, Adam On Fri, Mar 29, 2013 at 6:41 PM, Dieter Adriaenssens < dieter.adriaenssens(a)gmail.com&gt; wrote: > 2013/3/29 adam &lt;adamgsoc2013(a)gmail.com&gt;om>: > > Hi Dieter, > > > > thanks for your reply. I was trying to apply the GSOC topic: Automatic > > testing. so I want to check with you guys about the fomal process > > > >> What do you mean by regression tests? How are they different from unit > >> tests? > >> The process you describe sounds reasonable. If you rearrange the order > >> a bit, and add codechecking to your process, you are on your way of > >> writing good code (see below for suggestions) > > > > In my mind, the regression tests is different from the unit tests. or in > > other word, we can say that the regression test include Unit tests. > > the regression test can include function test case beside unit tests. > > > > In my mind, in order to gurantee the code quality, UNIT test just cover > the > > code logic, but Fuinctional test can be end to end case with real case. > > Ok, makes sense. How do you plan to automate the functional tests? > > >> In my mind, the fomal processes should be: > >> 1. add UT code > >> (TDD [0] principle, write tests first, then start implementing the > >> class/method) > >> 2. add logic code > >> 3. test on dev box > >> 4. run UT & regression test on dev box > >> 5. code review after pass 1-4 > > > >> -> check coding style compliance, with PHP_CodeSniffer and fix the > >> reported issues. > >> You can run Jenkins on your own box, or execute `phpcs filename` on > >> the command line, more info on setting up Jenkins [1] > > > >> > 6. checkin code > >>> 7. check CI build > >>> ..... > > > > > > I agree with you. so the process should be: > > 1. Add UT code > > 2. Add logic code > > 3. test on dev box > > 4. run UT & regression test on dev box > > 5. check coding style compliance, with PHP_CodeSniffer <---- I think > we > > should do it before code-review > > > > > > best to test everything again after code reviewing and before > commiting and checking in code. > > > 7 checkin code > > 8 check CI build result > > > > > thanks, > > > > Adam > > > > -- > Kind regards, > > Dieter Adriaenssens >

Hi, In my mind, selenium lite version can't acchive this target, but we can use WebDriver to cover this situation. It is not the most important case in our testing, use page checking ,we can cover 90% important functional case. I will try to cover some important functional case besides Unit testing when doing the GSOC project: Automatic testing Thanks adam From: Dieter Adriaenssens Date: 2013-03-31 23:55 To: adam adam CC: phpmyadmin-devel Subject: Re: Re: [Phpmyadmin-devel] Automatic testing 2013/3/31 adam adam &lt;adamgsoc2013(a)gmail.com&gt; Sure. Just consider that some things are not outputted to the browser, like exporting and importing. Codesniffer is already a part of CI (see Jenkins reports [0]). I meant that you should check your coding style of the changes you made, before commiting. [0] http://ci.phpmyadmin.net/job/phpMyAdmin/ -- Kind regards, Dieter Adriaenssens

Hey, Marc, I would like to fix this bug. https://sourceforge.net/p/phpmyadmin/bugs/3742/ but I am quite confused about which space do you mean in the image? Attachment is the view from my side. thanks Adam

Le 2013-04-05 22:31, adam a écrit : Hi Adam, I explain which space I mean, in the bug ticket. See my comment with the marc.png screenshot. -- Marc Delisle http://infomarc.info