Hi, On Sat, Jul 11, 2009 at 4:53 AM, Marc Delisle<marc@infomarc.info> wrote:

Hi,

in libraries/config.default.php there are several mention of "DEFAULT" values for pmadb directives; however, the default values for all those are empty.

I would like to replace this mention of "DEFAULT" by "suggested". The only place we really use them are in config.sample.inc.php where they are in comments.

It does seem silly to have the file which loads the (empty) defaults use the word "DEFAULT" like this; I agree with the change from DEFAULT 'pmadb' to SUGGESTED 'pmadb'.

Also, the setup script says "default" (this idea was taken from the config.default.php) but IMO it should not say so.

Agreed The setup script still does not create the table structure, correct? I think this would be quite helpful.