Hello Isaac,

Thanks a lot for your prompt reply as well as for your valuable guidance. I've gone through the issue tracker and found so many interesting problems. I really like to start working on an issue soon as possible. In the meantime I myself found an issue in phpMyAdmin (version 4.6.2) which is not listed in the issue tracker. I've discussed it below.

When creating a routine using SQL commands in console, if we use label for loop

(eg: student_loop : LOOP), it identifies colon (:) as an unexpected token and shows error symbol at that line. But when we execute (i.e: when pressing "Go" button), it works fine without pushing any errors. Then when try to export, again it shows as there is an error at line which defines the label, but which is actually not an error. Please check the images I attached with this mail for further clarifications.

Is it okay if I open this as a new issue in the issues list? Also shall I start working on it?

Thanks in advance for your help.

Best regards, S.Pranavan

On Tuesday, 28 June 2016, 0:19, Isaac Bennetch bennetch@gmail.com wrote:

Hello S.Pranavan,

Thanks for your interest. The usual path for those looking to get involved with phpMyAdmin is to find an issue in the tracker (https://www.github.com/phpmyadmin/phpmyadmin/issues), work on it, and submit a pull request with those changes. Probably before beginning work, you should add a comment in the issue tracker stating that you're preparing to work on it, so that we don't duplicate efforts. Furthermore, we could unit tests to be developed for existing code, so if you don't see anything appealing in the issue tracker you might try that as well. Within the issue tracker, some issues are tagged with the "newbie" label which the development team thinks are good for people like you who are new to the codebase.

There's some general information for developers at https://wiki.phpmyadmin.net/pma/Development and https://wiki.phpmyadmin.net/pma/Category:Devel plus the Github documentation is quite good if you're new to Git or pull requests.

Of course, we're here to help with specific questions, but as a general overview that's the path you're looking at. If you have questions about how to start, please feel free to ask them here.

Isaac

On 6/27/16 12:01 PM, Pranavan New wrote:

I am S.Pranavan, a B.Sc. computer engineering undergraduate from University of Peradeniya, Sri Lanka. I am currently following third year of my degree and I have proficient knowledge in PHP and JavaScript. I would like to start working on open source developments and I found phpMyAdmin is the best place for a good start. I have been using phpMyAdmin for more than two years and I am very much willing to get involved in the development process of phpMyAdmin. Along with me some of my friends also would like to join the development team of phpMyAdmin. Can you guide us to get started with the project?

Best Regards, S.Pranavan

---

Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers

Hi

Dne 28.6.2016 v 17:13 Isaac Bennetch napsal(a):

Reply is in-line below:

On 6/28/16 10:28 AM, Pranavan New wrote:

...

Hello Isaac,

Thanks a lot for your prompt reply as well as for your valuable guidance. I've gone through the issue tracker and found so many interesting problems. I really like to start working on an issue soon as possible. In the meantime I myself found an issue in phpMyAdmin (version 4.6.2) which is not listed in the issue tracker. I've discussed it below.

When creating a routine using SQL commands in console, if we use label for loop

(eg: student_loop : LOOP), it identifies colon (:) as an unexpected token and shows error symbol at that line. But when we execute (i.e: when pressing "Go" button), it works fine without pushing any errors. Then when try to export, again it shows as there is an error at line which defines the label, but which is actually not an error. Please check the images I attached with this mail for further clarifications.

Is it okay if I open this as a new issue in the issues list? Also shall I start working on it?

Thanks in advance for your help.

Yes, this looks like a bug with the parser -- which is maintained as a separate repository https://github.com/phpmyadmin/sql-parser but then included in the main phpMyAdmin distribution through a Composer package. I haven't actually done any work on the parser myself, but guess the proper approach would be to checkout the phpmyadmin repository, then check out the sql-parser repository in the vendor subdirectory so you can do development work there. Perhaps someone else from the team can chime in if there's a better way.

You can also work only with the parser - it has few command line scripts to use and it has testsuite.