[Phpmyadmin-devel] Regarding Correcting Coding Standard Violations
Hi all, I created a pull [0] for the php error reporting functionality. phpmyadmin-bot shows so many coding standard violations. Should I correct them by pushing the changes as a separate commit? OR Do I need to redo all the previous commits? [0]: https://github.com/phpmyadmin/phpmyadmin/pull/1207 Thanks, Dhananjay Nakrani.
Hi Dne Fri, 6 Jun 2014 10:13:15 +0530 Dhananjay Nakrani <dhananjaynakrani@gmail.com> napsal(a):
I created a pull [0] for the php error reporting functionality. phpmyadmin-bot shows so many coding standard violations.
Should I correct them by pushing the changes as a separate commit? OR Do I need to redo all the previous commits?
It's okay to fix that in additional commit, but you can also fix the individual commits (git rebase -i can help you with that). -- Michal Čihař | http://cihar.com | http://blog.cihar.com
participants (2)
-
Dhananjay Nakrani -
Michal Čihař